log format '%P' only logs '/' when use chroot = true - Tools

This is a discussion on log format '%P' only logs '/' when use chroot = true - Tools ; The subject says it all :-) Apparently in pre-3.0.0 versions '%P' would log the actual path as specified in the module entry in rsyncd.conf, but now it's apparently relative to the chroot... Paul Slootman -- Please use reply-all for most ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: log format '%P' only logs '/' when use chroot = true

  1. log format '%P' only logs '/' when use chroot = true

    The subject says it all :-)
    Apparently in pre-3.0.0 versions '%P' would log the actual path as
    specified in the module entry in rsyncd.conf, but now it's apparently
    relative to the chroot...


    Paul Slootman
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


  2. Re: log format '%P' only logs '/' when use chroot = true

    On Wed 10 Sep 2008, Paul Slootman wrote:

    > Subject: log format '%P' only logs '/' when use chroot = true


    Hmm, my English is deteriorating...
    This would be better:

    Subject: log format '%P' logs just '/' when use chroot = true


    Paul
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


  3. Re: log format '%P' only logs '/' when use chroot = true

    On Wed, Sep 10, 2008 at 03:50:46PM +0200, Paul Slootman wrote:
    > Apparently in pre-3.0.0 versions '%P' would log the actual path as
    > specified in the module entry in rsyncd.conf, but now it's apparently
    > relative to the chroot...


    Yeah, that appears to have happened in the security release that added
    the ability to have an interior module path inside a chroot (so a
    patched 2.6.9 would also be affected). If the user is not using an
    interior-chroot path, then a single-line tweak in log.c would be all
    that is needed to avoid the issue. However, with an interior path, we
    need to take extra steps to avoid truncating the input value.

    The attached patch should fix things. It's relative to 3.0.4, but will
    also apply with a little twiddling to the 3.1.0dev source (and it should
    be easy to patch older versions too).

    ...wayne..

    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

  4. Re: log format '%P' only logs '/' when use chroot = true

    On Wed 10 Sep 2008, Wayne Davison wrote:
    >
    > The attached patch should fix things. It's relative to 3.0.4, but will
    > also apply with a little twiddling to the 3.1.0dev source (and it should
    > be easy to patch older versions too).


    Confirmed, this fixes it!
    Thanks.


    Paul
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


  5. Re: log format '%P' only logs '/' when use chroot = true

    On Wed, Sep 10, 2008 at 04:44:02PM -0700, Wayne Davison wrote:
    > The attached patch should fix things.


    That patch accidentally reverted an ability to transform a relative
    module path into an absolute one when chroot was not enabled. The
    attached patch fixes this.

    ...wayne..

    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

+ Reply to Thread