DO NOT REPLY [Bug 5732] New: xattrs.test calls wrong rsync - Tools

This is a discussion on DO NOT REPLY [Bug 5732] New: xattrs.test calls wrong rsync - Tools ; https://bugzilla.samba.org/show_bug.cgi?id=5732 Summary: xattrs.test calls wrong rsync Product: rsync Version: 3.0.4 Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: P3 Component: core AssignedTo: wayned@samba.org ReportedBy: petr.uzel@suse.cz QAContact: rsync-qa@samba.org In rsync 3.0.4pre2, the xattrs.test at some places does not call rsync ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: DO NOT REPLY [Bug 5732] New: xattrs.test calls wrong rsync

  1. DO NOT REPLY [Bug 5732] New: xattrs.test calls wrong rsync

    https://bugzilla.samba.org/show_bug.cgi?id=5732

    Summary: xattrs.test calls wrong rsync
    Product: rsync
    Version: 3.0.4
    Platform: All
    OS/Version: Linux
    Status: NEW
    Severity: normal
    Priority: P3
    Component: core
    AssignedTo: wayned@samba.org
    ReportedBy: petr.uzel@suse.cz
    QAContact: rsync-qa@samba.org


    In rsync 3.0.4pre2, the xattrs.test at some places does not call rsync as
    $RSYNC, but simply as rsync, which causes that :
    1) the test fails on systems where rsync is not installed
    2) it tests wrong binary (/usr/bin/rsync)

    Following patch fixes the problem:

    >From 844bdb5d32afe8ea7e59d0ea0c5dc9ce688c69d7 Mon Sep 17 00:00:00 2001

    From: Petr Uzel
    Date: Wed, 3 Sep 2008 16:12:31 +0200
    Subject: [PATCH] Fix xattrs.test - use $RSYNC instead of plain rsync

    ---
    testsuite/xattrs.test | 10 +++++-----
    1 files changed, 5 insertions(+), 5 deletions(-)

    diff --git a/testsuite/xattrs.test b/testsuite/xattrs.test
    index 86758fa..8b40eec 100644
    --- a/testsuite/xattrs.test
    +++ b/testsuite/xattrs.test
    @@ -116,10 +116,10 @@ fi
    cd "$fromdir"
    rm -rf "$todir" "$chkdir"

    -rsync -aX file1 file2
    -rsync -aX file1 file2 ../chk/
    -rsync -aX --del ../chk/ .
    -rsync -aX file1 ../lnk/
    +$RSYNC -aX file1 file2
    +$RSYNC -aX file1 file2 ../chk/
    +$RSYNC -aX --del ../chk/ .
    +$RSYNC -aX file1 ../lnk/

    xls file1 file2 >"$scratchdir/xattrs.txt"

    @@ -132,7 +132,7 @@ cd "$fromdir"
    rm "$todir/file2"

    echo extra >file1
    -rsync -aX . ../chk/
    +$RSYNC -aX . ../chk/

    checkit "$RSYNC -aiiX . ../to" "$chkdir" "$todir"

    --
    1.5.4.5


    --
    Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
    ------- You are receiving this mail because: -------
    You are the QA contact for the bug, or are watching the QA contact.
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


  2. DO NOT REPLY [Bug 5732] xattrs.test calls wrong rsync

    https://bugzilla.samba.org/show_bug.cgi?id=5732


    wayned@samba.org changed:

    What |Removed |Added
    ----------------------------------------------------------------------------
    Status|NEW |RESOLVED
    Resolution| |FIXED




    ------- Comment #1 from wayned@samba.org 2008-09-03 18:02 CST -------
    Thanks for pointing that out. I checked in your fix earlier today.


    --
    Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
    ------- You are receiving this mail because: -------
    You are the QA contact for the bug, or are watching the QA contact.
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


+ Reply to Thread