Re: rsync-3.0.2 -- two build problems - Tools

This is a discussion on Re: rsync-3.0.2 -- two build problems - Tools ; On Mon, Jun 02, 2008 at 07:31:02PM +0200, Peter Breitenlohner wrote: > (1) With the Linux kernel >=2.6.20, "make check" occasionally fails, due to > subsecond timestamps sometimes being truncated and sometimes being rounded > upwards (both on i686 and ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: Re: rsync-3.0.2 -- two build problems

  1. Re: rsync-3.0.2 -- two build problems

    On Mon, Jun 02, 2008 at 07:31:02PM +0200, Peter Breitenlohner wrote:
    > (1) With the Linux kernel >=2.6.20, "make check" occasionally fails, due to
    > subsecond timestamps sometimes being truncated and sometimes being rounded
    > upwards (both on i686 and x86_64).


    Rsync doesn't do any rounding, so I don't know where the inconsistency
    would be. We just set the desination time based on the mtime value, and
    the tls program outputs an interpretation of the mtime value.

    > For rsync-3.0.2, "make check" recompiles everything (not just the special
    > tools not needed otherwise), and "make install" again compiles everything.


    That was only true when building in a separate dir and only if the
    proto.h file was older than the newest .c file, but didn't need to be
    updated. I've fixed this in the latest source.

    ...wayne..
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


  2. Re: rsync-3.0.2 -- two build problems

    On Wed, 4 Jun 2008, Wayne Davison wrote:

    > On Mon, Jun 02, 2008 at 07:31:02PM +0200, Peter Breitenlohner wrote:
    >> (1) With the Linux kernel >=2.6.20, "make check" occasionally fails, due to
    >> subsecond timestamps sometimes being truncated and sometimes being rounded
    >> upwards (both on i686 and x86_64).

    >
    > Rsync doesn't do any rounding, so I don't know where the inconsistency
    > would be. We just set the desination time based on the mtime value, and
    > the tls program outputs an interpretation of the mtime value.


    Yesterday I did some tests (on jfs with subsecond timestamps, ext2 doesn't
    have them):

    True, rsync just truncates, i.e. ignores the fractional seconds, as do
    freerdist-0.92 and (GNU) tar.

    However, "cp -p" and "touch -r" round to the nearest second. So it seems the
    failures are caused by comparing a directory created by "cp" with one
    created by "rsync". Since spurious failures from "make check" defeat the
    purpose of a test suite, it might be a good idea to avoid such comparisions.

    regards
    Peter Breitenlohner
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


  3. Re: rsync-3.0.2 -- two build problems

    On Thu, Jun 05, 2008 at 08:22:09AM +0200, Peter Breitenlohner wrote:
    > However, "cp -p" and "touch -r" round to the nearest second.


    Can you try out the attached patch and let me know if it fixes the
    rounding issues?

    ...wayne..

    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

  4. Re: rsync-3.0.2 -- two build problems

    On Tue, 17 Jun 2008, Wayne Davison wrote:

    > On Thu, Jun 05, 2008 at 08:22:09AM +0200, Peter Breitenlohner wrote:
    >> However, "cp -p" and "touch -r" round to the nearest second.

    >
    > Can you try out the attached patch and let me know if it fixes the
    > rounding issues?


    I have just rebuilt rsync-3.0.2 with your patch (and have removed
    proto.h-tstamp from the source tree in order to prevent continuous
    recompilation).

    Your patch works nicely: "make check" used to have a failure rate of about
    50%; now I had twelve successful "make check" runs.

    Thanks a lot
    Peter Breitenlohner
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


+ Reply to Thread