DO NOT REPLY [Bug 5506] New: support utime differences at runtime,not configure/build time - Tools

This is a discussion on DO NOT REPLY [Bug 5506] New: support utime differences at runtime,not configure/build time - Tools ; https://bugzilla.samba.org/show_bug.cgi?id=5506 Summary: support utime differences at runtime, not configure/build time Product: rsync Version: 3.0.3 Platform: All URL: http://thread.gmane.org/gmane.networ...c.general/1794 8 OS/Version: Linux Status: NEW Severity: normal Priority: P3 Component: core AssignedTo: wayned@samba.org ReportedBy: vapier@gentoo.org QAContact: rsync-qa@samba.org http://bugs.gentoo.org/218577 the rsync code currently ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: DO NOT REPLY [Bug 5506] New: support utime differences at runtime,not configure/build time

  1. DO NOT REPLY [Bug 5506] New: support utime differences at runtime,not configure/build time

    https://bugzilla.samba.org/show_bug.cgi?id=5506

    Summary: support utime differences at runtime, not
    configure/build time
    Product: rsync
    Version: 3.0.3
    Platform: All
    URL: http://thread.gmane.org/gmane.networ...c.general/1794
    8
    OS/Version: Linux
    Status: NEW
    Severity: normal
    Priority: P3
    Component: core
    AssignedTo: wayned@samba.org
    ReportedBy: vapier@gentoo.org
    QAContact: rsync-qa@samba.org


    http://bugs.gentoo.org/218577

    the rsync code currently does things like:
    #ifdef HAVE_UTIMES

    #elif defined HAVE_UTIME

    #else
    fail!
    #endif

    the problem here is when rsync detects the utimes function. the older utime
    code is ifdef-ed away so it isnt available at runtime. that means rsync will
    only be runtime usable on newer systems. if you take a recent glibc and
    compile it against recent kernel headers, you get a C library that supports
    both utimes and utime, and will run fine regardless of the kernel. if it
    supports utimes(), glibc will return the expected values. if it doesnt,
    glibc will return ENOSYS.

    what i'm proposing is decoupling of the #if logic so that it isnt an if;else:
    #ifdef HAVE_UTIMES

    #endif
    #ifdef HAVE_UTIME

    #endif



    --
    Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
    ------- You are receiving this mail because: -------
    You are the QA contact for the bug, or are watching the QA contact.
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


  2. DO NOT REPLY [Bug 5506] support utime differences at runtime,not configure/build time

    https://bugzilla.samba.org/show_bug.cgi?id=5506





    ------- Comment #1 from wayned@samba.org 2008-05-31 10:50 CST -------
    Created an attachment (id=3324)
    --> (https://bugzilla.samba.org/attachmen...24&action=view)
    Patch to allow utimes or utime to be called

    This patch moves the time-calls into syscall.c (where they belong), and then
    extends the login in set_modtime() to allow a fallback of using do_utimes() to
    using do_times() if it gets an ENOSYS error on a normal file or directory. See
    what you think of this logic.


    --
    Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
    ------- You are receiving this mail because: -------
    You are the QA contact for the bug, or are watching the QA contact.
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


  3. DO NOT REPLY [Bug 5506] support utime differences at runtime,not configure/build time

    https://bugzilla.samba.org/show_bug.cgi?id=5506


    wayned@samba.org changed:

    What |Removed |Added
    ----------------------------------------------------------------------------
    Severity|normal |enhancement
    Status|NEW |ASSIGNED




    ------- Comment #2 from wayned@samba.org 2008-05-31 10:51 CST -------
    I'm considering this for inclusion in 3.0.4 (as it is too late to get into
    3.0.3).


    --
    Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
    ------- You are receiving this mail because: -------
    You are the QA contact for the bug, or are watching the QA contact.
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


  4. DO NOT REPLY [Bug 5506] support utime differences at runtime,not configure/build time

    https://bugzilla.samba.org/show_bug.cgi?id=5506





    ------- Comment #3 from vapier@gentoo.org 2008-05-31 12:06 CST -------
    that seems to accomplish what i proposed nicely ... i dont actually have a
    system to test against though, but i'll see if i can get someone to test it


    --
    Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
    ------- You are receiving this mail because: -------
    You are the QA contact for the bug, or are watching the QA contact.
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


  5. DO NOT REPLY [Bug 5506] support utime differences at runtime,not configure/build time

    https://bugzilla.samba.org/show_bug.cgi?id=5506





    ------- Comment #4 from vapier@gentoo.org 2008-06-01 16:49 CST -------
    i got a user who is affected by this and they said the patch in question worked
    for them when applied to rsync-3.0.2


    --
    Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
    ------- You are receiving this mail because: -------
    You are the QA contact for the bug, or are watching the QA contact.
    --
    Please use reply-all for most replies to avoid omitting the mailing list.
    To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
    Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


+ Reply to Thread