RE: [PATCH] [Re-Revised]: OneFS build issues for Samba 3.2 - Samba

This is a discussion on RE: [PATCH] [Re-Revised]: OneFS build issues for Samba 3.2 - Samba ; > -----Original Message----- > From: timur@bat.ru [mailto:timur@bat.ru] On Behalf Of Timur I. Bakeyev > > Hi, Zach! Hi! > On Wed, Jul 9, 2008 at 9:19 AM, Zachary Loafman > wrote: > > > > In addition, I rebased all ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: RE: [PATCH] [Re-Revised]: OneFS build issues for Samba 3.2

  1. RE: [PATCH] [Re-Revised]: OneFS build issues for Samba 3.2



    > -----Original Message-----
    > From: timur@bat.ru [mailto:timur@bat.ru] On Behalf Of Timur I. Bakeyev
    >
    > Hi, Zach!


    Hi!

    > On Wed, Jul 9, 2008 at 9:19 AM, Zachary Loafman
    > wrote:
    > >
    > > In addition, I rebased all the previous patches:
    > >
    > > 0001 - Check for f_frsize when you find statvfs. Yes, this is an

    oddity
    > > of our platform.

    >
    > Actually, are you sure, that stavfs() should be used? If you platform
    > based on FreeBSD - I'd rather use stafs().


    I'm ambivalent. The current autoconf script doesn't detect statfs for us
    because it's looking in sys/statfs.h, not sys/mount.h. Would you prefer
    we look for sys/mount.h and rewrite the "checking vfs_fileid: checking
    for statfs() and struct statfs.f_fsid" test to do the right thing? (I
    have a vague recollection that the ports patches do this correctly.) I
    can handle it that way, too.

    > > 0003 - Fixes various general warnings. The only potentially be
    > > objectionable one here is the iconv() change. If you wish, I can add

    >
    > This seems duplicate the work, been done in the FreeBSD samba3 port,
    > dunno, why this still wasn't comited into the main tree


    I didn't see a port yet for 3.2, and didn't figure I'd have much luck
    with the 3.0 patches, so I started from scratch. Looking now, yeah, I
    see you've done a bunch more with iconv. In general it would be nice to
    see anything in the patches/ dir of the port upstreamed instead - it
    seems like we should be able to find a way to integrate these happily.
    We will actually be maintaining a v3-3-test tree that's built on our
    box, so we'd really prefer not to have to maintain a slew of patches for
    minor issues that can be upstreamed.

    > > 0004 - Fixes some warnings that I'm pretty sure are specific to

    FreeBSD.
    > > Our 6.1 based system has reboot defined in unistd, so any variable

    using
    > > the name tickles -Wshadow, similarly for tcp_seq.

    >
    > This ones would be nice to get commited too...
    >
    > I'll try to check your patches together with other FreeBSD patches to
    > see, how do they fit the general distribution.


    I'd appreciate that.

    ....Zach


  2. Re: [PATCH] [Re-Revised]: OneFS build issues for Samba 3.2

    On Wed, Jul 09, 2008 at 09:56:46AM -0700, Zachary Loafman wrote:

    > I didn't see a port yet for 3.2, and didn't figure I'd have much luck
    > with the 3.0 patches, so I started from scratch. Looking now, yeah, I
    > see you've done a bunch more with iconv. In general it would be nice to
    > see anything in the patches/ dir of the port upstreamed instead - it
    > seems like we should be able to find a way to integrate these happily.
    > We will actually be maintaining a v3-3-test tree that's built on our
    > box, so we'd really prefer not to have to maintain a slew of patches for
    > minor issues that can be upstreamed.


    Send 'em to me and I'll add them in - thanks !

    Jeremy.


+ Reply to Thread