Re: [PATCH] Implement negative connection cache in terms of gencache - Samba

This is a discussion on Re: [PATCH] Implement negative connection cache in terms of gencache - Samba ; On Wed, Jun 04, 2008 at 03:29:07PM -0700, Marc VanHeyningen wrote: > Per our discussions of last month, here's a proposed change to implement > the negative connection cache in terms of the gencache. This permits > all process to ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: Re: [PATCH] Implement negative connection cache in terms of gencache

  1. Re: [PATCH] Implement negative connection cache in terms of gencache

    On Wed, Jun 04, 2008 at 03:29:07PM -0700, Marc VanHeyningen wrote:
    > Per our discussions of last month, here's a proposed change to implement
    > the negative connection cache in terms of the gencache. This permits
    > all process to share a single cache, rather than each of them
    > independently having to discover that a server is down. It amounts to a
    > complete replacement of libsmb/conncache.c.


    Thanks!

    Attached find some patches over yours, please comment. In
    particular the crash one should have shown up in your
    testing.

    In case you want to apply them, I've applied your patch with

    [apply]
    whitespace = strip

    in my ~/.gitconfig which removed some trailing whitespaces.
    So my patches might create conflicts, but I'd like to not
    add trailing whitespace in new code.

    Volker

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.5 (GNU/Linux)

    iD8DBQFIR5l+UzqjrWwMRl0RAhC/AJoCySYuJvfD36080fXUZ5qmY3pgfACcCZ5U
    GmziVPtC3IqusHkV5d4BIOo=
    =btKT
    -----END PGP SIGNATURE-----


  2. RE: [PATCH] Implement negative connection cache in terms of gencache

    Volker, thanks for the fixes. I initially write this on 3.0.23c
    (still in use here at Isilon for a while, alas) and forward-ported
    it, which is where the issues you found came in.

    Didn't know git could handle trailing whitespace automagically; handy!
    I'll add that to the default config information for everyone here at
    Isilon.

    Marc

    -----Original Message-----
    From: Volker Lendecke [mailto:Volker.Lendecke@SerNet.DE]
    Sent: Thursday, June 05, 2008 12:45 AM
    To: Marc VanHeyningen
    Cc: samba-technical@lists.samba.org
    Subject: Re: [PATCH] Implement negative connection cache in terms of
    gencache

    On Wed, Jun 04, 2008 at 03:29:07PM -0700, Marc VanHeyningen wrote:
    > Per our discussions of last month, here's a proposed change to

    implement
    > the negative connection cache in terms of the gencache. This permits
    > all process to share a single cache, rather than each of them
    > independently having to discover that a server is down. It amounts to

    a
    > complete replacement of libsmb/conncache.c.


    Thanks!

    Attached find some patches over yours, please comment. In
    particular the crash one should have shown up in your
    testing.

    In case you want to apply them, I've applied your patch with

    [apply]
    whitespace = strip

    in my ~/.gitconfig which removed some trailing whitespaces.
    So my patches might create conflicts, but I'd like to not
    add trailing whitespace in new code.

    Volker


  3. Re: [PATCH] Implement negative connection cache in terms of gencache

    On Thu, Jun 05, 2008 at 09:09:23AM -0700, Marc VanHeyningen wrote:
    > Volker, thanks for the fixes. I initially write this on 3.0.23c
    > (still in use here at Isilon for a while, alas) and forward-ported
    > it, which is where the issues you found came in.


    Ok, pushed to v3-3-test.

    Thanks,

    Volker

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.5 (GNU/Linux)

    iD8DBQFISiyHUzqjrWwMRl0RAgU0AJ0elE7eRhOEkDqe02g948 fJ2FK0/wCfSnt2
    axBmZ3EiQkKRG+N1kWWQ7xY=
    =cpZQ
    -----END PGP SIGNATURE-----


+ Reply to Thread