Build Farm temporary name issue - Samba

This is a discussion on Build Farm temporary name issue - Samba ; The build farm procedure "s4selftest_update" uses a rather roundabout method to copy the directory named "s4selftest" into (e.g.) "s4selftest.samba_3_2_test.gcc": s4selftest_update() { lock_file "s4selftest.lck" || { return 1; } copy_dir $s4selftest $s4selftest.$tree.$compiler.$$ || { rm -rf $s4selftest.$tree.$compiler.$$; unlock_file "s4selftest.lck"; return 1; ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: Build Farm temporary name issue

  1. Build Farm temporary name issue

    The build farm procedure "s4selftest_update" uses a rather roundabout
    method to copy the directory named "s4selftest" into (e.g.)
    "s4selftest.samba_3_2_test.gcc":

    s4selftest_update() {
    lock_file "s4selftest.lck" || {
    return 1;
    }

    copy_dir $s4selftest $s4selftest.$tree.$compiler.$$ || {
    rm -rf $s4selftest.$tree.$compiler.$$;
    unlock_file "s4selftest.lck";
    return 1;
    }

    rm -rf $s4selftest.$tree.$compiler
    mv $s4selftest.$tree.$compiler.$$ $s4selftest.$tree.$compiler

    unlock_file "s4selftest.lck"
    }

    It first copies the s4selftest subdirectory into a temporary,
    uniquely-named subdirectory, deletes the old target directory, then
    renames the temporary, uniquely-named subdirectory into the final target
    directory.

    This fails on host m104 because the directory name that is generated for
    the temporary directory is too long; while we now support 255-character
    file names, VOS still limits directory names to 32 characters. The
    generated name is 39 characters long.

    I see two potential solutions.

    (A) Do the operations in a different order that eliminates the need for
    the temporary directory.

    (B) Shorten the name of the temporary directory, for example,
    "$s4selftest.$$".

    I wanted to raise this issue and get a better understanding of the
    purpose of the existing logic before rushing in to change it. Can
    someone explain what's going on here?

    The least-disruptive change would seem to be choice (B). Is that OK
    with people?

    Thanks
    PG
    --
    Paul Green, Senior Technical Consultant, Stratus Technologies.
    Voice: +1 978-461-7557; FAX: +1 978-461-3610; Mobile: +1 (978) 235-2451;
    AIM: PaulGreen


  2. RE: Build Farm temporary name issue

    I have commited a change to build_test.fns that should resolve this
    issue on VOS, while not messing up any other system. I'll monitor the
    build farm to ensure that's the case.

    Thanks
    PG


    A few days ago, I wrote:
    > The build farm procedure "s4selftest_update" uses a rather roundabout
    > method to copy the directory named "s4selftest" into (e.g.)
    > "s4selftest.samba_3_2_test.gcc":
    >
    > s4selftest_update() {
    > lock_file "s4selftest.lck" || {
    > return 1;
    > }
    >
    > copy_dir $s4selftest $s4selftest.$tree.$compiler.$$ || {
    > rm -rf $s4selftest.$tree.$compiler.$$;
    > unlock_file "s4selftest.lck";
    > return 1;
    > }
    >
    > rm -rf $s4selftest.$tree.$compiler
    > mv $s4selftest.$tree.$compiler.$$ $s4selftest.$tree.$compiler
    >
    > unlock_file "s4selftest.lck"
    > }
    >
    > It first copies the s4selftest subdirectory into a temporary,
    > uniquely-named subdirectory, deletes the old target directory, then
    > renames the temporary, uniquely-named subdirectory into the
    > final target
    > directory.
    >
    > This fails on host m104 because the directory name that is
    > generated for
    > the temporary directory is too long; while we now support
    > 255-character
    > file names, VOS still limits directory names to 32 characters. The
    > generated name is 39 characters long.



  3. RE: Build Farm temporary name issue

    On Wed, 2008-06-04 at 10:26 -0400, Green, Paul wrote:
    > I have commited a change to build_test.fns that should resolve this
    > issue on VOS, while not messing up any other system. I'll monitor the
    > build farm to ensure that's the case.


    Thanks

    --
    Andrew Bartlett http://samba.org/~abartlet/
    Authentication Developer, Samba Team http://samba.org
    Samba Developer, Red Hat Inc. http://redhat.com


    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.9 (GNU/Linux)

    iD8DBQBIRzXgz4A8Wyi0NrsRAgnFAJ4jS9/i5ez+i7PShr9KAvwv2eekNACgoLhZ
    gyfPnNG+1HrnRqYjopuUR8I=
    =jvrg
    -----END PGP SIGNATURE-----


+ Reply to Thread