Re: [PATCH 2/N] cleanup return values of convert_string, push_utf8,and friends - Samba

This is a discussion on Re: [PATCH 2/N] cleanup return values of convert_string, push_utf8,and friends - Samba ; On Mon, May 12, 2008 at 05:29:16PM -0700, Tim Prouty wrote: > Here is the second round of fixes for the patch set we discussed that > cleans up the return values in charcnv.c. This one fixes the callers > ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: Re: [PATCH 2/N] cleanup return values of convert_string, push_utf8,and friends

  1. Re: [PATCH 2/N] cleanup return values of convert_string, push_utf8,and friends

    On Mon, May 12, 2008 at 05:29:16PM -0700, Tim Prouty wrote:
    > Here is the second round of fixes for the patch set we discussed that
    > cleans up the return values in charcnv.c. This one fixes the callers
    > of convert_string_allocate as well as their callers. This patch
    > turned out to be a bit larger then I wanted, but it was much cleaner
    > to just fix all callers at the same time.


    Ok, it's in. Sorry it took so long, we're a bit busy for
    release. I made your first one go into 3.2.0, but I think
    this is a bit late. (It would have been late even if I had
    reviewed it quicker... :-)

    I had to add the proto changes manually, and you forgot one
    call in vfs_catia.c. I just added that.

    Thanks for that cleanup, keep them coming!

    Volker

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.5 (GNU/Linux)

    iD8DBQFIM0BOUzqjrWwMRl0RAjYPAJ9+IeGXVXvBiuTGR42zh7 mi53HwnACdEFBL
    yD9QZ8HKkdSaP03OycES5v4=
    =EZS5
    -----END PGP SIGNATURE-----


  2. Re: [PATCH 2/N] cleanup return values of convert_string, push_utf8,and friends

    On May 20, 2008, at 2:19 PM, Volker Lendecke wrote:

    > I had to add the proto changes manually, and you forgot one
    > call in vfs_catia.c. I just added that.


    Yeah, I saw the proto mail Michael sent out. While there may be some
    pain in the short term, I think moving away from proto.h is a good
    idea. I'm surprised I missed that pull_ucs2_talloc in vfs_catia. Is
    vfs_catia not compiled by default?

    > Thanks for that cleanup, keep them coming!


    No problem. Thanks for reviewing a 2,000 line diff. I'll try to make
    future patches a bit more manageable .

    -Tim


  3. Re: [PATCH 2/N] cleanup return values of convert_string, push_utf8,and friends

    On Tue, May 20, 2008 at 05:05:35PM -0700, Tim Prouty wrote:
    > On May 20, 2008, at 2:19 PM, Volker Lendecke wrote:
    >
    > >I had to add the proto changes manually, and you forgot one
    > >call in vfs_catia.c. I just added that.

    >
    > Yeah, I saw the proto mail Michael sent out. While there may be some
    > pain in the short term, I think moving away from proto.h is a good
    > idea. I'm surprised I missed that pull_ucs2_talloc in vfs_catia. Is
    > vfs_catia not compiled by default?


    No, not compiled by default.

    > >Thanks for that cleanup, keep them coming!

    >
    > No problem. Thanks for reviewing a 2,000 line diff. I'll try to make
    > future patches a bit more manageable .


    It was quite mechanical, and I'm not 100% certain I would
    have caught a case when you would have exchanged a parameter
    in one of those function calls :-)

    Volker

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.5 (GNU/Linux)

    iD8DBQFIM7XjUzqjrWwMRl0RAs0lAJ9EAd1yD1i/rQs+mNJS2PTfGw4xXgCfYkuw
    vQspSFhgMXUZAVEUWRzQkqo=
    =Rf3f
    -----END PGP SIGNATURE-----


+ Reply to Thread