Re: [SCM] Samba Shared Repository - branch v3-3-test updated -release-3-2-0pre2-2485-g1c4adc8 - Samba

This is a discussion on Re: [SCM] Samba Shared Repository - branch v3-3-test updated -release-3-2-0pre2-2485-g1c4adc8 - Samba ; On Fri, May 16, 2008 at 07:23:51AM -0500, Günther Deschner wrote: > The branch, v3-3-test has been updated > via 1c4adc8dda68eae9839bdff843aadf8c98dd9e87 (commit) > from 452a9ea4af19d3aebc35929edaf4e5adf8c1fd11 (commit) > > http://gitweb.samba.org/?p=samba.git...og;h=v3-3-test > > > - Log ----------------------------------------------------------------- > commit 1c4adc8dda68eae9839bdff843aadf8c98dd9e87 > Author: ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: Re: [SCM] Samba Shared Repository - branch v3-3-test updated -release-3-2-0pre2-2485-g1c4adc8

  1. Re: [SCM] Samba Shared Repository - branch v3-3-test updated -release-3-2-0pre2-2485-g1c4adc8

    On Fri, May 16, 2008 at 07:23:51AM -0500, Günther Deschner wrote:
    > The branch, v3-3-test has been updated
    > via 1c4adc8dda68eae9839bdff843aadf8c98dd9e87 (commit)
    > from 452a9ea4af19d3aebc35929edaf4e5adf8c1fd11 (commit)
    >
    > http://gitweb.samba.org/?p=samba.git...og;h=v3-3-test
    >
    >
    > - Log -----------------------------------------------------------------
    > commit 1c4adc8dda68eae9839bdff843aadf8c98dd9e87
    > Author: Günther Deschner
    > Date: Fri May 16 13:24:15 2008 +0200
    >
    > Fix Bug #5461 and implement a very basic _samr_GetDisplayEnumerationIndex().
    >
    > Citrix PM cannot use a Samba DC when having more then 900 groups as citrix
    > insists on calling _samr_GetDisplayEnumerationIndex() after receiving the first
    > 900 groups via _samr_QueryDisplayInfo() to get the continuation index.
    >
    > Guenther


    Karolin, Guenther - I think this needs to be in 3.2-stable also.
    Now we have it in 3.0.x we must have the same fix in 3.2 else 3.2
    will be a regression against 3.0.x in this area.

    Jeremy.


  2. Re: [SCM] Samba Shared Repository - branch v3-3-test updated -release-3-2-0pre2-2485-g1c4adc8

    On Fri, May 16, 2008 at 10:02:01AM -0700, Jeremy Allison wrote:
    > On Fri, May 16, 2008 at 07:23:51AM -0500, Günther Deschner wrote:
    > > The branch, v3-3-test has been updated
    > > via 1c4adc8dda68eae9839bdff843aadf8c98dd9e87 (commit)
    > > from 452a9ea4af19d3aebc35929edaf4e5adf8c1fd11 (commit)
    > >
    > > http://gitweb.samba.org/?p=samba.git...og;h=v3-3-test
    > >
    > >
    > > - Log -----------------------------------------------------------------
    > > commit 1c4adc8dda68eae9839bdff843aadf8c98dd9e87
    > > Author: Günther Deschner
    > > Date: Fri May 16 13:24:15 2008 +0200
    > >
    > > Fix Bug #5461 and implement a very basic _samr_GetDisplayEnumerationIndex().
    > >
    > > Citrix PM cannot use a Samba DC when having more then 900 groups ascitrix
    > > insists on calling _samr_GetDisplayEnumerationIndex() after receiving the first
    > > 900 groups via _samr_QueryDisplayInfo() to get the continuation index.
    > >
    > > Guenther

    >
    > Karolin, Guenther - I think this needs to be in 3.2-stable also.
    > Now we have it in 3.0.x we must have the same fix in 3.2 else 3.2
    > will be a regression against 3.0.x in this area.


    I just tried to compile after applying the patch and it failed with:

    -----8<------------------snip--------------8<--------------
    Compiling rpc_server/srv_samr_nt.c
    rpc_server/srv_samr_nt.c: In function ‘_samr_GetDisplayEnumerationIndex’:
    rpc_server/srv_samr_nt.c:5756: error: invalid type argument of ‘->’
    rpc_server/srv_samr_nt.c:5760: error: invalid type argument of ‘->’
    rpc_server/srv_samr_nt.c:5761: error: invalid type argument of ‘->’
    The following command failed:
    gcc -I. -I/data/git/samba/v3-2-stable/source -O -g -D_SAMBA_BUILD_=3 -g
    -Wall -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings
    -DDEBUG_PASSWORD -DDEVELOPER -Wdeclaration-after-statement
    -Werror-implicit-function-declaration
    -I/data/git/samba/v3-2-stable/source/popt
    -I/data/git/samba/v3-2-stable/source/iniparser/src -Iinclude -I./include
    -I. -I. -I./lib/replace -I./lib/talloc -I./lib/tdb/include -I./libaddns
    -I./librpc -DHAVE_CONFIG_H -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
    -D_GNU_SOURCE -Iinclude -I./include -I. -I. -I./lib/replace -I./lib/talloc
    -I./lib/tdb/include -I./libaddns -I./librpc -I./popt -DLDAP_DEPRECATED
    -I/include -I/data/git/samba/v3-2-stable/source/lib -D_SAMBA_BUILD_=3
    -fPIC -c rpc_server/srv_samr_nt.c -o rpc_server/srv_samr_nt.o
    make: *** [rpc_server/srv_samr_nt.o] Fehler 1
    ----->8------------------snap-------------->8--------------

    Karolin

    --
    SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
    phone: +49-551-370000-0, fax: +49-551-370000-9
    AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
    http://www.SerNet.DE, mailto: Info @ SerNet.DE


    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v2.0.4-svn0 (GNU/Linux)

    iD8DBQFIMSv1KGi9fisXk1ERArNvAJ0XzF43l6vsFPiEUxsMtC ozEoCZygCdEUJH
    fpxCX7cpOE+RnPu9sguXo2U=
    =JKwy
    -----END PGP SIGNATURE-----


  3. Re: [SCM] Samba Shared Repository - branch v3-3-test updated -release-3-2-0pre2-2485-g1c4adc8

    On Mon, May 19, 2008 at 09:27:49AM +0200, Karolin Seeger wrote:
    > On Fri, May 16, 2008 at 10:02:01AM -0700, Jeremy Allison wrote:
    > > On Fri, May 16, 2008 at 07:23:51AM -0500, Günther Deschner wrote:
    > > > The branch, v3-3-test has been updated
    > > > via 1c4adc8dda68eae9839bdff843aadf8c98dd9e87 (commit)
    > > > from 452a9ea4af19d3aebc35929edaf4e5adf8c1fd11 (commit)
    > > >
    > > > http://gitweb.samba.org/?p=samba.git...og;h=v3-3-test
    > > >
    > > >
    > > > - Log -----------------------------------------------------------------
    > > > commit 1c4adc8dda68eae9839bdff843aadf8c98dd9e87
    > > > Author: Günther Deschner
    > > > Date: Fri May 16 13:24:15 2008 +0200
    > > >
    > > > Fix Bug #5461 and implement a very basic _samr_GetDisplayEnumerationIndex().
    > > >
    > > > Citrix PM cannot use a Samba DC when having more then 900 groups as citrix
    > > > insists on calling _samr_GetDisplayEnumerationIndex() after receiving the first
    > > > 900 groups via _samr_QueryDisplayInfo() to get the continuation index.
    > > >
    > > > Guenther

    > >
    > > Karolin, Guenther - I think this needs to be in 3.2-stable also.
    > > Now we have it in 3.0.x we must have the same fix in 3.2 else 3.2
    > > will be a regression against 3.0.x in this area.

    >
    > I just tried to compile after applying the patch and it failed with:


    Ah, looks like Guenther needs to do more work to back-port it then :-).

    Jeremy.


+ Reply to Thread