On Fri, May 09, 2008 at 10:48:45PM +0200, Michael Adam wrote:
>
> Why?
>
> I had some months ago put some effort in separating
> the posix implementations of get_net_acl and fget_nt_acl,
> removing the fsp part from the common code portion
> and removing the fsp parameter from the SMB_VFS_GET_NT_ACL.
>
> At that time you liked that, and I actually had the plan to
> do it for set_nt_acl_too ... :-) I'd like to understand your
> motivation in removing the non-F-variants:


Well the Windows clients only do ACL operations on open
file handles, so I'm trying to get our internal interface
to match that (need an open handle to do ACL operations) -
in the saem way Vl did this for rename. Direct operations
on pathnames are just not "windows'y".

I'd like to eventually move all the POSIX fns. out of
the VFS and into a module (from an idea by vl) and leave
fget_nt_acl() and fset_nt_acl() as the only interfaces
(although we might have to leave chmod_acl() and
fchmod_acl() in there for compatibility reasons).

Jeremy.