Re: Improving performance of winbindd_list_groups
--y0ulUmNC+osPPQO6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Thu, Apr 24, 2008 at 05:51:13PM -0700, Steven Danneman wrote:[color=blue]
> That's a good suggestion for even better performance. Attached is an
> updated patch using talloc_asprintf_append_buffer(). I'm wasn't
> positive from the API description that the returned string will be NULL
> terminated, but in all my tests it seems to be. Is this a correct
> assumption?[/color]
Yep. Down below it calls vsnprintf somewhere, that
terminates. I'd check in your patch, but I'd like Jerry to
take a look and comment first.
Volker
--y0ulUmNC+osPPQO6
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
iD8DBQFIEbujUzqjrWwMRl0RAi4XAJ4lZjmbhp3CCUsauRUIiM45LWsjvgCfRVFn
I80/BobOAUHcZA45d1hOW+Y=
=q8QU
-----END PGP SIGNATURE-----
--y0ulUmNC+osPPQO6--