On 01/04/2008, Jeremy Allison wrote:
> On Tue, Apr 01, 2008 at 03:45:17PM +0200, Karolin Seeger wrote:
> > Hi Jeremy,
> >
> > On Fri, Mar 28, 2008 at 07:33:31PM -0500, Jeremy Allison wrote:
> > > The branch, v3-2-test has been updated
> > > via 251df53811e4272b629575a4b50c29a99715ccf9 (commit)
> > > via 985bd1e642b6e54f1bc95cd4cfcceb96107e383d (commit)
> > > via eef53e9603d4f3d892ffe00b061def5d717ca481 (commit)
> > > from 73ead752c5ec7104ea0eed7d963dc36467c81981 (commit)
> > >
> > > http://gitweb.samba.org/?p=samba.git...og;h=v3-2-test
> > >
> > >
> > > - Log -----------------------------------------------------------------
> > > commit 251df53811e4272b629575a4b50c29a99715ccf9
> > > Author: Jeremy Allison
> > > Date: Fri Mar 28 17:32:52 2008 -0700
> > >
> > > Fix missing '&&'.
> > > Jeremy.
> > >
> > > commit 985bd1e642b6e54f1bc95cd4cfcceb96107e383d
> > > Merge: eef53e9603d4f3d892ffe00b061def5d717ca481 73ead752c5ec7104ea0eed7d963dc36467c81981
> > > Author: Jeremy Allison
> > > Date: Fri Mar 28 17:31:33 2008 -0700
> > >
> > > Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
> > >
> > > commit eef53e9603d4f3d892ffe00b061def5d717ca481
> > > Author: Jeremy Allison
> > > Date: Fri Mar 28 17:31:06 2008 -0700
> > >
> > > Only allow sendfile on non-stream fsp's. Should fix make test for streams
> > > as sendfile isn't implemented in the streams vfs modules yet.
> > > Jeremy.


Jeremy,

In my Darwin streams patch series, I added a sendfile capability bit
to files_struct that any VFS could set to tell the core server code
whether sendfile was safe for a particular file.



To me this seems more obvious and general-purpose than poking at base_fsp.


--
James Peach | jorgar@gmail.com