Yes - In addition to fixing the kcalloc checks the 4 session setup rout=
ines
need to be collapsed into a set of smaller routines with common code.
Since three of the four of those routines are disabled by default, clea=
ning
up the session setup cases (better consolidating the NTLM vs. NTLMSSP v=
s.
SPNEGO RFC2478) has been put off. Two of these four could shrink
significantly if Andrew Bartlett's suggestion of using ntlm_auth as a
helper function is chosen.


Steve French
Senior Software Engineer
Linux Technology Center - IBM Austin
phone: 512-838-2294
email: sfrench at-sign us dot ibm dot com

Dave Jones wrote on 04/17/2005 08:57:56 PM:

> On Mon, Apr 18, 2005 at 03:52:02AM +0200, Adrian Bunk wrote:
> > This patch removes cifs_kcalloc and replaces it with calls to
> > kcalloc(1, ...) .
> >
> > Signed-off-by: Adrian Bunk

>
> As a followup patch you might want to check the return value
> of all those calls before blindly deferencing them.
>
> Dave
>=