--=-ndbgAjcoCwmqQss6nXnJ
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Thu, 2004-11-25 at 20:01 +0000, metze@samba.org wrote:
> Author: metze
> Date: 2004-11-25 20:01:47 +0000 (Thu, 25 Nov 2004)
> New Revision: 3971
>=20
> WebSVN: http://websvn.samba.org/cgi-bin/view...ev&root=3Dsam=

ba&rev=3D3971
>=20
> Log:
> fix compiler warnings


I realise everybody is keen on cleaning up warnings, but watch out with
some of these changes:

> Modified: branches/SAMBA_4_0/source/libcli/auth/ntlmssp_parse.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3 D=3D=3D=3D=3D=3D=3D=3D=

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3 D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3 D=3D
> --- branches/SAMBA_4_0/source/libcli/auth/ntlmssp_parse.c 2004-11-25 19:5=

9:08 UTC (rev 3970)
> +++ branches/SAMBA_4_0/source/libcli/auth/ntlmssp_parse.c 2004-11-25 20:0=

1:47 UTC (rev 3971)
> @@ -115,7 +115,7 @@
> break;
> case 'C':
> s =3D va_arg(ap, char *);
> - pointers[i].data =3D s;
> + pointers[i].data =3D (void *)s;
> pointers[i].length =3D strlen(s)+1;
> head_size +=3D pointers[i].length;
> break;


a cast to void doesn't quite seem right here. DATA_BLOB.data is
uint8_t, so shouldn't this be a uint8_t cast? =20

> @@ -85,7 +85,7 @@
> static NTSTATUS try_trans2_len(struct smbcli_state *cli,=20
> const char *format,
> int op, int level,
> - char *param, char *data,
> + uint8_t *param, uint8_t *data,
> int param_len, int *data_len,
> int *rparam_len, int *rdata_len)
> {
> @@ -123,7 +123,7 @@
> int data_len =3D 0;
> int param_len =3D 0;
> int rparam_len, rdata_len;
> - pstring param, data;
> + uint8_t param[1024], data[1024];
> NTSTATUS status1, status2;
> =20
> memset(data, 0, sizeof(data));
> @@ -158,7 +158,7 @@
> int data_len =3D 0;
> int param_len =3D 0;
> int rparam_len, rdata_len;
> - pstring param, data;
> + uint8_t param[1024], data[1024];
> NTSTATUS status;
> =20
> memset(data, 0, sizeof(data));


I'm worried these changes are just going to make it harder to find and
eliminate pstrings from the source.=20

> @@ -324,7 +324,7 @@
> ************************************************** **********************=

****/
> static NTSTATUS try_nttrans(struct smbcli_state *cli,=20
> int op,
> - char *param, char *data,
> + uint8_t *param, uint8_t *data,
> int param_len, int data_len,
> int *rparam_len, int *rdata_len)
> {
> @@ -367,7 +367,7 @@
> static NTSTATUS try_nttrans_len(struct smbcli_state *cli,=20
> const char *format,
> int op, int level,
> - char *param, char *data,
> + uint8_t *param, uint8_t *data,
> int param_len, int *data_len,
> int *rparam_len, int *rdata_len)
> {
> @@ -405,7 +405,7 @@
> int data_len =3D 0;
> int param_len =3D 0;
> int rparam_len, rdata_len;
> - pstring param, data;
> + uint8_t param[1024], data[1024];
> NTSTATUS status;
> =20
> memset(data, 0, sizeof(data));


Likewise here.

Andrew Bartlett

--=20
Andrew Bartlett

--=-ndbgAjcoCwmqQss6nXnJ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQBBplO2z4A8Wyi0NrsRAvPMAKCrNgvXnEbgCVNEqjDfP5 Jo3RMihwCdGo0R
pHFvg1LsBU1RS40cE2koe7k=
=dKFh
-----END PGP SIGNATURE-----

--=-ndbgAjcoCwmqQss6nXnJ--