Re: [openssl.org #1752] DTLS drops incoming packets when they are reordered. - Openssl

This is a discussion on Re: [openssl.org #1752] DTLS drops incoming packets when they are reordered. - Openssl ; (Was waiting for the RT to autoreply with a number before I followed up, but it doesn't seem to have arrived after half an hour, so I'll send anyway. Hopefully the References: header will associate this with the previous mail ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: Re: [openssl.org #1752] DTLS drops incoming packets when they are reordered.

  1. Re: [openssl.org #1752] DTLS drops incoming packets when they are reordered.

    (Was waiting for the RT to autoreply with a number before I followed up,
    but it doesn't seem to have arrived after half an hour, so I'll send
    anyway. Hopefully the References: header will associate this with the
    previous mail anyway...)

    On Sun, 2008-10-05 at 21:38 +0100, David Woodhouse wrote:
    > That doesn't solve the question of why non-blocking I/O was returning
    > crap for the offending out-of-order packets, instead of just returning
    > an error with SSL_ERROR_WANT_READ as might be expected. But at least
    > it'll make that bug offend me less.


    This seems to fix the garbage packets.

    --- ssl/d1_pkt.c~ 2008-10-02 06:43:47.000000000 +0100
    +++ ssl/d1_pkt.c 2008-10-05 21:44:54.000000000 +0100
    @@ -597,6 +597,7 @@ again:
    /* check whether this is a repeat, or aged record */
    if ( ! dtls1_record_replay_check(s, bitmap, &(rr->seq_num)))
    {
    + rr->length = 0;
    s->packet_length=0; /* dump this record */
    goto again; /* get another record */
    }


    --
    David Woodhouse Open Source Technology Centre
    David.Woodhouse@intel.com Intel Corporation

    __________________________________________________ ____________________
    OpenSSL Project http://www.openssl.org
    Development Mailing List openssl-dev@openssl.org
    Automated List Manager majordomo@openssl.org


  2. Re: [openssl.org #1752] DTLS drops incoming packets when they arereordered.

    David Woodhouse via RT wrote:
    > (Was waiting for the RT to autoreply with a number before I followed up,
    > but it doesn't seem to have arrived after half an hour, so I'll send
    > anyway. Hopefully the References: header will associate this with the
    > previous mail anyway...)
    >


    Mailings to rt are moderated.
    The requested association was thus performed by the moderation
    mechanism :-)

    Best regards,
    Lutz
    __________________________________________________ ____________________
    OpenSSL Project http://www.openssl.org
    Development Mailing List openssl-dev@openssl.org
    Automated List Manager majordomo@openssl.org


  3. Re: [openssl.org #1752] DTLS drops incoming packets when they arereordered.

    On Mon, 2008-10-06 at 13:39 +0200, Lutz Jaenicke wrote:
    > David Woodhouse via RT wrote:
    > > (Was waiting for the RT to autoreply with a number before I followed up,
    > > but it doesn't seem to have arrived after half an hour, so I'll send
    > > anyway. Hopefully the References: header will associate this with the
    > > previous mail anyway...)
    > >

    >
    > Mailings to rt are moderated.
    > The requested association was thus performed by the moderation
    > mechanism :-)


    Out of interest, is there a similar magic incantation I could use to
    influence some 'mechanism' to actually apply the patches?

    I can understand some reticence on the patch which adds Cisco
    compatibility for DTLS (#1751) -- I was half expecting to be told
    there's a better way to do that.

    But the simple bug fixes which fix an assert() failure (#1703) and
    prevent it from either dropping misordered packets or receiving garbage
    when they occur (#1752)... those I kind of expected to go in a little
    quicker.

    --
    David Woodhouse Open Source Technology Centre
    David.Woodhouse@intel.com Intel Corporation

    __________________________________________________ ____________________
    OpenSSL Project http://www.openssl.org
    Development Mailing List openssl-dev@openssl.org
    Automated List Manager majordomo@openssl.org


+ Reply to Thread