Re: [openssl.org #1681] 0.9.8h bug report - Openssl

This is a discussion on Re: [openssl.org #1681] 0.9.8h bug report - Openssl ; Hi, You should not touch the file sha1-586.pl because the problem is located in the file x86ms.pl that is dedicated to MASM. In this file, the line 273 containing "$extra" should be removed to be able to compile the generated ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: Re: [openssl.org #1681] 0.9.8h bug report

  1. Re: [openssl.org #1681] 0.9.8h bug report

    Hi,

    You should not touch the file sha1-586.pl because the problem is located
    in the file x86ms.pl that is dedicated to MASM. In this file, the line 273
    containing "$extra" should be removed to be able to compile the generated
    assembly files.

    Cheers,
    --
    Mounir IDRASSI
    IDRIX
    http://www.idrix.fr

    On Thu, May 29, 2008 8:13 am, Craig Muchinsky via RT wrote:
    > I pulled down 0.9.8h today and attempted to build on a win32 machine,
    > but ran into an issue when compiling the generated s1_win32.asm file. It
    > looks like there is a syntax error in sha1-586.pl at line 152, the
    > second argument (16) is causing the following error:
    >
    >
    >
    > ml /Cp /coff /c /Cx /Focrypto\sha\asm\s1_win32.obj
    > .\crypto\sha\asm\s1_win32.asm
    >
    > Assembling: .\crypto\sha\asm\s1_win32.asm
    >
    > Microsoft (R) Macro Assembler Version 8.00.50727.762
    >
    > Copyright (C) Microsoft Corporation. All rights reserved.
    >
    > .\crypto\sha\asm\s1_win32.asm(13) : error A2008: syntax error :
    > integer
    >
    >
    >
    > NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
    > Studio 8\VC\bin\ml.EXE"' : return code '0x1'
    >
    > Stop.
    >
    >
    >
    > By simply removing the ',16' from line 152 everything compiles fine.
    >
    >
    >
    > Thanks,
    >
    > Craig Muchinsky
    >



    __________________________________________________ ____________________
    OpenSSL Project http://www.openssl.org
    Development Mailing List openssl-dev@openssl.org
    Automated List Manager majordomo@openssl.org


  2. Re: [openssl.org #1681] 0.9.8h bug report

    Hi,

    You should not touch the file sha1-586.pl because the problem is located
    in the file x86ms.pl that is dedicated to MASM. In this file, the line 273
    containing "$extra" should be removed to be able to compile the generated
    assembly files.

    Cheers,
    --
    Mounir IDRASSI
    IDRIX
    http://www.idrix.fr

    On Thu, May 29, 2008 8:13 am, Craig Muchinsky via RT wrote:
    > I pulled down 0.9.8h today and attempted to build on a win32 machine,
    > but ran into an issue when compiling the generated s1_win32.asm file. It
    > looks like there is a syntax error in sha1-586.pl at line 152, the
    > second argument (16) is causing the following error:
    >
    >
    >
    > ml /Cp /coff /c /Cx /Focrypto\sha\asm\s1_win32.obj
    > .\crypto\sha\asm\s1_win32.asm
    >
    > Assembling: .\crypto\sha\asm\s1_win32.asm
    >
    > Microsoft (R) Macro Assembler Version 8.00.50727.762
    >
    > Copyright (C) Microsoft Corporation. All rights reserved.
    >
    > .\crypto\sha\asm\s1_win32.asm(13) : error A2008: syntax error :
    > integer
    >
    >
    >
    > NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
    > Studio 8\VC\bin\ml.EXE"' : return code '0x1'
    >
    > Stop.
    >
    >
    >
    > By simply removing the ',16' from line 152 everything compiles fine.
    >
    >
    >
    > Thanks,
    >
    > Craig Muchinsky
    >


    __________________________________________________ ____________________
    OpenSSL Project http://www.openssl.org
    Development Mailing List openssl-dev@openssl.org
    Automated List Manager majordomo@openssl.org


  3. Re: [openssl.org #1681] 0.9.8h bug report

    > You should not touch the file sha1-586.pl

    sha1-586.pl was back-ported from in-development HEAD branch and extra
    argument is a left-over and *should not* be there.

    > because the problem is located
    > in the file x86ms.pl that is dedicated to MASM. In this file, the line 273
    > containing "$extra" should be removed to be able to compile the generated
    > assembly files.


    $extra is used in another modules. They, other modules, *might* work
    without it now, but it used to be required. Given *might*/*should not*
    relationship, it's extra argument of 16 in sha1-586.pl that should go,
    not $extra in x86ms.pl. Changes are committed and case is being
    dismissed. A.


    __________________________________________________ ____________________
    OpenSSL Project http://www.openssl.org
    Development Mailing List openssl-dev@openssl.org
    Automated List Manager majordomo@openssl.org


+ Reply to Thread