Yair Elharrar via RT wrote:
....
> diff -ur openssl-0.9.8-stable-SNAP-20050720\crypto\asn1\tasn_new.c
> openssl-0.9.8-mod\crypto\asn1\tasn_new.c
> --- openssl-0.9.8-stable-SNAP-20050720\crypto\asn1\tasn_new.c Wed May 11
> 06:45:24 2005
> +++ openssl-0.9.8-mod\crypto\asn1\tasn_new.c Wed Jul 20 14:57:44 2005
> @@ -326,8 +326,8 @@
> {
> ASN1_TYPE *typ;
> int utype;
> - const ASN1_PRIMITIVE_FUNCS *pf;
> - pf = it->funcs;
> + const ASN1_PRIMITIVE_FUNCS *pf=NULL;
> + if (it) pf = it->funcs;
>
> if (pf && pf->prim_new)
> return pf->prim_new(pval, it);
> @@ -374,8 +374,8 @@
> void asn1_primitive_clear(ASN1_VALUE **pval, const ASN1_ITEM *it)
> {
> int utype;
> - const ASN1_PRIMITIVE_FUNCS *pf;
> - pf = it->funcs;
> + const ASN1_PRIMITIVE_FUNCS *pf=NULL;
> + if (it) pf = it->funcs;
> if (pf)
> {
> if (pf->prim_clear)


Steve committed a different patch

> diff -ur openssl-0.9.8-stable-SNAP-20050720\crypto\ec\ec_lib.c
> openssl-0.9.8-mod\crypto\ec\ec_lib.c
> --- openssl-0.9.8-stable-SNAP-20050720\crypto\ec\ec_lib.c Sat May 21
> 03:00:42 2005
> +++ openssl-0.9.8-mod\crypto\ec\ec_lib.c Wed Jul 20 15:03:06 2005
> @@ -145,7 +145,7 @@
> {
> if (!group) return;
>
> - if (group->meth->group_clear_finish != 0)
> + if (group->meth && group->meth->group_clear_finish != 0)
> group->meth->group_clear_finish(group);
> else if (group->meth != NULL && group->meth->group_finish != 0)
> group->meth->group_finish(group);
> @@ -728,7 +728,7 @@
> {
> if (!point) return;
>
> - if (point->meth->point_finish != 0)
> + if (point->meth && point->meth->point_finish != 0)
> point->meth->point_finish(point);
> OPENSSL_free(point);
> }
> @@ -738,7 +738,7 @@
> {
> if (!point) return;
>
> - if (point->meth->point_clear_finish != 0)
> + if (point->meth && point->meth->point_clear_finish != 0)
> point->meth->point_clear_finish(point);
> else if (point->meth != NULL && point->meth->point_finish != 0)
> point->meth->point_finish(point);


no, unless something very strange has happened meth cannot be NULL

otherwise, see
http://marc.theaimsgroup.com/?l=open...1132500534&w=2

Thanks,
Nils

__________________________________________________ ____________________
OpenSSL Project http://www.openssl.org
Development Mailing List openssl-dev@openssl.org
Automated List Manager majordomo@openssl.org