[PATCH 0/1] ring-buffer: disable tracing switch - Kernel

This is a discussion on [PATCH 0/1] ring-buffer: disable tracing switch - Kernel ; Stephen and Ingo, I've been pressured into making this patch for mainline. It is a low risk patch, but I would like to get it into linux-next. This patch adds a way for a kernel developer to stop all tracers ...

+ Reply to Thread
Results 1 to 6 of 6

Thread: [PATCH 0/1] ring-buffer: disable tracing switch

  1. [PATCH 0/1] ring-buffer: disable tracing switch


    Stephen and Ingo,

    I've been pressured into making this patch for mainline. It is a low risk
    patch, but I would like to get it into linux-next.

    This patch adds a way for a kernel developer to stop all tracers from
    within the kernel and restart it from userspace. The previous APIs that
    allowed for kernel stopping the tracer did not allow for userspace to
    restart. This was mainly because the stopping could be for areas that
    are dangerous to be tracing, and allowing userspace to start them could
    risk the system stability.

    This switch is made to let userspace interact with the kernel space
    in starting and stopping tracers.

    The following patches are in:

    git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git

    branch: devel


    Steven Rostedt (1):
    ring-buffer: buffer record on/off switch

    ----
    include/linux/ring_buffer.h | 3 +
    kernel/trace/ftrace.c | 8 +---
    kernel/trace/ring_buffer.c | 101 +++++++++++++++++++++++++++++++++++++++++++
    3 files changed, 106 insertions(+), 6 deletions(-)

    --
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 0/1] ring-buffer: disable tracing switch


    * Steven Rostedt wrote:

    > Stephen and Ingo,
    >
    > I've been pressured into making this patch for mainline. It is a low
    > risk patch, but I would like to get it into linux-next.


    pulled, and pushed out into tip/auto-ftrace-next, thanks Steve.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH 1/1] ring-buffer: buffer record on/off switch


    * Steven Rostedt wrote:

    >
    > On Tue, 11 Nov 2008, Andrew Morton wrote:
    >
    > > On Tue, 11 Nov 2008 15:06:02 -0500
    > > Steven Rostedt wrote:
    > >
    > > > +static struct file_operations rb_simple_fops = {

    > >
    > > should be const...
    > >
    > > Probably it isn't worth fixing. Someone(tm) should do period sweeps -
    > > 10% of our file_operationses aren't const.

    >
    > Thanks, I never really thought about it.
    >
    > I'll add to my todo list to send out a patch that cleans all of this
    > up. I think I'm guilty at doing this in more than one place.


    Perhaps checkpatch.pl could remind us about it? a new file_operations
    struct definition should be const in 99.9% of the cases.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH 1/1] ring-buffer: buffer record on/off switch


    [ Added Andy on Cc ]

    On Tue, 11 Nov 2008, Andrew Morton wrote:

    > On Tue, 11 Nov 2008 15:06:02 -0500
    > Steven Rostedt wrote:
    >
    > > +static struct file_operations rb_simple_fops = {

    >
    > should be const...
    >
    > Probably it isn't worth fixing. Someone(tm) should do period sweeps -
    > 10% of our file_operationses aren't const.


    I wonder if this should be added to checkpatch?

    -- Steve

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [PATCH 1/1] ring-buffer: buffer record on/off switch

    On Tue, 11 Nov 2008 15:06:02 -0500
    Steven Rostedt wrote:

    > +static struct file_operations rb_simple_fops = {


    should be const...

    Probably it isn't worth fixing. Someone(tm) should do period sweeps -
    10% of our file_operationses aren't const.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  6. Re: [PATCH 1/1] ring-buffer: buffer record on/off switch


    On Tue, 11 Nov 2008, Andrew Morton wrote:

    > On Tue, 11 Nov 2008 15:06:02 -0500
    > Steven Rostedt wrote:
    >
    > > +static struct file_operations rb_simple_fops = {

    >
    > should be const...
    >
    > Probably it isn't worth fixing. Someone(tm) should do period sweeps -
    > 10% of our file_operationses aren't const.


    Thanks, I never really thought about it.

    I'll add to my todo list to send out a patch that cleans all of this up. I
    think I'm guilty at doing this in more than one place.

    -- Steve

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread