Re:[PATCH 1/2] x86: Fixing improper annotation. - Kernel

This is a discussion on Re:[PATCH 1/2] x86: Fixing improper annotation. - Kernel ; Hi Rakib, Your two patches set for x86 init_thread_xsate function section mismatch is correct to fix the compilation warning, but generates this other one : > WARNING: vmlinux.o(.cpuinit.text+0x7de): Section mismatch in reference > from the function xsave_cntxt_init() to the function ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: Re:[PATCH 1/2] x86: Fixing improper annotation.

  1. Re:[PATCH 1/2] x86: Fixing improper annotation.

    Hi Rakib,


    Your two patches set for x86 init_thread_xsate function section mismatch
    is correct to fix the compilation warning, but generates this other one :

    > WARNING: vmlinux.o(.cpuinit.text+0x7de): Section mismatch in reference
    > from the function xsave_cntxt_init() to the function
    > .init.text:__alloc_bootmem()
    > The function __cpuinit xsave_cntxt_init() references
    > a function __init __alloc_bootmem().
    > If __alloc_bootmem is only used by xsave_cntxt_init then
    > annotate __alloc_bootmem with a matching annotation.

    Thanks for your good job.

    Regards.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 1/2] x86: Fixing improper annotation.

    Ingo Molnar wrote:
    > * Rufus& Azrael wrote:
    >
    >
    >> Hi Rakib,
    >>
    >>
    >> Your two patches set for x86 init_thread_xsate function section
    >> mismatch is correct to fix the compilation warning, but generates
    >> this other one :
    >>
    >>
    >>> WARNING: vmlinux.o(.cpuinit.text+0x7de): Section mismatch in reference
    >>> from the function xsave_cntxt_init() to the function
    >>> .init.text:__alloc_bootmem()
    >>> The function __cpuinit xsave_cntxt_init() references
    >>> a function __init __alloc_bootmem().
    >>> If __alloc_bootmem is only used by xsave_cntxt_init then
    >>> annotate __alloc_bootmem with a matching annotation.
    >>>

    >
    > that's with both 1/2 and 2/2 applied?
    >
    > Ingo
    >
    >

    Yes Ingo with the two patches applied.

    Regards.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH 1/2] x86: Fixing improper annotation.


    * Rufus & Azrael wrote:

    > Hi Rakib,
    >
    >
    > Your two patches set for x86 init_thread_xsate function section
    > mismatch is correct to fix the compilation warning, but generates
    > this other one :
    >
    >> WARNING: vmlinux.o(.cpuinit.text+0x7de): Section mismatch in reference
    >> from the function xsave_cntxt_init() to the function
    >> .init.text:__alloc_bootmem()
    >> The function __cpuinit xsave_cntxt_init() references
    >> a function __init __alloc_bootmem().
    >> If __alloc_bootmem is only used by xsave_cntxt_init then
    >> annotate __alloc_bootmem with a matching annotation.


    that's with both 1/2 and 2/2 applied?

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH 1/2] x86: Fixing improper annotation.


    * Rufus & Azrael wrote:

    > Ingo Molnar wrote:
    >> * Rufus& Azrael wrote:
    >>
    >>
    >>> Hi Rakib,
    >>>
    >>>
    >>> Your two patches set for x86 init_thread_xsate function section
    >>> mismatch is correct to fix the compilation warning, but generates
    >>> this other one :
    >>>
    >>>
    >>>> WARNING: vmlinux.o(.cpuinit.text+0x7de): Section mismatch in reference
    >>>> from the function xsave_cntxt_init() to the function
    >>>> .init.text:__alloc_bootmem()
    >>>> The function __cpuinit xsave_cntxt_init() references
    >>>> a function __init __alloc_bootmem().
    >>>> If __alloc_bootmem is only used by xsave_cntxt_init then
    >>>> annotate __alloc_bootmem with a matching annotation.
    >>>>

    >>
    >> that's with both 1/2 and 2/2 applied?
    >>
    >> Ingo
    >>
    >>

    > Yes Ingo with the two patches applied.


    okay - so i wont apply them until the full scope of the problems here
    is mapped. We might be best off by marking xsave_cntxt_init() non-init
    altogether for the time being?

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [PATCH 1/2] x86: Fixing improper annotation.

    On 11/11/08, Ingo Molnar wrote:

    >
    > okay - so i wont apply them until the full scope of the problems here
    > is mapped. We might be best off by marking xsave_cntxt_init() non-init
    > altogether for the time being?

    But, it's been called from an __init section, it will also trigger an
    warning too. So, it
    will remain as it was. If we goes to hunt these warnings ( I mean
    we've to replace __init __alloc_bootmem() with __cpuinit
    __alloc_bootmem() ) , it's not certain when it will stop. Likely , we
    need to replace a lots of __init with __cpuinit.

    Rakib
    >
    > Ingo
    >

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread