Re:[PATCH 1/2] x86: Fixing improper annotation.

Hi Rakib,


Your two patches set for x86 init_thread_xsate function section mismatch
is correct to fix the compilation warning, but generates this other one :
[color=blue]
> WARNING: vmlinux.o(.cpuinit.text+0x7de): Section mismatch in reference
> from the function xsave_cntxt_init() to the function
> .init.text:__alloc_bootmem()
> The function __cpuinit xsave_cntxt_init() references
> a function __init __alloc_bootmem().
> If __alloc_bootmem is only used by xsave_cntxt_init then
> annotate __alloc_bootmem with a matching annotation.[/color]
Thanks for your good job.

Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]

Ingo Molnar wrote:[color=blue]
> * Rufus& Azrael<rufus-azrael@numericable.fr> wrote:
>
>[color=green]
>> Hi Rakib,
>>
>>
>> Your two patches set for x86 init_thread_xsate function section
>> mismatch is correct to fix the compilation warning, but generates
>> this other one :
>>
>>[color=darkred]
>>> WARNING: vmlinux.o(.cpuinit.text+0x7de): Section mismatch in reference
>>> from the function xsave_cntxt_init() to the function
>>> .init.text:__alloc_bootmem()
>>> The function __cpuinit xsave_cntxt_init() references
>>> a function __init __alloc_bootmem().
>>> If __alloc_bootmem is only used by xsave_cntxt_init then
>>> annotate __alloc_bootmem with a matching annotation.
>>>[/color][/color]
>
> that's with both 1/2 and 2/2 applied?
>
> Ingo
>
>[/color]
Yes Ingo with the two patches applied.

Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]

* Rufus & Azrael <rufus-azrael@numericable.fr> wrote:
[color=blue]
> Hi Rakib,
>
>
> Your two patches set for x86 init_thread_xsate function section
> mismatch is correct to fix the compilation warning, but generates
> this other one :
>[color=green]
>> WARNING: vmlinux.o(.cpuinit.text+0x7de): Section mismatch in reference
>> from the function xsave_cntxt_init() to the function
>> .init.text:__alloc_bootmem()
>> The function __cpuinit xsave_cntxt_init() references
>> a function __init __alloc_bootmem().
>> If __alloc_bootmem is only used by xsave_cntxt_init then
>> annotate __alloc_bootmem with a matching annotation.[/color][/color]

that's with both 1/2 and 2/2 applied?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]

* Rufus & Azrael <rufus-azrael@numericable.fr> wrote:
[color=blue]
> Ingo Molnar wrote:[color=green]
>> * Rufus& Azrael<rufus-azrael@numericable.fr> wrote:
>>
>>[color=darkred]
>>> Hi Rakib,
>>>
>>>
>>> Your two patches set for x86 init_thread_xsate function section
>>> mismatch is correct to fix the compilation warning, but generates
>>> this other one :
>>>
>>>
>>>> WARNING: vmlinux.o(.cpuinit.text+0x7de): Section mismatch in reference
>>>> from the function xsave_cntxt_init() to the function
>>>> .init.text:__alloc_bootmem()
>>>> The function __cpuinit xsave_cntxt_init() references
>>>> a function __init __alloc_bootmem().
>>>> If __alloc_bootmem is only used by xsave_cntxt_init then
>>>> annotate __alloc_bootmem with a matching annotation.
>>>>[/color]
>>
>> that's with both 1/2 and 2/2 applied?
>>
>> Ingo
>>
>>[/color]
> Yes Ingo with the two patches applied.[/color]

okay - so i wont apply them until the full scope of the problems here
is mapped. We might be best off by marking xsave_cntxt_init() non-init
altogether for the time being?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]

On 11/11/08, Ingo Molnar <mingo@elte.hu> wrote:
[color=blue]
>
> okay - so i wont apply them until the full scope of the problems here
> is mapped. We might be best off by marking xsave_cntxt_init() non-init
> altogether for the time being?[/color]
But, it's been called from an __init section, it will also trigger an
warning too. So, it
will remain as it was. If we goes to hunt these warnings ( I mean
we've to replace __init __alloc_bootmem() with __cpuinit
__alloc_bootmem() ) , it's not certain when it will stop. Likely , we
need to replace a lots of __init with __cpuinit.

Rakib[color=blue]
>
> Ingo
>[/color]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]