[PATCH] Use single threaded work queue for hid_compat - Kernel

This is a discussion on [PATCH] Use single threaded work queue for hid_compat - Kernel ; Use single threaded work queue for hid_compat I doubt HID really needs to scale over multiple CPUs. So only use a single threaded workqueue for HID_COMPAT. This avoids some excessive thread use on systems with a larger number of CPUs. ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] Use single threaded work queue for hid_compat

  1. [PATCH] Use single threaded work queue for hid_compat

    Use single threaded work queue for hid_compat

    I doubt HID really needs to scale over multiple CPUs. So only use a
    single threaded workqueue for HID_COMPAT. This avoids some excessive
    thread use on systems with a larger number of CPUs.

    Should still go into 2.6.28 if possible.

    Signed-off-by: Andi Kleen

    ---
    drivers/hid/hid-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: linux-2.6.28-rc4-test/drivers/hid/hid-core.c
    ================================================== =================
    --- linux-2.6.28-rc4-test.orig/drivers/hid/hid-core.c 2008-11-06 20:26:34.000000000 +0100
    +++ linux-2.6.28-rc4-test/drivers/hid/hid-core.c 2008-11-10 22:36:49.000000000 +0100
    @@ -1729,7 +1729,7 @@
    goto err_bus;

    #ifdef CONFIG_HID_COMPAT
    - hid_compat_wq = create_workqueue("hid_compat");
    + hid_compat_wq = create_singlethread_workqueue("hid_compat");
    if (!hid_compat_wq) {
    hidraw_exit();
    goto err;
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] Use single threaded work queue for hid_compat

    On Mon, 10 Nov 2008, Andi Kleen wrote:

    > I doubt HID really needs to scale over multiple CPUs. So only use a
    > single threaded workqueue for HID_COMPAT. This avoids some excessive
    > thread use on systems with a larger number of CPUs.


    Yes, makes sense, thanks. Applied.

    --
    Jiri Kosina
    SUSE Labs
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread