[PATCH] hid: Complete support for the new unibody macbooks - Kernel

This is a discussion on [PATCH] hid: Complete support for the new unibody macbooks - Kernel ; The unibody MacBook 5 and MacBook Pro 5 come with a new version of the bcm5974 trackpad. This patch adds the USB device ids and all the appropriate quirks, including hid_blacklist. Signed-off-by: Henrik Rydberg --- drivers/hid/hid-apple.c | 6 ++++++ drivers/hid/hid-core.c ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: [PATCH] hid: Complete support for the new unibody macbooks

  1. [PATCH] hid: Complete support for the new unibody macbooks

    The unibody MacBook 5 and MacBook Pro 5 come with a new version of
    the bcm5974 trackpad. This patch adds the USB device ids and all
    the appropriate quirks, including hid_blacklist.

    Signed-off-by: Henrik Rydberg
    ---
    drivers/hid/hid-apple.c | 6 ++++++
    drivers/hid/hid-core.c | 6 ++++++
    drivers/hid/hid-ids.h | 3 +++
    3 files changed, 15 insertions(+), 0 deletions(-)

    diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
    index c6ab4ba..ce3c399 100644
    --- a/drivers/hid/hid-apple.c
    +++ b/drivers/hid/hid-apple.c
    @@ -418,6 +418,12 @@ static const struct hid_device_id apple_devices[] = {
    .driver_data = APPLE_HAS_FN | APPLE_ISO_KEYBOARD },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_JIS),
    .driver_data = APPLE_HAS_FN | APPLE_RDESC_JIS },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_ANSI),
    + .driver_data = APPLE_HAS_FN },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_ISO),
    + .driver_data = APPLE_HAS_FN | APPLE_ISO_KEYBOARD },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_JIS),
    + .driver_data = APPLE_HAS_FN | APPLE_RDESC_JIS },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY),
    .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY),
    diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
    index 1903e75..f5d859e 100644
    --- a/drivers/hid/hid-core.c
    +++ b/drivers/hid/hid-core.c
    @@ -1250,6 +1250,9 @@ static const struct hid_device_id hid_blacklist[] = {
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_ANSI) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_ISO) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_JIS) },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_ANSI) },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_ISO) },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_JIS) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY) },
    { HID_USB_DEVICE(USB_VENDOR_ID_AVERMEDIA, USB_DEVICE_ID_AVER_FM_MR800) },
    @@ -1572,6 +1575,9 @@ static const struct hid_device_id hid_mouse_ignore_list[] = {
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_ANSI) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_ISO) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_JIS) },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_ANSI) },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_ISO) },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_JIS) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY) },
    { }
    diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
    index 5cc4042..0e27587 100644
    --- a/drivers/hid/hid-ids.h
    +++ b/drivers/hid/hid-ids.h
    @@ -82,6 +82,9 @@
    #define USB_DEVICE_ID_APPLE_WELLSPRING2_ANSI 0x0230
    #define USB_DEVICE_ID_APPLE_WELLSPRING2_ISO 0x0231
    #define USB_DEVICE_ID_APPLE_WELLSPRING2_JIS 0x0232
    +#define USB_DEVICE_ID_APPLE_WELLSPRING3_ANSI 0x0236
    +#define USB_DEVICE_ID_APPLE_WELLSPRING3_ISO 0x0237
    +#define USB_DEVICE_ID_APPLE_WELLSPRING3_JIS 0x0238
    #define USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY 0x030a
    #define USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY 0x030b
    #define USB_DEVICE_ID_APPLE_ATV_IRCONTROL 0x8241
    --
    1.5.6.3

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] hid: Complete support for the new unibody macbooks

    On Tue, 4 Nov 2008, Henrik Rydberg wrote:

    > The unibody MacBook 5 and MacBook Pro 5 come with a new version of
    > the bcm5974 trackpad. This patch adds the USB device ids and all
    > the appropriate quirks, including hid_blacklist.
    >
    > Signed-off-by: Henrik Rydberg


    Applied, thanks Henrik (and sorry for the delay, I have been offline for a
    few days).

    --
    Jiri Kosina
    SUSE Labs
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] hid: Complete support for the new unibody macbooks

    Jiri Kosina wrote:
    > On Tue, 4 Nov 2008, Henrik Rydberg wrote:
    >
    >> The unibody MacBook 5 and MacBook Pro 5 come with a new version of
    >> the bcm5974 trackpad. This patch adds the USB device ids and all
    >> the appropriate quirks, including hid_blacklist.
    >>
    >> Signed-off-by: Henrik Rydberg

    >
    > Applied, thanks Henrik (and sorry for the delay, I have been offline for a
    > few days).
    >


    No worries. I should have mentioned earlier that the hid update
    is best synchronized with the bcm5974 update, since the latter
    is the only driver that will pick the mouse interface up after
    the hid update. The bcm5974 patch was sent on October 23, but
    I have not received any feedback to it yet.

    Cheers,
    Henrik

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] hid: Complete support for the new unibody macbooks

    On Tue, 11 Nov 2008, Henrik Rydberg wrote:

    > No worries. I should have mentioned earlier that the hid update is best
    > synchronized with the bcm5974 update, since the latter is the only
    > driver that will pick the mouse interface up after the hid update. The
    > bcm5974 patch was sent on October 23, but I have not received any
    > feedback to it yet.


    Yes, I am aware of bcm5974 being dependent in HID driver not claiming the
    mouse interface on this hardware.

    Dmitry, what are your plans with this bcm5974 patch? 2.6.28 or 2.6.29?

    Thanks,

    --
    Jiri Kosina
    SUSE Labs
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread