[BUGFIX][PATCH] memcg: memory hotplug fix - Kernel

This is a discussion on [BUGFIX][PATCH] memcg: memory hotplug fix - Kernel ; This is a bug fix reported against 2.6.28-rc3 from Badari. Badari, could you give me Ack or Tested-by ? Thanks, -Kame == start pfn calculation of page_cgroup's memory hotplug notifier chain is wrong. Signed-off-by: KAMEZAWA Hiroyuki mm/page_cgroup.c | 4 ++-- ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [BUGFIX][PATCH] memcg: memory hotplug fix

  1. [BUGFIX][PATCH] memcg: memory hotplug fix

    This is a bug fix reported against 2.6.28-rc3 from Badari.
    Badari, could you give me Ack or Tested-by ?

    Thanks,
    -Kame
    ==
    start pfn calculation of page_cgroup's memory hotplug notifier chain
    is wrong.

    Signed-off-by: KAMEZAWA Hiroyuki


    mm/page_cgroup.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    Index: mmotm-2.6.28-Oct30/mm/page_cgroup.c
    ================================================== =================
    --- mmotm-2.6.28-Oct30.orig/mm/page_cgroup.c
    +++ mmotm-2.6.28-Oct30/mm/page_cgroup.c
    @@ -165,7 +165,7 @@ int online_page_cgroup(unsigned long sta
    unsigned long start, end, pfn;
    int fail = 0;

    - start = start_pfn & (PAGES_PER_SECTION - 1);
    + start = start_pfn & ~(PAGES_PER_SECTION - 1);
    end = ALIGN(start_pfn + nr_pages, PAGES_PER_SECTION);

    for (pfn = start; !fail && pfn < end; pfn += PAGES_PER_SECTION) {
    @@ -188,7 +188,7 @@ int offline_page_cgroup(unsigned long st
    {
    unsigned long start, end, pfn;

    - start = start_pfn & (PAGES_PER_SECTION - 1);
    + start = start_pfn & ~(PAGES_PER_SECTION - 1);
    end = ALIGN(start_pfn + nr_pages, PAGES_PER_SECTION);

    for (pfn = start; pfn < end; pfn += PAGES_PER_SECTION)

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [BUGFIX][PATCH] memcg: memory hotplug fix

    On Mon, 2008-11-10 at 18:38 +0900, KAMEZAWA Hiroyuki wrote:
    > This is a bug fix reported against 2.6.28-rc3 from Badari.
    > Badari, could you give me Ack or Tested-by ?
    >
    > Thanks,
    > -Kame
    > ==
    > start pfn calculation of page_cgroup's memory hotplug notifier chain
    > is wrong.
    >
    > Signed-off-by: KAMEZAWA Hiroyuki


    Tested-by: Badari Pulavarty

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread