Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo - Kernel

This is a discussion on Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo - Kernel ; Hi, my Mac mini Core Duo doesn't wake up from suspend to RAM anymore with 2.6.27.4. It works with 2.6.27.3. I enabled pm_trace, but dmesg | grep "hash matches" didn't show anything after resume. I tried 2.6.27.5, which also failed ...

+ Reply to Thread
Results 1 to 9 of 9

Thread: Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

  1. Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

    Hi,

    my Mac mini Core Duo doesn't wake up from suspend to RAM anymore with
    2.6.27.4. It works with 2.6.27.3. I enabled pm_trace, but dmesg | grep
    "hash matches" didn't show anything after resume. I tried 2.6.27.5,
    which also failed to resume.

    The system is i386, the hardware is basically Intel based: Core Duo
    T2300 CPU, Intel graphics i945, ICH7, Marvell GbE (sky2), a SATA hard
    disk, PATA DVD drive, a Firewire hard disk, and a lot of USB devices.

    Does that ring any bells? Any hints what commit I should try to revert?

    Regards,
    Tino
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [stable] Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

    On Sun, Nov 09, 2008 at 09:28:30PM +0100, Tino Keitel wrote:
    > Hi,
    >
    > my Mac mini Core Duo doesn't wake up from suspend to RAM anymore with
    > 2.6.27.4. It works with 2.6.27.3. I enabled pm_trace, but dmesg | grep
    > "hash matches" didn't show anything after resume. I tried 2.6.27.5,
    > which also failed to resume.
    >
    > The system is i386, the hardware is basically Intel based: Core Duo
    > T2300 CPU, Intel graphics i945, ICH7, Marvell GbE (sky2), a SATA hard
    > disk, PATA DVD drive, a Firewire hard disk, and a lot of USB devices.
    >
    > Does that ring any bells? Any hints what commit I should try to revert?


    Can you run 'git bisect' on the patches in 2.6.27.4 to see which one
    broke your box?

    thanks,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [stable] Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

    On Sunday, 9 of November 2008, Greg KH wrote:
    > On Sun, Nov 09, 2008 at 09:28:30PM +0100, Tino Keitel wrote:
    > > Hi,
    > >
    > > my Mac mini Core Duo doesn't wake up from suspend to RAM anymore with
    > > 2.6.27.4. It works with 2.6.27.3. I enabled pm_trace, but dmesg | grep
    > > "hash matches" didn't show anything after resume. I tried 2.6.27.5,
    > > which also failed to resume.
    > >
    > > The system is i386, the hardware is basically Intel based: Core Duo
    > > T2300 CPU, Intel graphics i945, ICH7, Marvell GbE (sky2), a SATA hard
    > > disk, PATA DVD drive, a Firewire hard disk, and a lot of USB devices.
    > >
    > > Does that ring any bells? Any hints what commit I should try to revert?

    >
    > Can you run 'git bisect' on the patches in 2.6.27.4 to see which one
    > broke your box?


    I would start from these commits:

    3b987ac961486373f91191b14291b331fa546072
    "ACPI suspend: Always use the 32-bit waking vector"

    66036f5862883fcc9f7ff8550685a5a3de1a57e4
    "ACPI Suspend: Enable ACPI during resume if SCI_EN is not set"

    If none of them causes this problem to happen, I have no idea what can, so
    please bisect in this case.

    If any of them breaks suspend for you, we'd have to find out why, because
    both of them are rather important bug fixes.

    Thanks,
    Rafael
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [stable] Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

    On Sun, Nov 09, 2008 at 21:51:57 +0100, Rafael J. Wysocki wrote:
    > On Sunday, 9 of November 2008, Greg KH wrote:
    > > On Sun, Nov 09, 2008 at 09:28:30PM +0100, Tino Keitel wrote:
    > > > Hi,
    > > >
    > > > my Mac mini Core Duo doesn't wake up from suspend to RAM anymore with
    > > > 2.6.27.4. It works with 2.6.27.3. I enabled pm_trace, but dmesg | grep
    > > > "hash matches" didn't show anything after resume. I tried 2.6.27.5,
    > > > which also failed to resume.
    > > >
    > > > The system is i386, the hardware is basically Intel based: Core Duo
    > > > T2300 CPU, Intel graphics i945, ICH7, Marvell GbE (sky2), a SATA hard
    > > > disk, PATA DVD drive, a Firewire hard disk, and a lot of USB devices.
    > > >
    > > > Does that ring any bells? Any hints what commit I should try to revert?

    > >
    > > Can you run 'git bisect' on the patches in 2.6.27.4 to see which one
    > > broke your box?

    >
    > I would start from these commits:
    >
    > 3b987ac961486373f91191b14291b331fa546072
    > "ACPI suspend: Always use the 32-bit waking vector"
    >
    > 66036f5862883fcc9f7ff8550685a5a3de1a57e4
    > "ACPI Suspend: Enable ACPI during resume if SCI_EN is not set"


    Thanks Rafael, 2.6.27.5 with 66036f5862883fcc9f7ff8550685a5a3de1a57e4
    reverted resumes fine.

    Regards,
    Tino
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [stable] Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

    On Sun, Nov 09, 2008 at 21:51:57 +0100, Rafael J. Wysocki wrote:
    > On Sunday, 9 of November 2008, Greg KH wrote:
    > > On Sun, Nov 09, 2008 at 09:28:30PM +0100, Tino Keitel wrote:
    > > > Hi,
    > > >
    > > > my Mac mini Core Duo doesn't wake up from suspend to RAM anymore with
    > > > 2.6.27.4. It works with 2.6.27.3. I enabled pm_trace, but dmesg | grep
    > > > "hash matches" didn't show anything after resume. I tried 2.6.27.5,
    > > > which also failed to resume.
    > > >
    > > > The system is i386, the hardware is basically Intel based: Core Duo
    > > > T2300 CPU, Intel graphics i945, ICH7, Marvell GbE (sky2), a SATA hard
    > > > disk, PATA DVD drive, a Firewire hard disk, and a lot of USB devices.
    > > >
    > > > Does that ring any bells? Any hints what commit I should try to revert?

    > >
    > > Can you run 'git bisect' on the patches in 2.6.27.4 to see which one
    > > broke your box?

    >
    > I would start from these commits:
    >
    > 3b987ac961486373f91191b14291b331fa546072
    > "ACPI suspend: Always use the 32-bit waking vector"
    >
    > 66036f5862883fcc9f7ff8550685a5a3de1a57e4
    > "ACPI Suspend: Enable ACPI during resume if SCI_EN is not set"


    Thanks Rafael, 2.6.27.5 with 66036f5862883fcc9f7ff8550685a5a3de1a57e4
    reverted resumes fine.

    Regards,
    Tino
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  6. Re: [stable] Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

    On Tuesday, 11 of November 2008, Tino Keitel wrote:
    > On Sun, Nov 09, 2008 at 21:51:57 +0100, Rafael J. Wysocki wrote:
    > > On Sunday, 9 of November 2008, Greg KH wrote:
    > > > On Sun, Nov 09, 2008 at 09:28:30PM +0100, Tino Keitel wrote:
    > > > > Hi,
    > > > >
    > > > > my Mac mini Core Duo doesn't wake up from suspend to RAM anymore with
    > > > > 2.6.27.4. It works with 2.6.27.3. I enabled pm_trace, but dmesg | grep
    > > > > "hash matches" didn't show anything after resume. I tried 2.6.27.5,
    > > > > which also failed to resume.
    > > > >
    > > > > The system is i386, the hardware is basically Intel based: Core Duo
    > > > > T2300 CPU, Intel graphics i945, ICH7, Marvell GbE (sky2), a SATA hard
    > > > > disk, PATA DVD drive, a Firewire hard disk, and a lot of USB devices.
    > > > >
    > > > > Does that ring any bells? Any hints what commit I should try to revert?
    > > >
    > > > Can you run 'git bisect' on the patches in 2.6.27.4 to see which one
    > > > broke your box?

    > >
    > > I would start from these commits:
    > >
    > > 3b987ac961486373f91191b14291b331fa546072
    > > "ACPI suspend: Always use the 32-bit waking vector"
    > >
    > > 66036f5862883fcc9f7ff8550685a5a3de1a57e4
    > > "ACPI Suspend: Enable ACPI during resume if SCI_EN is not set"

    >
    > Thanks Rafael, 2.6.27.5 with 66036f5862883fcc9f7ff8550685a5a3de1a57e4
    > reverted resumes fine.


    This really is not a good news, because this commit evidently fixes at least
    several systems.

    First, let's try to remove things that we shouldn't be doing.

    Please apply the patch below to 2.6.27.5 without reverting that commit and see
    if that works.

    Thanks,
    Rafael

    ---
    drivers/acpi/pci_link.c | 4 ----
    1 file changed, 4 deletions(-)

    Index: linux-2.6/drivers/acpi/pci_link.c
    ================================================== =================
    --- linux-2.6.orig/drivers/acpi/pci_link.c
    +++ linux-2.6/drivers/acpi/pci_link.c
    @@ -796,10 +796,6 @@ static int irqrouter_resume(struct sys_d
    struct list_head *node = NULL;
    struct acpi_pci_link *link = NULL;

    -
    - /* Make sure SCI is enabled again (Apple firmware bug?) */
    - acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1);
    -
    list_for_each(node, &acpi_link.entries) {
    link = list_entry(node, struct acpi_pci_link, node);
    if (!link) {
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  7. Re: [stable] Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

    On Tue, Nov 11, 2008 at 15:16:08 +0100, Rafael J. Wysocki wrote:

    [...]

    > This really is not a good news, because this commit evidently fixes at least
    > several systems.
    >
    > First, let's try to remove things that we shouldn't be doing.
    >
    > Please apply the patch below to 2.6.27.5 without reverting that commit and see
    > if that works.


    It doesn't work. 2.6.27.5 with the patch applied hangs at resume.

    Regards,
    Tino
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  8. Re: [stable] Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

    On Tuesday, 11 of November 2008, Tino Keitel wrote:
    > On Tue, Nov 11, 2008 at 15:16:08 +0100, Rafael J. Wysocki wrote:
    >
    > [...]
    >
    > > This really is not a good news, because this commit evidently fixes at least
    > > several systems.
    > >
    > > First, let's try to remove things that we shouldn't be doing.
    > >
    > > Please apply the patch below to 2.6.27.5 without reverting that commit and see
    > > if that works.

    >
    > It doesn't work. 2.6.27.5 with the patch applied hangs at resume.


    Well, this appears to be a broken BIOS thing. Perhaps we'll have to blacklist
    the box or something.

    Is there any possibility to get some information about where exactly it hangs?

    Rafael
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  9. Re: [stable] Suspend regression in stable kernel 2.6.27.4 on Mac mini Core Duo

    On Wednesday, 12 of November 2008, Rafael J. Wysocki wrote:
    > On Tuesday, 11 of November 2008, Tino Keitel wrote:
    > > On Tue, Nov 11, 2008 at 15:16:08 +0100, Rafael J. Wysocki wrote:
    > >
    > > [...]
    > >
    > > > This really is not a good news, because this commit evidently fixes at least
    > > > several systems.
    > > >
    > > > First, let's try to remove things that we shouldn't be doing.
    > > >
    > > > Please apply the patch below to 2.6.27.5 without reverting that commit and see
    > > > if that works.

    > >
    > > It doesn't work. 2.6.27.5 with the patch applied hangs at resume.

    >
    > Well, this appears to be a broken BIOS thing. Perhaps we'll have to blacklist
    > the box or something.
    >
    > Is there any possibility to get some information about where exactly it hangs?


    Also, can you check this patch on top of 2.6.27.4 and see what happens?

    Rafael

    ---
    drivers/acpi/pci_link.c | 4 ----
    drivers/acpi/sleep/main.c | 3 ++-
    2 files changed, 2 insertions(+), 5 deletions(-)

    Index: linux-2.6/drivers/acpi/pci_link.c
    ================================================== =================
    --- linux-2.6.orig/drivers/acpi/pci_link.c
    +++ linux-2.6/drivers/acpi/pci_link.c
    @@ -796,10 +796,6 @@ static int irqrouter_resume(struct sys_d
    struct list_head *node = NULL;
    struct acpi_pci_link *link = NULL;

    -
    - /* Make sure SCI is enabled again (Apple firmware bug?) */
    - acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1);
    -
    list_for_each(node, &acpi_link.entries) {
    link = list_entry(node, struct acpi_pci_link, node);
    if (!link) {
    Index: linux-2.6/drivers/acpi/sleep/main.c
    ================================================== =================
    --- linux-2.6.orig/drivers/acpi/sleep/main.c
    +++ linux-2.6/drivers/acpi/sleep/main.c
    @@ -249,7 +249,8 @@ static int acpi_suspend_enter(suspend_st
    }

    /* If ACPI is not enabled by the BIOS, we need to enable it here. */
    - acpi_enable();
    + acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1);
    + /*acpi_enable();*/
    /* Reprogram control registers and execute _BFS */
    acpi_leave_sleep_state_prep(acpi_state);

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread