[GIT PATCH] STAGING fixes for 2.6.28 - Kernel

This is a discussion on [GIT PATCH] STAGING fixes for 2.6.28 - Kernel ; Here are two small Kconfig staging patches against your 2.6 git tree. They fix a Kconfig dependancy on the USB/IP drivers that Randy Dunlap found, and they add a second Kconfig option, which enables the staging drivers to be automatically ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: [GIT PATCH] STAGING fixes for 2.6.28

  1. [GIT PATCH] STAGING fixes for 2.6.28

    Here are two small Kconfig staging patches against your 2.6 git tree.

    They fix a Kconfig dependancy on the USB/IP drivers that Randy Dunlap
    found, and they add a second Kconfig option, which enables the staging
    drivers to be automatically excluded from a 'make allmodconfig' or 'make
    allyesconfig' build. This last patch will help out the -next tree a lot
    in its automatic build tests.

    Please pull from:
    master.kernel.org:/pub/scm/linux/kernel/git/gregkh/staging-2.6.git/

    Patches will be sent as a follow-on to this message to lkml for people
    to see.

    thanks,

    greg k-h


    drivers/staging/Kconfig | 20 ++++++++++++++++++--
    drivers/staging/usbip/Kconfig | 2 +-
    2 files changed, 19 insertions(+), 3 deletions(-)

    ---------------

    Greg Kroah-Hartman (2):
    Staging: only build the tree if we really want to
    Staging: make usbip depend on CONFIG_NET

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 1/2] Staging: only build the tree if we really want to

    Greg KH wrote:
    > --- a/drivers/staging/Kconfig
    > +++ b/drivers/staging/Kconfig
    > @@ -21,7 +21,23 @@ menuconfig STAGING
    >
    > If in doubt, say N here.
    >
    > -if STAGING
    > +
    > +config STAGING_EXCLUDE_BUILD
    > + bool "Exclude Staging drivers from being built"
    > + default y
    > + ---help---

    ....
    > +if !STAGING_EXCLUDE_BUILD
    >
    > source "drivers/staging/et131x/Kconfig"
    >
    > @@ -45,4 +61,4 @@ source "drivers/staging/at76_usb/Kconfig"
    >
    > source "drivers/staging/poch/Kconfig"
    >
    > -endif # STAGING
    > +endif # !STAGING_EXCLUDE_BUILD


    Which purpose is the STAGING kconfig variable serving after this? It
    controls the visibility of the menu, but switching it off won't switch
    off the staging drivers if they were previously enabled, would it?
    --
    Stefan Richter
    -=====-==--- =-== -=---
    http://arcgraph.de/sr/
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH 1/2] Staging: only build the tree if we really want to

    On Sat, Nov 08, 2008 at 04:59:37PM +0100, Stefan Richter wrote:
    > Greg KH wrote:
    > > --- a/drivers/staging/Kconfig
    > > +++ b/drivers/staging/Kconfig
    > > @@ -21,7 +21,23 @@ menuconfig STAGING
    > >
    > > If in doubt, say N here.
    > >
    > > -if STAGING
    > > +
    > > +config STAGING_EXCLUDE_BUILD
    > > + bool "Exclude Staging drivers from being built"
    > > + default y
    > > + ---help---

    > ...
    > > +if !STAGING_EXCLUDE_BUILD
    > >
    > > source "drivers/staging/et131x/Kconfig"
    > >
    > > @@ -45,4 +61,4 @@ source "drivers/staging/at76_usb/Kconfig"
    > >
    > > source "drivers/staging/poch/Kconfig"
    > >
    > > -endif # STAGING
    > > +endif # !STAGING_EXCLUDE_BUILD

    >
    > Which purpose is the STAGING kconfig variable serving after this?


    Sitting there and looking pretty

    > It controls the visibility of the menu, but switching it off won't
    > switch off the staging drivers if they were previously enabled, would
    > it?


    Try it and look in wonder

    If something affects the visibility of the menu for those config
    options, it controls if those options can be enabled or not.

    thanks,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH 1/2] Staging: only build the tree if we really want to

    Greg KH wrote:
    > On Sat, Nov 08, 2008 at 04:59:37PM +0100, Stefan Richter wrote:
    >>> -endif # STAGING
    >>> +endif # !STAGING_EXCLUDE_BUILD

    >> Which purpose is the STAGING kconfig variable serving after this?

    >
    > Sitting there and looking pretty
    >
    >> It controls the visibility of the menu, but switching it off won't
    >> switch off the staging drivers if they were previously enabled, would
    >> it?

    >
    > Try it and look in wonder
    >
    > If something affects the visibility of the menu for those config
    > options, it controls if those options can be enabled or not.


    Right. But if you had STAGING on, STAGING_EXCLUDE_BUILD off, and for
    example ET131X on, then ET131X will still be on if you switch STAGING
    off and save the configuration.
    --
    Stefan Richter
    -=====-==--- =-== -=---
    http://arcgraph.de/sr/
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [PATCH 1/2] Staging: only build the tree if we really want to

    On Sat, Nov 08, 2008 at 08:31:41PM +0100, Stefan Richter wrote:
    > Greg KH wrote:
    > > On Sat, Nov 08, 2008 at 04:59:37PM +0100, Stefan Richter wrote:
    > >>> -endif # STAGING
    > >>> +endif # !STAGING_EXCLUDE_BUILD
    > >> Which purpose is the STAGING kconfig variable serving after this?

    > >
    > > Sitting there and looking pretty
    > >
    > >> It controls the visibility of the menu, but switching it off won't
    > >> switch off the staging drivers if they were previously enabled, would
    > >> it?

    > >
    > > Try it and look in wonder
    > >
    > > If something affects the visibility of the menu for those config
    > > options, it controls if those options can be enabled or not.

    >
    > Right. But if you had STAGING on, STAGING_EXCLUDE_BUILD off, and for
    > example ET131X on, then ET131X will still be on if you switch STAGING
    > off and save the configuration.


    I think Linus fixed this, look at 2.6.28-rc4.

    thanks,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread