[patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks - Kernel

This is a discussion on [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks - Kernel ; From: David Brownell Minor change to the TWL4030 utility interface: support reads of all 256 bytes in each register bank (vs just 255). This can help when debugging, but is otherwise a NOP. Signed-off-by: David Brownell --- drivers/mfd/twl4030-core.c | 4 ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks

  1. [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks

    From: David Brownell

    Minor change to the TWL4030 utility interface: support reads
    of all 256 bytes in each register bank (vs just 255). This
    can help when debugging, but is otherwise a NOP.

    Signed-off-by: David Brownell
    ---
    drivers/mfd/twl4030-core.c | 4 ++--
    include/linux/i2c/twl4030.h | 4 ++--
    2 files changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/mfd/twl4030-core.c
    +++ b/drivers/mfd/twl4030-core.c
    @@ -233,7 +233,7 @@ extern void twl4030_power_init(struct tw
    *
    * Returns the result of operation - 0 is success
    */
    -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
    +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
    {
    int ret;
    int sid;
    @@ -282,7 +282,7 @@ EXPORT_SYMBOL(twl4030_i2c_write);
    *
    * Returns result of operation - num_bytes is success else failure.
    */
    -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
    +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
    {
    int ret;
    u8 val;
    --- a/include/linux/i2c/twl4030.h
    +++ b/include/linux/i2c/twl4030.h
    @@ -78,8 +78,8 @@ int twl4030_i2c_read_u8(u8 mod_no, u8 *v
    * IMPORTANT: For twl4030_i2c_write(), allocate num_bytes + 1
    * for the value, and populate your data starting at offset 1.
    */
    -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
    -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
    +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
    +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);

    /*----------------------------------------------------------------------*/

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [patch 2.6.28-rc3-git] twl4030-core: allow reading entire register banks

    On Fri, Nov 07, 2008 at 02:00:03PM -0800, David Brownell wrote:
    > From: David Brownell
    >
    > Minor change to the TWL4030 utility interface: support reads
    > of all 256 bytes in each register bank (vs just 255). This
    > can help when debugging, but is otherwise a NOP.

    Applied to my for-next branch.
    Thanks David.

    Cheers,
    Samuel.


    > Signed-off-by: David Brownell
    > ---
    > drivers/mfd/twl4030-core.c | 4 ++--
    > include/linux/i2c/twl4030.h | 4 ++--
    > 2 files changed, 4 insertions(+), 4 deletions(-)
    >
    > --- a/drivers/mfd/twl4030-core.c
    > +++ b/drivers/mfd/twl4030-core.c
    > @@ -233,7 +233,7 @@ extern void twl4030_power_init(struct tw
    > *
    > * Returns the result of operation - 0 is success
    > */
    > -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
    > +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
    > {
    > int ret;
    > int sid;
    > @@ -282,7 +282,7 @@ EXPORT_SYMBOL(twl4030_i2c_write);
    > *
    > * Returns result of operation - num_bytes is success else failure.
    > */
    > -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes)
    > +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
    > {
    > int ret;
    > u8 val;
    > --- a/include/linux/i2c/twl4030.h
    > +++ b/include/linux/i2c/twl4030.h
    > @@ -78,8 +78,8 @@ int twl4030_i2c_read_u8(u8 mod_no, u8 *v
    > * IMPORTANT: For twl4030_i2c_write(), allocate num_bytes + 1
    > * for the value, and populate your data starting at offset 1.
    > */
    > -int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
    > -int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, u8 num_bytes);
    > +int twl4030_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
    > +int twl4030_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
    >
    > /*----------------------------------------------------------------------*/
    >


    --
    Intel Open Source Technology Centre
    http://oss.intel.com/
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread