[PATCH 2.6.25,26.stable] ACPI: dock: avoid check _STA method - Kernel

This is a discussion on [PATCH 2.6.25,26.stable] ACPI: dock: avoid check _STA method - Kernel ; commit 8b59560a3baf2e7c24e0fb92ea5d09eca92805db Author: Shaohua Li Date: Thu Aug 28 10:02:03 2008 +0800 ACPI: dock: avoid check _STA method In some BIOSes, every _STA method call will send a notification again, this cause freeze. And in some BIOSes, it appears _STA ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH 2.6.25,26.stable] ACPI: dock: avoid check _STA method

  1. [PATCH 2.6.25,26.stable] ACPI: dock: avoid check _STA method

    commit 8b59560a3baf2e7c24e0fb92ea5d09eca92805db
    Author: Shaohua Li
    Date: Thu Aug 28 10:02:03 2008 +0800

    ACPI: dock: avoid check _STA method

    In some BIOSes, every _STA method call will send a notification again,
    this cause freeze. And in some BIOSes, it appears _STA should be called
    after _DCK. This tries to avoid calls _STA, and still keep the device
    present check.

    http://bugzilla.kernel.org/show_bug.cgi?id=10431

    Signed-off-by: Shaohua Li
    Signed-off-by: Len Brown

    Index: linux-2.6.25.y/drivers/acpi/dock.c
    ================================================== =================
    --- linux-2.6.25.y.orig/drivers/acpi/dock.c
    +++ linux-2.6.25.y/drivers/acpi/dock.c
    @@ -599,14 +599,17 @@ static int handle_eject_request(struct d
    static void dock_notify(acpi_handle handle, u32 event, void *data)
    {
    struct dock_station *ds = data;
    + struct acpi_device *tmp;

    switch (event) {
    case ACPI_NOTIFY_BUS_CHECK:
    - if (!dock_in_progress(ds) && dock_present(ds)) {
    + if (!dock_in_progress(ds) && acpi_bus_get_device(ds->handle,
    + &tmp)) {
    begin_dock(ds);
    dock(ds);
    if (!dock_present(ds)) {
    printk(KERN_ERR PREFIX "Unable to dock!\n");
    + complete_dock(ds);
    break;
    }
    atomic_notifier_call_chain(&dock_notifier_list,
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. patch acpi-dock-avoid-check-_sta-method.patch added to 2.6.26-stable tree


    This is a note to let you know that we have just queued up the patch titled

    Subject: ACPI: dock: avoid check _STA method

    to the 2.6.26-stable tree. Its filename is

    acpi-dock-avoid-check-_sta-method.patch

    A git repo of this tree can be found at
    http://www.kernel.org/git/?p=linux/k....git;a=summary


    From lenb@kernel.org Fri Nov 7 14:08:55 2008
    From: Shaohua Li
    Date: Thu, 06 Nov 2008 14:18:55 -0500 (EST)
    Subject: ACPI: dock: avoid check _STA method
    To: stable@kernel.org
    Cc: linux-acpi@vger.kernel.org, Linux Kernel Mailing List , Shaohua Li
    Message-ID:

    From: Shaohua Li

    commit 8b59560a3baf2e7c24e0fb92ea5d09eca92805db upstream.

    ACPI: dock: avoid check _STA method

    In some BIOSes, every _STA method call will send a notification again,
    this cause freeze. And in some BIOSes, it appears _STA should be called
    after _DCK. This tries to avoid calls _STA, and still keep the device
    present check.

    http://bugzilla.kernel.org/show_bug.cgi?id=10431

    Signed-off-by: Shaohua Li
    Signed-off-by: Len Brown
    Signed-off-by: Greg Kroah-Hartman

    ---
    drivers/acpi/dock.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/acpi/dock.c
    +++ b/drivers/acpi/dock.c
    @@ -599,14 +599,17 @@ static int handle_eject_request(struct d
    static void dock_notify(acpi_handle handle, u32 event, void *data)
    {
    struct dock_station *ds = data;
    + struct acpi_device *tmp;

    switch (event) {
    case ACPI_NOTIFY_BUS_CHECK:
    - if (!dock_in_progress(ds) && dock_present(ds)) {
    + if (!dock_in_progress(ds) && acpi_bus_get_device(ds->handle,
    + &tmp)) {
    begin_dock(ds);
    dock(ds);
    if (!dock_present(ds)) {
    printk(KERN_ERR PREFIX "Unable to dock!\n");
    + complete_dock(ds);
    break;
    }
    atomic_notifier_call_chain(&dock_notifier_list,


    Patches currently in stable-queue which might be from shaohua.li@intel.com are

    queue-2.6.26/acpi-dock-avoid-check-_sta-method.patch
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. patch acpi-dock-avoid-check-_sta-method.patch added to 2.6.25-stable tree


    This is a note to let you know that we have just queued up the patch titled

    Subject: ACPI: dock: avoid check _STA method

    to the 2.6.25-stable tree. Its filename is

    acpi-dock-avoid-check-_sta-method.patch

    A git repo of this tree can be found at
    http://www.kernel.org/git/?p=linux/k....git;a=summary


    From lenb@kernel.org Fri Nov 7 14:08:55 2008
    From: Shaohua Li
    Date: Thu, 06 Nov 2008 14:18:55 -0500 (EST)
    Subject: ACPI: dock: avoid check _STA method
    To: stable@kernel.org
    Cc: linux-acpi@vger.kernel.org, Linux Kernel Mailing List , Shaohua Li
    Message-ID:

    From: Shaohua Li

    commit 8b59560a3baf2e7c24e0fb92ea5d09eca92805db upstream.

    ACPI: dock: avoid check _STA method

    In some BIOSes, every _STA method call will send a notification again,
    this cause freeze. And in some BIOSes, it appears _STA should be called
    after _DCK. This tries to avoid calls _STA, and still keep the device
    present check.

    http://bugzilla.kernel.org/show_bug.cgi?id=10431

    Signed-off-by: Shaohua Li
    Signed-off-by: Len Brown
    Signed-off-by: Greg Kroah-Hartman

    ---
    drivers/acpi/dock.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/acpi/dock.c
    +++ b/drivers/acpi/dock.c
    @@ -599,14 +599,17 @@ static int handle_eject_request(struct d
    static void dock_notify(acpi_handle handle, u32 event, void *data)
    {
    struct dock_station *ds = data;
    + struct acpi_device *tmp;

    switch (event) {
    case ACPI_NOTIFY_BUS_CHECK:
    - if (!dock_in_progress(ds) && dock_present(ds)) {
    + if (!dock_in_progress(ds) && acpi_bus_get_device(ds->handle,
    + &tmp)) {
    begin_dock(ds);
    dock(ds);
    if (!dock_present(ds)) {
    printk(KERN_ERR PREFIX "Unable to dock!\n");
    + complete_dock(ds);
    break;
    }
    atomic_notifier_call_chain(&dock_notifier_list,


    Patches currently in stable-queue which might be from shaohua.li@intel.com are

    queue-2.6.25/acpi-dock-avoid-check-_sta-method.patch
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread