[PATCH] mfd: da903x: fix event masking for da9030 - Kernel

This is a discussion on [PATCH] mfd: da903x: fix event masking for da9030 - Kernel ; Signed-off-by: Mike Rapoport --- drivers/mfd/da903x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c index b57326a..0b5bd85 100644 --- a/drivers/mfd/da903x.c +++ b/drivers/mfd/da903x.c @@ -267,7 +267,7 @@ static int da9030_mask_events(struct da903x_chip *chip, unsigned int events) { uint8_t ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH] mfd: da903x: fix event masking for da9030

  1. [PATCH] mfd: da903x: fix event masking for da9030


    Signed-off-by: Mike Rapoport
    ---
    drivers/mfd/da903x.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
    index b57326a..0b5bd85 100644
    --- a/drivers/mfd/da903x.c
    +++ b/drivers/mfd/da903x.c
    @@ -267,7 +267,7 @@ static int da9030_mask_events(struct da903x_chip *chip, unsigned int events)
    {
    uint8_t v[3];

    - chip->events_mask &= ~events;
    + chip->events_mask |= events;

    v[0] = (chip->events_mask & 0xff);
    v[1] = (chip->events_mask >> 8) & 0xff;
    --
    1.5.6.4

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] mfd: da903x: fix event masking for da9030

    On Thu, Nov 6, 2008 at 7:23 PM, Mike Rapoport wrote:
    >
    > Signed-off-by: Mike Rapoport


    Acked-by: Eric Miao

    > ---
    > drivers/mfd/da903x.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
    > index b57326a..0b5bd85 100644
    > --- a/drivers/mfd/da903x.c
    > +++ b/drivers/mfd/da903x.c
    > @@ -267,7 +267,7 @@ static int da9030_mask_events(struct da903x_chip *chip, unsigned int events)
    > {
    > uint8_t v[3];
    >
    > - chip->events_mask &= ~events;
    > + chip->events_mask |= events;
    >
    > v[0] = (chip->events_mask & 0xff);
    > v[1] = (chip->events_mask >> 8) & 0xff;
    > --
    > 1.5.6.4
    >
    >




    --
    Cheers
    - eric
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] mfd: da903x: fix event masking for da9030

    On Thu, Nov 06, 2008 at 01:23:51PM +0200, Mike Rapoport wrote:
    >
    > Signed-off-by: Mike Rapoport

    Thanks Mike, applied to my for-linus branch.

    Cheers,
    Samuel.

    > ---
    > drivers/mfd/da903x.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
    > index b57326a..0b5bd85 100644
    > --- a/drivers/mfd/da903x.c
    > +++ b/drivers/mfd/da903x.c
    > @@ -267,7 +267,7 @@ static int da9030_mask_events(struct da903x_chip *chip, unsigned int events)
    > {
    > uint8_t v[3];
    >
    > - chip->events_mask &= ~events;
    > + chip->events_mask |= events;
    >
    > v[0] = (chip->events_mask & 0xff);
    > v[1] = (chip->events_mask >> 8) & 0xff;
    > --
    > 1.5.6.4
    >


    --
    Intel Open Source Technology Centre
    http://oss.intel.com/
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread