[PATCH] hid: Add support for the new unibody macbooks - Kernel

This is a discussion on [PATCH] hid: Add support for the new unibody macbooks - Kernel ; The unibody MacBook 5 and MacBook Pro 5 come with a new version of the bcm5974 trackpad. This patch adds the USB device ids and the appropriate quirks. Signed-off-by: Henrik Rydberg --- drivers/hid/hid-apple.c | 6 ++++++ drivers/hid/hid-core.c | 3 +++ ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH] hid: Add support for the new unibody macbooks

  1. [PATCH] hid: Add support for the new unibody macbooks

    The unibody MacBook 5 and MacBook Pro 5 come with a new version of
    the bcm5974 trackpad. This patch adds the USB device ids and the
    appropriate quirks.

    Signed-off-by: Henrik Rydberg
    ---
    drivers/hid/hid-apple.c | 6 ++++++
    drivers/hid/hid-core.c | 3 +++
    drivers/hid/hid-ids.h | 3 +++
    3 files changed, 12 insertions(+), 0 deletions(-)

    diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
    index c6ab4ba..ce3c399 100644
    --- a/drivers/hid/hid-apple.c
    +++ b/drivers/hid/hid-apple.c
    @@ -418,6 +418,12 @@ static const struct hid_device_id apple_devices[] = {
    .driver_data = APPLE_HAS_FN | APPLE_ISO_KEYBOARD },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_JIS),
    .driver_data = APPLE_HAS_FN | APPLE_RDESC_JIS },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_ANSI),
    + .driver_data = APPLE_HAS_FN },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_ISO),
    + .driver_data = APPLE_HAS_FN | APPLE_ISO_KEYBOARD },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_JIS),
    + .driver_data = APPLE_HAS_FN | APPLE_RDESC_JIS },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY),
    .driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY),
    diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
    index 1903e75..aa51488 100644
    --- a/drivers/hid/hid-core.c
    +++ b/drivers/hid/hid-core.c
    @@ -1572,6 +1572,9 @@ static const struct hid_device_id hid_mouse_ignore_list[] = {
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_ANSI) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_ISO) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING2_JIS) },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_ANSI) },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_ISO) },
    + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_WELLSPRING3_JIS) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY) },
    { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY) },
    { }
    diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
    index 5cc4042..0e27587 100644
    --- a/drivers/hid/hid-ids.h
    +++ b/drivers/hid/hid-ids.h
    @@ -82,6 +82,9 @@
    #define USB_DEVICE_ID_APPLE_WELLSPRING2_ANSI 0x0230
    #define USB_DEVICE_ID_APPLE_WELLSPRING2_ISO 0x0231
    #define USB_DEVICE_ID_APPLE_WELLSPRING2_JIS 0x0232
    +#define USB_DEVICE_ID_APPLE_WELLSPRING3_ANSI 0x0236
    +#define USB_DEVICE_ID_APPLE_WELLSPRING3_ISO 0x0237
    +#define USB_DEVICE_ID_APPLE_WELLSPRING3_JIS 0x0238
    #define USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY 0x030a
    #define USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY 0x030b
    #define USB_DEVICE_ID_APPLE_ATV_IRCONTROL 0x8241
    --
    1.5.6.3

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] hid: Add support for the new unibody macbooks

    Henrik Rydberg napsal(a):
    > The unibody MacBook 5 and MacBook Pro 5 come with a new version of
    > the bcm5974 trackpad. This patch adds the USB device ids and the
    > appropriate quirks.


    Hi, thanks for the patch, but you omitted hid_blacklist addition.

    Jiri K. (HID maintainer) is out for a while, expect longer rtt .
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] hid: Add support for the new unibody macbooks

    Jiri Slaby wrote:
    > Henrik Rydberg napsal(a):
    >> The unibody MacBook 5 and MacBook Pro 5 come with a new version of
    >> the bcm5974 trackpad. This patch adds the USB device ids and the
    >> appropriate quirks.

    >
    > Hi, thanks for the patch, but you omitted hid_blacklist addition.
    >
    > Jiri K. (HID maintainer) is out for a while, expect longer rtt .


    Yes, I sent it separately, sorry about the confusion. I will resend
    the whole patch shortly, with the blacklist included. Thanks!

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread