[PATCH] sata_via: restore vt*_prepare_host error handling - Kernel

This is a discussion on [PATCH] sata_via: restore vt*_prepare_host error handling - Kernel ; commit b9d5b89b487517cbd4cb4702da829e07ef9e4432 (sata_via: fix support for 5287) accidently (?) removed vt*_prepare_host error handling - restore it catched by gcc: drivers/ata/sata_via.c: In function 'svia_init_one': drivers/ata/sata_via.c:567: warning: 'host' may be used uninitialized in this function Signed-off-by: Marcin Slusarz Cc: Tejun Heo Cc: ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH] sata_via: restore vt*_prepare_host error handling

  1. [PATCH] sata_via: restore vt*_prepare_host error handling

    commit b9d5b89b487517cbd4cb4702da829e07ef9e4432 (sata_via: fix support
    for 5287) accidently (?) removed vt*_prepare_host error handling - restore it

    catched by gcc:
    drivers/ata/sata_via.c: In function 'svia_init_one':
    drivers/ata/sata_via.c:567: warning: 'host' may be used uninitialized in this function

    Signed-off-by: Marcin Slusarz
    Cc: Tejun Heo
    Cc: Joseph Chan
    Cc: Jeff Garzik
    ---
    drivers/ata/sata_via.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
    index 62367fe..c18935f 100644
    --- a/drivers/ata/sata_via.c
    +++ b/drivers/ata/sata_via.c
    @@ -602,8 +602,10 @@ static int svia_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
    rc = vt8251_prepare_host(pdev, &host);
    break;
    default:
    - return -EINVAL;
    + rc = -EINVAL;
    }
    + if (rc)
    + return rc;

    svia_configure(pdev);

    --
    1.5.6.4

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] sata_via: restore vt*_prepare_host error handling

    Marcin Slusarz wrote:
    > commit b9d5b89b487517cbd4cb4702da829e07ef9e4432 (sata_via: fix support
    > for 5287) accidently (?) removed vt*_prepare_host error handling - restore it
    >
    > catched by gcc:
    > drivers/ata/sata_via.c: In function 'svia_init_one':
    > drivers/ata/sata_via.c:567: warning: 'host' may be used uninitialized in this function
    >
    > Signed-off-by: Marcin Slusarz
    > Cc: Tejun Heo
    > Cc: Joseph Chan
    > Cc: Jeff Garzik


    Acked-by: Tejun Heo

    Thank you.

    --
    tejun
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] sata_via: restore vt*_prepare_host error handling

    Marcin Slusarz wrote:
    > commit b9d5b89b487517cbd4cb4702da829e07ef9e4432 (sata_via: fix support
    > for 5287) accidently (?) removed vt*_prepare_host error handling - restore it
    >
    > catched by gcc:
    > drivers/ata/sata_via.c: In function 'svia_init_one':
    > drivers/ata/sata_via.c:567: warning: 'host' may be used uninitialized in this function
    >
    > Signed-off-by: Marcin Slusarz
    > Cc: Tejun Heo
    > Cc: Joseph Chan
    > Cc: Jeff Garzik
    > ---
    > drivers/ata/sata_via.c | 4 +++-
    > 1 files changed, 3 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
    > index 62367fe..c18935f 100644
    > --- a/drivers/ata/sata_via.c
    > +++ b/drivers/ata/sata_via.c
    > @@ -602,8 +602,10 @@ static int svia_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
    > rc = vt8251_prepare_host(pdev, &host);
    > break;
    > default:
    > - return -EINVAL;
    > + rc = -EINVAL;
    > }
    > + if (rc)
    > + return rc;


    applied


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread