[PATCH-linux-next] ia64: fix build breakage in smp.h - Kernel

This is a discussion on [PATCH-linux-next] ia64: fix build breakage in smp.h - Kernel ; The commit: "cpumask: switch over to cpu_online/possible/active/present_mask" provides a define for cpu_online_map but did not delete the declaration in arch/ia64/include/asm/smp.h resulting in this build error: CC arch/ia64/kernel/asm-offsets.s In file included from include/linux/smp.h:30, from include/linux/sched.h:68, from arch/ia64/kernel/asm-offsets.c:9: arch/ia64/include/asm/smp.h:60: error: expected ')' ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH-linux-next] ia64: fix build breakage in smp.h

  1. [PATCH-linux-next] ia64: fix build breakage in smp.h

    The commit:
    "cpumask: switch over to cpu_online/possible/active/present_mask"
    provides a define for cpu_online_map but did not delete the
    declaration in arch/ia64/include/asm/smp.h resulting in this
    build error:

    CC arch/ia64/kernel/asm-offsets.s
    In file included from include/linux/smp.h:30,
    from include/linux/sched.h:68,
    from arch/ia64/kernel/asm-offsets.c:9:
    arch/ia64/include/asm/smp.h:60: error: expected ')' before '*' token
    arch/ia64/include/asm/smp.h:60: error: expected ')' before 'cpu_online_mask'

    Fix: just delete the declaration, it is no longer needed.

    Signed-off-by: Tony Luck

    ---

    Ingo: I think this belongs in the auto-cpus4096-next branch of the tip tree

    diff --git a/arch/ia64/include/asm/smp.h b/arch/ia64/include/asm/smp.h
    index 12d96e0..21c4023 100644
    --- a/arch/ia64/include/asm/smp.h
    +++ b/arch/ia64/include/asm/smp.h
    @@ -57,7 +57,6 @@ extern struct smp_boot_data {

    extern char no_int_routing __devinitdata;

    -extern cpumask_t cpu_online_map;
    extern cpumask_t cpu_core_map[NR_CPUS];
    DECLARE_PER_CPU(cpumask_t, cpu_sibling_map);
    extern int smp_num_siblings;

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH-linux-next] ia64: fix build breakage in smp.h


    * Luck, Tony wrote:

    > The commit:
    > "cpumask: switch over to cpu_online/possible/active/present_mask"
    > provides a define for cpu_online_map but did not delete the
    > declaration in arch/ia64/include/asm/smp.h resulting in this
    > build error:
    >
    > CC arch/ia64/kernel/asm-offsets.s
    > In file included from include/linux/smp.h:30,
    > from include/linux/sched.h:68,
    > from arch/ia64/kernel/asm-offsets.c:9:
    > arch/ia64/include/asm/smp.h:60: error: expected ')' before '*' token
    > arch/ia64/include/asm/smp.h:60: error: expected ')' before 'cpu_online_mask'
    >
    > Fix: just delete the declaration, it is no longer needed.
    >
    > Signed-off-by: Tony Luck


    applied to tip/cpus4096, thanks Tony!

    > Ingo: I think this belongs in the auto-cpus4096-next branch of the
    > tip tree


    yes, thanks. I've pushed out a new version of auto-cpus4096-next.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread