[PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module - Kernel

This is a discussion on [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module - Kernel ; From: Johann Felix Soden The 'ret' variable is assigned, but not used in the return statement. Fix this. Signed-off-by: Johann Felix Soden CC: Jason Baron --- lib/dynamic_printk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/dynamic_printk.c ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module

  1. [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module

    From: Johann Felix Soden

    The 'ret' variable is assigned, but not used in the return statement. Fix this.

    Signed-off-by: Johann Felix Soden
    CC: Jason Baron
    ---
    lib/dynamic_printk.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
    index d83660f..d0fd0e4 100644
    --- a/lib/dynamic_printk.c
    +++ b/lib/dynamic_printk.c
    @@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
    nr_entries--;
    out:
    up(&debug_list_mutex);
    - return 0;
    + return ret;
    }
    EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module) ;

    --
    1.5.6.5



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module

    On Thu, Oct 30, 2008 at 10:44:39PM +0100, Johann Felix Soden wrote:
    > From: Johann Felix Soden
    >
    > The 'ret' variable is assigned, but not used in the return statement. Fix this.
    >
    > Signed-off-by: Johann Felix Soden
    > CC: Jason Baron
    > ---
    > lib/dynamic_printk.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
    > index d83660f..d0fd0e4 100644
    > --- a/lib/dynamic_printk.c
    > +++ b/lib/dynamic_printk.c
    > @@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
    > nr_entries--;
    > out:
    > up(&debug_list_mutex);
    > - return 0;
    > + return ret;
    > }
    > EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module) ;
    >


    looks good to me.

    Acked-by: Jason Baron

    thanks,

    -Jason
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread