[RFC -tip] x86: nmi - add sensible names to nmi_watchdog boot param - Kernel

This is a discussion on [RFC -tip] x86: nmi - add sensible names to nmi_watchdog boot param - Kernel ; Add sensible names as "lapic" and "ioapic" to nmi_watchdog boot parameter. Sometimes it is not that easy to recall what exactly nmi_watchdog=1 does mean so we allow the using of symbolic names here. Old numeric values remain valid. Signed-off-by: Cyrill ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: [RFC -tip] x86: nmi - add sensible names to nmi_watchdog boot param

  1. [RFC -tip] x86: nmi - add sensible names to nmi_watchdog boot param

    Add sensible names as "lapic" and "ioapic" to
    nmi_watchdog boot parameter. Sometimes it is not
    that easy to recall what exactly nmi_watchdog=1
    does mean so we allow the using of symbolic names here.

    Old numeric values remain valid.

    Signed-off-by: Cyrill Gorcunov
    ---

    arch/x86/kernel/nmi.c | 15 ++++++++++-----
    1 file changed, 10 insertions(+), 5 deletions(-)

    Index: linux-2.6.git/arch/x86/kernel/nmi.c
    ================================================== =================
    --- linux-2.6.git.orig/arch/x86/kernel/nmi.c 2008-10-27 21:35:21.000000000 +0300
    +++ linux-2.6.git/arch/x86/kernel/nmi.c 2008-10-30 19:01:52.000000000 +0300
    @@ -208,12 +208,17 @@ static int __init setup_nmi_watchdog(cha
    ++str;
    }

    - get_option(&str, &nmi);
    -
    - if (nmi >= NMI_INVALID)
    - return 0;
    + if (!strncmp(str, "lapic", 5))
    + nmi_watchdog = NMI_LOCAL_APIC;
    + else if (!strncmp(str, "ioapic", 6))
    + nmi_watchdog = NMI_IO_APIC;
    + else {
    + get_option(&str, &nmi);
    + if (nmi >= NMI_INVALID)
    + return 0;
    + nmi_watchdog = nmi;
    + }

    - nmi_watchdog = nmi;
    return 1;
    }
    __setup("nmi_watchdog=", setup_nmi_watchdog);
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [RFC -tip] x86: nmi - add sensible names to nmi_watchdog boot param

    > Add sensible names as "lapic" and "ioapic" to
    > nmi_watchdog boot parameter. Sometimes it is not
    > that easy to recall what exactly nmi_watchdog=1
    > does mean so we allow the using of symbolic names here.
    >
    > Old numeric values remain valid.

    looks good to me, but you need to update the documentation as well.

    --
    Aristeu

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [RFC -tip] x86: nmi - add sensible names to nmi_watchdog boot param

    [Aristeu Rozanski - Thu, Oct 30, 2008 at 01:10:53PM -0400]
    | > Add sensible names as "lapic" and "ioapic" to
    | > nmi_watchdog boot parameter. Sometimes it is not
    | > that easy to recall what exactly nmi_watchdog=1
    | > does mean so we allow the using of symbolic names here.
    | >
    | > Old numeric values remain valid.
    | looks good to me, but you need to update the documentation as well.
    |
    | --
    | Aristeu
    |

    Aristeu, maybe you could do it for me -- English is quite weak
    side of me

    - Cyrill -
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [RFC -tip] x86: nmi - add sensible names to nmi_watchdog boot param

    [Cyrill Gorcunov - Thu, Oct 30, 2008 at 08:14:26PM +0300]
    | [Aristeu Rozanski - Thu, Oct 30, 2008 at 01:10:53PM -0400]
    | | > Add sensible names as "lapic" and "ioapic" to
    | | > nmi_watchdog boot parameter. Sometimes it is not
    | | > that easy to recall what exactly nmi_watchdog=1
    | | > does mean so we allow the using of symbolic names here.
    | | >
    | | > Old numeric values remain valid.
    | | looks good to me, but you need to update the documentation as well.
    | |
    | | --
    | | Aristeu
    | |
    |
    | Aristeu, maybe you could do it for me -- English is quite weak
    | side of me
    |
    | - Cyrill -

    I think I'd better wait 'till your patch (for nmi_watchdog.txt)
    applied. It allows me to just write a few words so it would be pushed
    on top of _all_ nmi related changes these days (without interdiff).

    - Cyrill -
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [RFC -tip] x86: nmi - add sensible names to nmi_watchdog boot param


    * Cyrill Gorcunov wrote:

    > Add sensible names as "lapic" and "ioapic" to
    > nmi_watchdog boot parameter. Sometimes it is not
    > that easy to recall what exactly nmi_watchdog=1
    > does mean so we allow the using of symbolic names here.
    >
    > Old numeric values remain valid.
    >
    > Signed-off-by: Cyrill Gorcunov
    > ---
    >
    > arch/x86/kernel/nmi.c | 15 ++++++++++-----
    > 1 file changed, 10 insertions(+), 5 deletions(-)


    ok, that makes quite a bit of sense. Peter, any objections?

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread