[PATCH] pcmcia: fix indentation & braces disagreement - add braces - Kernel

This is a discussion on [PATCH] pcmcia: fix indentation & braces disagreement - add braces - Kernel ; Broken by d8b0a49da4f2 (pcmcia: deprecate CS_BAD_VCC and CS_BAD_VPP). Signed-off-by: Ilpo Järvinen Cc: Dominik Brodowski --- drivers/pcmcia/pcmcia_resource.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c index afea2b2..e3b3139 100644 --- a/drivers/pcmcia/pcmcia_resource.c +++ b/drivers/pcmcia/pcmcia_resource.c @@ -302,9 +302,10 ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] pcmcia: fix indentation & braces disagreement - add braces

  1. [PATCH] pcmcia: fix indentation & braces disagreement - add braces

    Broken by d8b0a49da4f2 (pcmcia: deprecate CS_BAD_VCC and
    CS_BAD_VPP).

    Signed-off-by: Ilpo Järvinen
    Cc: Dominik Brodowski
    ---
    drivers/pcmcia/pcmcia_resource.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c
    index afea2b2..e3b3139 100644
    --- a/drivers/pcmcia/pcmcia_resource.c
    +++ b/drivers/pcmcia/pcmcia_resource.c
    @@ -302,9 +302,10 @@ int pcmcia_modify_configuration(struct pcmcia_device *p_dev,
    /* We only allow changing Vpp1 and Vpp2 to the same value */
    if ((mod->Attributes & CONF_VPP1_CHANGE_VALID) &&
    (mod->Attributes & CONF_VPP2_CHANGE_VALID)) {
    - if (mod->Vpp1 != mod->Vpp2)
    + if (mod->Vpp1 != mod->Vpp2) {
    ds_dbg(s, 0, "Vpp1 and Vpp2 must be the same\n");
    return -EINVAL;
    + }
    s->socket.Vpp = mod->Vpp1;
    if (s->ops->set_socket(s, &s->socket)) {
    dev_printk(KERN_WARNING, &s->dev,
    --
    1.5.2.2


  2. Re: [PATCH] pcmcia: fix indentation & braces disagreement - add braces

    On Thu, Oct 30, 2008 at 01:02:54PM +0200, Ilpo Järvinen wrote:
    > Broken by d8b0a49da4f2 (pcmcia: deprecate CS_BAD_VCC and
    > CS_BAD_VPP).


    Applied, thanks!

    Dominik
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread