[PATCH] add include list.h in binfmts.h - Kernel

This is a discussion on [PATCH] add include list.h in binfmts.h - Kernel ; From: Hiroshi Shimamoto linux_binfmt uses list_head, so list.h is needed. Signed-off-by: Hiroshi Shimamoto --- include/linux/binfmts.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h index 7394b5b..06c1123 100644 --- a/include/linux/binfmts.h +++ b/include/linux/binfmts.h @@ -1,6 +1,7 @@ ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH] add include list.h in binfmts.h

  1. [PATCH] add include list.h in binfmts.h

    From: Hiroshi Shimamoto

    linux_binfmt uses list_head, so list.h is needed.

    Signed-off-by: Hiroshi Shimamoto
    ---
    include/linux/binfmts.h | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
    index 7394b5b..06c1123 100644
    --- a/include/linux/binfmts.h
    +++ b/include/linux/binfmts.h
    @@ -1,6 +1,7 @@
    #ifndef _LINUX_BINFMTS_H
    #define _LINUX_BINFMTS_H

    +#include
    #include

    struct pt_regs;
    --
    1.5.6

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] add include list.h in binfmts.h

    On Wed, 29 Oct 2008 18:03:26 -0700
    Hiroshi Shimamoto wrote:

    > From: Hiroshi Shimamoto
    >
    > linux_binfmt uses list_head, so list.h is needed.
    >
    > Signed-off-by: Hiroshi Shimamoto
    > ---
    > include/linux/binfmts.h | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
    > index 7394b5b..06c1123 100644
    > --- a/include/linux/binfmts.h
    > +++ b/include/linux/binfmts.h
    > @@ -1,6 +1,7 @@
    > #ifndef _LINUX_BINFMTS_H
    > #define _LINUX_BINFMTS_H
    >
    > +#include
    > #include
    >
    > struct pt_regs;


    Did this fix a build error which you were seeing?
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] add include list.h in binfmts.h

    Andrew Morton wrote:
    > On Wed, 29 Oct 2008 18:03:26 -0700
    > Hiroshi Shimamoto wrote:
    >
    >> From: Hiroshi Shimamoto
    >>
    >> linux_binfmt uses list_head, so list.h is needed.
    >>
    >> Signed-off-by: Hiroshi Shimamoto
    >> ---
    >> include/linux/binfmts.h | 1 +
    >> 1 files changed, 1 insertions(+), 0 deletions(-)
    >>
    >> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
    >> index 7394b5b..06c1123 100644
    >> --- a/include/linux/binfmts.h
    >> +++ b/include/linux/binfmts.h
    >> @@ -1,6 +1,7 @@
    >> #ifndef _LINUX_BINFMTS_H
    >> #define _LINUX_BINFMTS_H
    >>
    >> +#include
    >> #include
    >>
    >> struct pt_regs;

    >
    > Did this fix a build error which you were seeing?


    I just noticed it modifying arch/x86/kernel/signal_32.c headers.
    I don't know any case to fail build kernel.

    The file signal_32.c includes first, and To remove
    including list.h causes a build error.


    thanks,
    Hiroshi Shimamoto
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread