s390: struct device - replace bus_id with dev_name(), dev_set_name() - Kernel

This is a discussion on s390: struct device - replace bus_id with dev_name(), dev_set_name() - Kernel ; This patch is part of a larger patch series which will remove the "char bus_id[20]" name string from struct device. The device name is managed in the kobject anyway, and without any size limitation, and just needlessly copied into "struct ...

+ Reply to Thread
Results 1 to 6 of 6

Thread: s390: struct device - replace bus_id with dev_name(), dev_set_name()

  1. s390: struct device - replace bus_id with dev_name(), dev_set_name()

    This patch is part of a larger patch series which will remove
    the "char bus_id[20]" name string from struct device. The device
    name is managed in the kobject anyway, and without any size
    limitation, and just needlessly copied into "struct device".

    To set and read the device name dev_name(dev) and dev_set_name(dev)
    must be used. If your code uses static kobjects, which it shouldn't
    do, "const char *init_name" can be used to statically provide the
    name the registered device should have. At registration time, the
    init_name field is cleared, to enforce the use of dev_name(dev) to
    access the device name at a later time.

    We need to get rid of all occurrences of bus_id in the entire tree
    to be able to enable the new interface. Please apply this patch,
    and possibly convert any remaining remaining occurrences of bus_id.

    We want to submit a patch to -next, which will remove bus_id from
    "struct device", to find the remaining pieces to convert, and finally
    switch over to the new api, which will remove the 20 bytes array
    and does no longer have a size limitation.

    Thanks,
    Kay


    From: Kay Sievers
    Subject: s390: struct device - replace bus_id with dev_name(), dev_set_name()

    Cc: Martin Schwidefsky
    Cc: Cornelia Huck
    Acked-by: Greg Kroah-Hartman
    Signed-Off-By: Kay Sievers
    ---


    diff --git a/drivers/s390/block/dasd_devmap.c b/drivers/s390/block/dasd_devmap.c
    index 921443b..feceb89 100644
    --- a/drivers/s390/block/dasd_devmap.c
    +++ b/drivers/s390/block/dasd_devmap.c
    @@ -23,6 +23,7 @@

    /* This is ugly... */
    #define PRINTK_HEADER "dasd_devmap:"
    +#define DASD_BUS_ID_SIZE 20

    #include "dasd_int.h"

    @@ -41,7 +42,7 @@ EXPORT_SYMBOL_GPL(dasd_page_cache);
    */
    struct dasd_devmap {
    struct list_head list;
    - char bus_id[BUS_ID_SIZE];
    + char bus_id[DASD_BUS_ID_SIZE];
    unsigned int devindex;
    unsigned short features;
    struct dasd_device *device;
    @@ -94,7 +95,7 @@ dasd_hash_busid(const char *bus_id)
    int hash, i;

    hash = 0;
    - for (i = 0; (i < BUS_ID_SIZE) && *bus_id; i++, bus_id++)
    + for (i = 0; (i < DASD_BUS_ID_SIZE) && *bus_id; i++, bus_id++)
    hash += *bus_id;
    return hash & 0xff;
    }
    @@ -301,7 +302,7 @@ dasd_parse_range( char *parsestring ) {
    int from, from_id0, from_id1;
    int to, to_id0, to_id1;
    int features, rc;
    - char bus_id[BUS_ID_SIZE+1], *str;
    + char bus_id[DASD_BUS_ID_SIZE+1], *str;

    str = parsestring;
    rc = dasd_busid(&str, &from_id0, &from_id1, &from);
    @@ -407,14 +408,14 @@ dasd_add_busid(const char *bus_id, int features)
    devmap = NULL;
    hash = dasd_hash_busid(bus_id);
    list_for_each_entry(tmp, &dasd_hashlists[hash], list)
    - if (strncmp(tmp->bus_id, bus_id, BUS_ID_SIZE) == 0) {
    + if (strncmp(tmp->bus_id, bus_id, DASD_BUS_ID_SIZE) == 0) {
    devmap = tmp;
    break;
    }
    if (!devmap) {
    /* This bus_id is new. */
    new->devindex = dasd_max_devindex++;
    - strncpy(new->bus_id, bus_id, BUS_ID_SIZE);
    + strncpy(new->bus_id, bus_id, DASD_BUS_ID_SIZE);
    new->features = features;
    new->device = NULL;
    list_add(&new->list, &dasd_hashlists[hash]);
    @@ -439,7 +440,7 @@ dasd_find_busid(const char *bus_id)
    devmap = ERR_PTR(-ENODEV);
    hash = dasd_hash_busid(bus_id);
    list_for_each_entry(tmp, &dasd_hashlists[hash], list) {
    - if (strncmp(tmp->bus_id, bus_id, BUS_ID_SIZE) == 0) {
    + if (strncmp(tmp->bus_id, bus_id, DASD_BUS_ID_SIZE) == 0) {
    devmap = tmp;
    break;
    }
    diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c
    index 63f26a1..b1b204c 100644
    --- a/drivers/s390/block/dcssblk.c
    +++ b/drivers/s390/block/dcssblk.c
    @@ -21,6 +21,7 @@
    #define DCSSBLK_NAME "dcssblk"
    #define DCSSBLK_MINORS_PER_DISK 1
    #define DCSSBLK_PARM_LEN 400
    +#define DCSS_BUS_ID_SIZE 20

    #ifdef DCSSBLK_DEBUG
    #define PRINT_DEBUG(x...) printk(KERN_DEBUG DCSSBLK_NAME " debug: " x)
    @@ -50,7 +51,7 @@ static struct block_device_operations dcssblk_devops = {
    struct dcssblk_dev_info {
    struct list_head lh;
    struct device dev;
    - char segment_name[BUS_ID_SIZE];
    + char segment_name[DCSS_BUS_ID_SIZE];
    atomic_t use_count;
    struct gendisk *gd;
    unsigned long start;
    @@ -65,7 +66,7 @@ struct dcssblk_dev_info {

    struct segment_info {
    struct list_head lh;
    - char segment_name[BUS_ID_SIZE];
    + char segment_name[DCSS_BUS_ID_SIZE];
    unsigned long start;
    unsigned long end;
    int segment_type;
    diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
    index 3ac2c20..17fa009 100644
    --- a/drivers/s390/cio/ccwgroup.c
    +++ b/drivers/s390/cio/ccwgroup.c
    @@ -19,6 +19,8 @@
    #include
    #include

    +#define CCW_BUS_ID_SIZE 20
    +
    /* In Linux 2.4, we had a channel device layer called "chandev"
    * that did all sorts of obscure stuff for networking devices.
    * This is another driver that serves as a replacement for just
    @@ -172,7 +174,7 @@ static int __get_next_bus_id(const char **buf, char *bus_id)
    len = end - start + 1;
    end++;
    }
    - if (len < BUS_ID_SIZE) {
    + if (len < CCW_BUS_ID_SIZE) {
    strlcpy(bus_id, start, len);
    rc = 0;
    } else
    @@ -181,7 +183,7 @@ static int __get_next_bus_id(const char **buf, char *bus_id)
    return rc;
    }

    -static int __is_valid_bus_id(char bus_id[BUS_ID_SIZE])
    +static int __is_valid_bus_id(char bus_id[CCW_BUS_ID_SIZE])
    {
    int cssid, ssid, devno;

    @@ -213,7 +215,7 @@ int ccwgroup_create_from_string(struct device *root, unsigned int creator_id,
    {
    struct ccwgroup_device *gdev;
    int rc, i;
    - char tmp_bus_id[BUS_ID_SIZE];
    + char tmp_bus_id[CCW_BUS_ID_SIZE];
    const char *curr_buf;

    gdev = kzalloc(sizeof(*gdev) + num_devices * sizeof(gdev->cdev[0]),
    diff --git a/drivers/s390/cio/device.c b/drivers/s390/cio/device.c
    index 4e78c82..8aca8e0 100644
    --- a/drivers/s390/cio/device.c
    +++ b/drivers/s390/cio/device.c
    @@ -1719,7 +1719,7 @@ __ccwdev_check_busid(struct device *dev, void *id)

    bus_id = id;

    - return (strncmp(bus_id, dev_name(dev), BUS_ID_SIZE) == 0);
    + return (strcmp(bus_id, dev_name(dev)) == 0);
    }


    diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c
    index 3b56220..82cc618 100644
    --- a/drivers/s390/scsi/zfcp_aux.c
    +++ b/drivers/s390/scsi/zfcp_aux.c
    @@ -28,6 +28,8 @@
    #include
    #include "zfcp_ext.h"

    +#define ZFCP_BUS_ID_SIZE 20
    +
    static char *device;

    MODULE_AUTHOR("IBM Deutschland Entwicklung GmbH - linux390@de.ibm.com");
    @@ -83,9 +85,9 @@ static int __init zfcp_device_setup(char *devstr)
    strcpy(str, devstr);

    token = strsep(&str, ",");
    - if (!token || strlen(token) >= BUS_ID_SIZE)
    + if (!token || strlen(token) >= ZFCP_BUS_ID_SIZE)
    goto err_out;
    - strncpy(zfcp_data.init_busid, token, BUS_ID_SIZE);
    + strncpy(zfcp_data.init_busid, token, ZFCP_BUS_ID_SIZE);

    token = strsep(&str, ",");
    if (!token || strict_strtoull(token, 0,

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: s390: struct device - replace bus_id with dev_name(), dev_set_name()

    On Thu, 30 Oct 2008 01:57:07 +0100,
    Kay Sievers wrote:

    > From: Kay Sievers
    > Subject: s390: struct device - replace bus_id with dev_name(), dev_set_name()
    >
    > Cc: Martin Schwidefsky
    > Cc: Cornelia Huck
    > Acked-by: Greg Kroah-Hartman
    > Signed-Off-By: Kay Sievers


    Other than the fact that this patch is a bit mis-named (it just gets
    rid of BUS_ID_SIZE), this looks fine to me.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: s390: struct device - replace bus_id with dev_name(), dev_set_name()

    On Thu, Oct 30, 2008 at 10:32:00AM +0100, Cornelia Huck wrote:
    > On Thu, 30 Oct 2008 01:57:07 +0100,
    > Kay Sievers wrote:
    >
    > > From: Kay Sievers
    > > Subject: s390: struct device - replace bus_id with dev_name(), dev_set_name()
    > >
    > > Cc: Martin Schwidefsky
    > > Cc: Cornelia Huck
    > > Acked-by: Greg Kroah-Hartman
    > > Signed-Off-By: Kay Sievers

    >
    > Other than the fact that this patch is a bit mis-named (it just gets
    > rid of BUS_ID_SIZE), this looks fine to me.


    Who is supposed to send this upstream and when?
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: s390: struct device - replace bus_id with dev_name(), dev_set_name()

    On Thu, Oct 30, 2008 at 12:38, Heiko Carstens wrote:
    > On Thu, Oct 30, 2008 at 10:32:00AM +0100, Cornelia Huck wrote:
    >> On Thu, 30 Oct 2008 01:57:07 +0100,
    >> Kay Sievers wrote:
    >>
    >> > From: Kay Sievers
    >> > Subject: s390: struct device - replace bus_id with dev_name(), dev_set_name()
    >> >
    >> > Cc: Martin Schwidefsky
    >> > Cc: Cornelia Huck
    >> > Acked-by: Greg Kroah-Hartman
    >> > Signed-Off-By: Kay Sievers

    >>
    >> Other than the fact that this patch is a bit mis-named (it just gets
    >> rid of BUS_ID_SIZE), this looks fine to me.


    Yeah, sorry, it's one of the 49 patches, where the subjects isn't
    right, because you did the conversion already.

    > Who is supposed to send this upstream and when?


    Would be fine if it goes through the s390 tree, and gets merged there
    soon so it shows up in -next.

    Thanks,
    Kay
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: s390: struct device - replace bus_id with dev_name(), dev_set_name()

    On Thu, Oct 30, 2008 at 03:58:21PM +0100, Kay Sievers wrote:
    > On Thu, Oct 30, 2008 at 12:38, Heiko Carstens wrote:
    > > On Thu, Oct 30, 2008 at 10:32:00AM +0100, Cornelia Huck wrote:
    > >> On Thu, 30 Oct 2008 01:57:07 +0100,
    > >> Kay Sievers wrote:
    > >>
    > >> > From: Kay Sievers
    > >> > Subject: s390: struct device - replace bus_id with dev_name(), dev_set_name()
    > >> >
    > >> > Cc: Martin Schwidefsky
    > >> > Cc: Cornelia Huck
    > >> > Acked-by: Greg Kroah-Hartman
    > >> > Signed-Off-By: Kay Sievers
    > >>
    > >> Other than the fact that this patch is a bit mis-named (it just gets
    > >> rid of BUS_ID_SIZE), this looks fine to me.

    >
    > Yeah, sorry, it's one of the 49 patches, where the subjects isn't
    > right, because you did the conversion already.
    >
    > > Who is supposed to send this upstream and when?

    >
    > Would be fine if it goes through the s390 tree, and gets merged there
    > soon so it shows up in -next.


    Just to get this right: it doesn't depend on any other patches and is
    fine as a standalone patch, right?
    Sorry, this isn't obvious for me
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  6. Re: s390: struct device - replace bus_id with dev_name(), dev_set_name()

    On Thu, Oct 30, 2008 at 16:46, Heiko Carstens wrote:
    > On Thu, Oct 30, 2008 at 03:58:21PM +0100, Kay Sievers wrote:
    >> On Thu, Oct 30, 2008 at 12:38, Heiko Carstens wrote:
    >> > On Thu, Oct 30, 2008 at 10:32:00AM +0100, Cornelia Huck wrote:
    >> >> On Thu, 30 Oct 2008 01:57:07 +0100,
    >> >> Kay Sievers wrote:
    >> >>
    >> >> > From: Kay Sievers
    >> >> > Subject: s390: struct device - replace bus_id with dev_name(), dev_set_name()
    >> >> >
    >> >> > Cc: Martin Schwidefsky
    >> >> > Cc: Cornelia Huck
    >> >> > Acked-by: Greg Kroah-Hartman
    >> >> > Signed-Off-By: Kay Sievers
    >> >>
    >> >> Other than the fact that this patch is a bit mis-named (it just gets
    >> >> rid of BUS_ID_SIZE), this looks fine to me.

    >>
    >> Yeah, sorry, it's one of the 49 patches, where the subjects isn't
    >> right, because you did the conversion already.
    >>
    >> > Who is supposed to send this upstream and when?

    >>
    >> Would be fine if it goes through the s390 tree, and gets merged there
    >> soon so it shows up in -next.

    >
    > Just to get this right: it doesn't depend on any other patches and is
    > fine as a standalone patch, right?
    > Sorry, this isn't obvious for me


    The stuff it depends on, we already put into .27. It should not depend
    on anything not in a released version, yes.

    Kay
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread