[PATCH] corruption checker: print the DMI board name - Kernel

This is a discussion on [PATCH] corruption checker: print the DMI board name - Kernel ; From 4f829eef5a31b68a0cbaf83a75ac8b0a1ed05afb Mon Sep 17 00:00:00 2001 From: Arjan van de Ven Date: Wed, 29 Oct 2008 09:13:23 -0700 Subject: [PATCH] corruption checker: print the DMI board name when the memory corruptor checker hits (as it has done now based ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: [PATCH] corruption checker: print the DMI board name

  1. [PATCH] corruption checker: print the DMI board name


    From 4f829eef5a31b68a0cbaf83a75ac8b0a1ed05afb Mon Sep 17 00:00:00 2001
    From: Arjan van de Ven
    Date: Wed, 29 Oct 2008 09:13:23 -0700
    Subject: [PATCH] corruption checker: print the DMI board name

    when the memory corruptor checker hits (as it has done now based on kerneloops.org data),
    it would be extremely useful to know the DMI board name so we can add a blacklist for
    such a machine... without having to ask the user for lots of extra info.

    Signed-off-by: Arjan van de Ven
    ---
    arch/x86/kernel/check.c | 8 +++++++-
    1 files changed, 7 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kernel/check.c b/arch/x86/kernel/check.c
    index 2ac0ab7..f952182 100644
    --- a/arch/x86/kernel/check.c
    +++ b/arch/x86/kernel/check.c
    @@ -2,6 +2,7 @@
    #include
    #include
    #include
    +#include
    #include
    #include

    @@ -113,6 +114,7 @@ void check_for_bios_corruption(void)
    {
    int i;
    int corruption = 0;
    + const char *board;

    if (!memory_corruption_check)
    return;
    @@ -131,7 +133,11 @@ void check_for_bios_corruption(void)
    }
    }

    - WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\n");
    + board = dmi_get_system_info(DMI_PRODUCT_NAME);
    + if (!board)
    + board = "";
    + WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\nBoard name: %s\n",
    + board);
    }

    static void check_corruption(struct work_struct *dummy);
    --
    1.5.5.1


    --
    Arjan van de Ven Intel Open Source Technology Centre
    For development, discussion and tips for power savings,
    visit http://www.lesswatts.org
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. [PATCH] corruption checker: print the DMI board name on corruption

    Hi Linus,

    would you consider merging this patch for 2.6.28 still?
    Without this patch, kerneloops.org only gets to see THAT corruption
    happens, but doesn't have information about what kind of system the
    corruption is happening on.. (which is the useful part to make a
    DMI blacklist).

    So far we have 1 such report in kerneloops.org but it's useless... no
    system information.



    From c66993517ac861964d6968d3672f88b3b69e29ce Mon Sep 17 00:00:00 2001
    From: Arjan van de Ven
    Date: Wed, 29 Oct 2008 09:24:44 -0700
    Subject: [PATCH] corruption checker: print the DMI board name on corruption

    when the memory corruptor checker hits (as it has done now based on
    kerneloops.org data), it would be extremely useful to know the DMI board
    name so we can add a blacklist for such a machine... without having to ask
    the user for lots of extra info.

    Signed-off-by: Arjan van de Ven
    ---
    arch/x86/kernel/setup.c | 7 ++++++-
    1 files changed, 6 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
    index 0fa6790..d57fee2 100644
    --- a/arch/x86/kernel/setup.c
    +++ b/arch/x86/kernel/setup.c
    @@ -697,6 +697,7 @@ void check_for_bios_corruption(void)
    {
    int i;
    int corruption = 0;
    + const char *board;

    if (!memory_corruption_check)
    return;
    @@ -715,7 +716,11 @@ void check_for_bios_corruption(void)
    }
    }

    - WARN(corruption, KERN_ERR "Memory corruption detected in low memory\n");
    + board = dmi_get_system_info(DMI_PRODUCT_NAME);
    + if (!board)
    + board = "";
    + WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\nBoard name: %s\n",
    + board);
    }

    static void periodic_check_for_corruption(unsigned long data)
    --
    1.5.5.1

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] corruption checker: print the DMI board name on corruption


    * Arjan van de Ven wrote:

    > Hi Linus,
    >
    > would you consider merging this patch for 2.6.28 still?
    > Without this patch, kerneloops.org only gets to see THAT corruption
    > happens, but doesn't have information about what kind of system the
    > corruption is happening on.. (which is the useful part to make a
    > DMI blacklist).
    >
    > So far we have 1 such report in kerneloops.org but it's useless... no
    > system information.


    such "improve our kerneloops.org yield" patches are fair game up to
    -rc7 or so i think.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] corruption checker: print the DMI board name

    >
    > >From 4f829eef5a31b68a0cbaf83a75ac8b0a1ed05afb Mon Sep 17 00:00:00 2001

    > From: Arjan van de Ven
    > Date: Wed, 29 Oct 2008 09:13:23 -0700
    > Subject: [PATCH] corruption checker: print the DMI board name
    >
    > when the memory corruptor checker hits (as it has done now based on kerneloops.org data),
    > it would be extremely useful to know the DMI board name so we can add a blacklist for
    > such a machine... without having to ask the user for lots of extra info.


    I'm not sure if blacklisting whole brand for one case of bit
    corruption is fair -- perhaps the memory was overheating?


    > Signed-off-by: Arjan van de Ven


    But ACK -- we certainly want to see the data.

    > ---
    > arch/x86/kernel/check.c | 8 +++++++-
    > 1 files changed, 7 insertions(+), 1 deletions(-)
    >
    > diff --git a/arch/x86/kernel/check.c b/arch/x86/kernel/check.c
    > index 2ac0ab7..f952182 100644
    > --- a/arch/x86/kernel/check.c
    > +++ b/arch/x86/kernel/check.c
    > @@ -2,6 +2,7 @@
    > #include
    > #include
    > #include
    > +#include
    > #include
    > #include
    >
    > @@ -113,6 +114,7 @@ void check_for_bios_corruption(void)
    > {
    > int i;
    > int corruption = 0;
    > + const char *board;
    >
    > if (!memory_corruption_check)
    > return;
    > @@ -131,7 +133,11 @@ void check_for_bios_corruption(void)
    > }
    > }
    >
    > - WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\n");
    > + board = dmi_get_system_info(DMI_PRODUCT_NAME);
    > + if (!board)
    > + board = "";
    > + WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\nBoard name: %s\n",
    > + board);
    > }
    >
    > static void check_corruption(struct work_struct *dummy);


    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pav...rses/blog.html
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [PATCH] corruption checker: print the DMI board name

    On Thu, 30 Oct 2008 12:06:53 +0100
    Pavel Machek wrote:

    > >
    > > >From 4f829eef5a31b68a0cbaf83a75ac8b0a1ed05afb Mon Sep 17 00:00:00
    > > >2001

    > > From: Arjan van de Ven
    > > Date: Wed, 29 Oct 2008 09:13:23 -0700
    > > Subject: [PATCH] corruption checker: print the DMI board name
    > >
    > > when the memory corruptor checker hits (as it has done now based on
    > > kerneloops.org data), it would be extremely useful to know the DMI
    > > board name so we can add a blacklist for such a machine... without
    > > having to ask the user for lots of extra info.

    >
    > I'm not sure if blacklisting whole brand for one case of bit
    > corruption is fair -- perhaps the memory was overheating?


    this is where kerneloops.org comes in; we can separate the "happens a
    lot" from "happens on blue moons"

    >
    >
    > > Signed-off-by: Arjan van de Ven

    >
    > But ACK -- we certainly want to see the data.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread