[patch] vmemmap: warn about page_structs with remote distance - Kernel

This is a discussion on [patch] vmemmap: warn about page_structs with remote distance - Kernel ; It's insufficient to simply compare node ids when warning about offnode page_structs since it's possible to still have local affinity. Cc: Christoph Lameter Signed-off-by: David Rientjes --- mm/sparse-vmemmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [patch] vmemmap: warn about page_structs with remote distance

  1. [patch] vmemmap: warn about page_structs with remote distance

    It's insufficient to simply compare node ids when warning about offnode
    page_structs since it's possible to still have local affinity.

    Cc: Christoph Lameter
    Signed-off-by: David Rientjes
    ---
    mm/sparse-vmemmap.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c
    --- a/mm/sparse-vmemmap.c
    +++ b/mm/sparse-vmemmap.c
    @@ -64,7 +64,7 @@ void __meminit vmemmap_verify(pte_t *pte, int node,
    unsigned long pfn = pte_pfn(*pte);
    int actual_node = early_pfn_to_nid(pfn);

    - if (actual_node != node)
    + if (node_distance(actual_node, node) > LOCAL_DISTANCE)
    printk(KERN_WARNING "[%lx-%lx] potential offnode "
    "page_structs\n", start, end - 1);
    }
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [patch] vmemmap: warn about page_structs with remote distance

    On Tue, 28 Oct 2008, David Rientjes wrote:

    > It's insufficient to simply compare node ids when warning about offnode
    > page_structs since it's possible to still have local affinity.


    Well that means that we distinguish nodes on the same motherboard (f.e.
    AMD memory architecture) from nodes that are on truly remote nodes.

    Guess the delays on a single motherboard do not matter much?

    Acked-by: Christoph Lameter

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread