[PATCH 1/2] w35und: remove macro magic from MLME_GetNextPacket() - Kernel

This is a discussion on [PATCH 1/2] w35und: remove macro magic from MLME_GetNextPacket() - Kernel ; From: Pekka Enberg This removes the macro magic from MLME_GetNextPacket() to de-obfuscate the code. Cc: Pavel Machek Signed-off-by: Pekka Enberg --- drivers/staging/winbond/mlmetxrx.c | 22 ++++++++-------------- 1 files changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/winbond/mlmetxrx.c b/drivers/staging/winbond/mlmetxrx.c index eab562a..a071855 100644 --- ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 1/2] w35und: remove macro magic from MLME_GetNextPacket()

  1. [PATCH 1/2] w35und: remove macro magic from MLME_GetNextPacket()

    From: Pekka Enberg

    This removes the macro magic from MLME_GetNextPacket() to de-obfuscate the
    code.

    Cc: Pavel Machek
    Signed-off-by: Pekka Enberg
    ---
    drivers/staging/winbond/mlmetxrx.c | 22 ++++++++--------------
    1 files changed, 8 insertions(+), 14 deletions(-)

    diff --git a/drivers/staging/winbond/mlmetxrx.c b/drivers/staging/winbond/mlmetxrx.c
    index eab562a..a071855 100644
    --- a/drivers/staging/winbond/mlmetxrx.c
    +++ b/drivers/staging/winbond/mlmetxrx.c
    @@ -96,21 +96,15 @@ u8 MLMESendFrame(struct wb35_adapter * adapter, u8 *pMMPDU, u16 len, u8 DataType
    return true;
    }

    -void
    -MLME_GetNextPacket(struct wb35_adapter * adapter, PDESCRIPTOR pDes)
    +void MLME_GetNextPacket(struct wb35_adapter *adapter, PDESCRIPTOR desc)
    {
    -#define DESCRIPTOR_ADD_BUFFER( _D, _A, _S ) \
    -{\
    - _D->InternalUsed = _D->buffer_start_index + _D->buffer_number; \
    - _D->InternalUsed %= MAX_DESCRIPTOR_BUFFER_INDEX; \
    - _D->buffer_address[ _D->InternalUsed ] = _A; \
    - _D->buffer_size[ _D->InternalUsed ] = _S; \
    - _D->buffer_total_size += _S; \
    - _D->buffer_number++;\
    -}
    -
    - DESCRIPTOR_ADD_BUFFER( pDes, adapter->sMlmeFrame.pMMPDU, adapter->sMlmeFrame.len );
    - pDes->Type = adapter->sMlmeFrame.DataType;
    + desc->InternalUsed = desc->buffer_start_index + desc->buffer_number;
    + desc->InternalUsed %= MAX_DESCRIPTOR_BUFFER_INDEX;
    + desc->buffer_address[desc->InternalUsed] = adapter->sMlmeFrame.pMMPDU;
    + desc->buffer_size[desc->InternalUsed] = adapter->sMlmeFrame.len;
    + desc->buffer_total_size += adapter->sMlmeFrame.len;
    + desc->buffer_number++;
    + desc->Type = adapter->sMlmeFrame.DataType;
    }

    void MLMEfreeMMPDUBuffer(struct wb35_adapter * adapter, s8 *pData)
    --
    1.5.3.7

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 1/2] w35und: remove macro magic from MLME_GetNextPacket()

    On Tue 2008-10-28 00:14:14, Pekka J Enberg wrote:
    > From: Pekka Enberg
    >
    > This removes the macro magic from MLME_GetNextPacket() to de-obfuscate the
    > code.


    Acked-by: Pavel Machek

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pav...rses/blog.html
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread