[PATCH] w35und: usb_put_dev() is missing from wb35_disconnect() - Kernel

This is a discussion on [PATCH] w35und: usb_put_dev() is missing from wb35_disconnect() - Kernel ; From: Pekka Enberg The wb35_probe() function does usb_get_dev() so add a missing usb_put_dev() to the wb35_disconnect() function. Also fix error handling paths in wb35_probe() to call usb_put_dev() as well. Cc: Pavel Machek Signed-off-by: Pekka Enberg --- drivers/staging/winbond/linux/wbusb.c | 7 ++++--- ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] w35und: usb_put_dev() is missing from wb35_disconnect()

  1. [PATCH] w35und: usb_put_dev() is missing from wb35_disconnect()

    From: Pekka Enberg

    The wb35_probe() function does usb_get_dev() so add a missing usb_put_dev() to
    the wb35_disconnect() function. Also fix error handling paths in wb35_probe()
    to call usb_put_dev() as well.

    Cc: Pavel Machek
    Signed-off-by: Pekka Enberg
    ---
    drivers/staging/winbond/linux/wbusb.c | 7 ++++---
    1 files changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/staging/winbond/linux/wbusb.c b/drivers/staging/winbond/linux/wbusb.c
    index 582ede4..128b70a 100644
    --- a/drivers/staging/winbond/linux/wbusb.c
    +++ b/drivers/staging/winbond/linux/wbusb.c
    @@ -277,6 +277,7 @@ error_free_hw:
    error_free_adapter:
    kfree(adapter);
    error:
    + usb_put_dev(udev);
    return err;
    }

    @@ -310,12 +311,12 @@ void packet_came(char *pRxBufferAddress, int PacketSize)

    static void wb35_disconnect(struct usb_interface *intf)
    {
    - struct wb35_adapter * adapter = usb_get_intfdata(intf);
    - usb_set_intfdata(intf, NULL);
    + struct wb35_adapter *adapter = usb_get_intfdata(intf);

    - // Card remove
    WbWlanHalt(adapter);

    + usb_set_intfdata(intf, NULL);
    + usb_put_dev(interface_to_usbdev(intf));
    }

    static struct usb_driver wb35_driver = {
    --
    1.5.3.7

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] w35und: usb_put_dev() is missing from wb35_disconnect()

    On Mon 2008-10-27 23:29:31, Pekka J Enberg wrote:
    > From: Pekka Enberg
    >
    > The wb35_probe() function does usb_get_dev() so add a missing usb_put_dev() to
    > the wb35_disconnect() function. Also fix error handling paths in wb35_probe()
    > to call usb_put_dev() as well.


    Acked-by: Pavel Machek

    ....and thanks for all the patches. I don't think I ever tested module
    removal on this one...
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pav...rses/blog.html
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread