CONFIG_LEDS_DA903X=m breaks 2.6.28-rc2-git1 build on x86-64 - Kernel

This is a discussion on CONFIG_LEDS_DA903X=m breaks 2.6.28-rc2-git1 build on x86-64 - Kernel ; Hi Mike, Eric, Richard, With CONFIG_LEDS_DA903X=m, kernel 2.6.28-rc2-git1 fails to build on x86-64 with the following error: CC [M] drivers/leds/leds-da903x.o drivers/leds/leds-da903x.c:35: error: field "work" has incomplete type drivers/leds/leds-da903x.c: In function "da903x_led_work": drivers/leds/leds-da903x.c:47: warning: type defaults to "int" in declaration of ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: CONFIG_LEDS_DA903X=m breaks 2.6.28-rc2-git1 build on x86-64

  1. CONFIG_LEDS_DA903X=m breaks 2.6.28-rc2-git1 build on x86-64

    Hi Mike, Eric, Richard,

    With CONFIG_LEDS_DA903X=m, kernel 2.6.28-rc2-git1 fails to build on
    x86-64 with the following error:

    CC [M] drivers/leds/leds-da903x.o
    drivers/leds/leds-da903x.c:35: error: field "work" has incomplete type
    drivers/leds/leds-da903x.c: In function "da903x_led_work":
    drivers/leds/leds-da903x.c:47: warning: type defaults to "int" in declaration of "__mptr"
    drivers/leds/leds-da903x.c:47: warning: initialization from incompatible pointer type
    drivers/leds/leds-da903x.c: In function "da903x_led_set":
    drivers/leds/leds-da903x.c:89: error: implicit declaration of function "schedule_work"
    drivers/leds/leds-da903x.c: In function "da903x_led_probe":
    drivers/leds/leds-da903x.c:125: error: implicit declaration of function "INIT_WORK"

    Can we PLEASE stick to the plan and ONLY have bug FIXES after rc1 (and
    even more so after rc2)?

    Thanks,
    --
    Jean Delvare
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: CONFIG_LEDS_DA903X=m breaks 2.6.28-rc2-git1 build on x86-64

    Hi Eric,

    On Mon, 27 Oct 2008 03:09:25 -0700, Eric Miao wrote:
    > This is strange, it compiles OK on ARM, I don't know why this
    > failed on x86-64. But anyway, should really
    > be explicitly included here.
    >
    > The attached patch should fix this.


    Yes it does, thanks for the quick fix. Please get this upstream quickly
    too.

    Acked-by: Jean Delvare

    --
    Jean Delvare
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread