[PATCH] Handle space after for_each_* macros gracefully in checkpatch - Kernel

This is a discussion on [PATCH] Handle space after for_each_* macros gracefully in checkpatch - Kernel ; Handle space after for_each_* macros gracefully in checkpatch.pl Anyone else seeing the irony of checkpatch.pl recommending to use for_each_cpu_mask, but then not actually parsing it correctly. When you write for_each_cpu_mask (...) { it would complain about the space between mask ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] Handle space after for_each_* macros gracefully in checkpatch

  1. [PATCH] Handle space after for_each_* macros gracefully in checkpatch

    Handle space after for_each_* macros gracefully in checkpatch.pl

    Anyone else seeing the irony of checkpatch.pl recommending to
    use for_each_cpu_mask, but then not actually parsing it
    correctly.

    When you write

    for_each_cpu_mask (...) {

    it would complain about the space between mask and the open bracket
    because it thinks it's a normal function call.

    Fix this in a generic way. In theory someone could construct
    a normal function that starts with for_each_* and it would
    not warn, but I think that would be uncommon. The alternative
    of listing all macros was tried first, but turned out to
    be unwieldly.

    I think I covered most of the common ones available, the
    only exceptions are a few oddballs with leading prefix
    like pnp_for_each* or zorro_for_each.

    Signed-off-by: Andi Kleen

    Index: linux-2.6.27-misc/scripts/checkpatch.pl
    ================================================== =================
    --- linux-2.6.27-misc.orig/scripts/checkpatch.pl
    +++ linux-2.6.27-misc/scripts/checkpatch.pl
    @@ -1513,6 +1513,7 @@ sub process {
    if|for|while|switch|return|case|
    volatile|__volatile__|
    __attribute__|format|__extension__|
    + ([ph]?list_)?for_each_[a-z_]+|
    asm|__asm__)$/x)
    {

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] Handle space after for_each_* macros gracefully in checkpatch

    On Fri, Oct 24, 2008 at 01:50:10PM +0200, Andi Kleen wrote:
    > Handle space after for_each_* macros gracefully in checkpatch.pl
    >
    > Anyone else seeing the irony of checkpatch.pl recommending to
    > use for_each_cpu_mask, but then not actually parsing it
    > correctly.
    >
    > When you write
    >
    > for_each_cpu_mask (...) {
    >
    > it would complain about the space between mask and the open bracket
    > because it thinks it's a normal function call.
    >
    > Fix this in a generic way. In theory someone could construct
    > a normal function that starts with for_each_* and it would
    > not warn, but I think that would be uncommon. The alternative
    > of listing all macros was tried first, but turned out to
    > be unwieldly.
    >
    > I think I covered most of the common ones available, the
    > only exceptions are a few oddballs with leading prefix
    > like pnp_for_each* or zorro_for_each.


    I am happy with this conceptually. However when this was suggested
    before there was a concensus that that it was not obvious whether this
    was meant to be written as a function or a control and nothing was done.

    So if people are with you on this, I am happy.

    -apw
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread