[PATCH] pci: PCI_QUIRKS depends on PCI - Kernel

This is a discussion on [PATCH] pci: PCI_QUIRKS depends on PCI - Kernel ; commit 3d137310245e4cdc3e8c8ba1bea2e145a87ae8e3 ("PCI: allow quirks to be compiled out") introduced CONFIG_PCI_QUIRKS, which now shows up in each and every .config. Probably the intention was to make the PCI_QUIRKS symbol depend on PCI, not on its selection enabler? Signed-off-by: Geert Uytterhoeven ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] pci: PCI_QUIRKS depends on PCI

  1. [PATCH] pci: PCI_QUIRKS depends on PCI

    commit 3d137310245e4cdc3e8c8ba1bea2e145a87ae8e3 ("PCI: allow quirks to be
    compiled out") introduced CONFIG_PCI_QUIRKS, which now shows up in each
    and every .config.

    Probably the intention was to make the PCI_QUIRKS symbol depend on PCI, not
    on its selection enabler?

    Signed-off-by: Geert Uytterhoeven
    ---
    init/Kconfig | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/init/Kconfig
    +++ b/init/Kconfig
    @@ -739,7 +739,8 @@ config VM_EVENT_COUNTERS

    config PCI_QUIRKS
    default y
    - bool "Enable PCI quirk workarounds" if EMBEDDED && PCI
    + bool "Enable PCI quirk workarounds" if EMBEDDED
    + depends on PCI
    help
    This enables workarounds for various PCI chipset
    bugs/quirks. Disable this only if your target machine is

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] pci: PCI_QUIRKS depends on PCI

    On Tuesday, October 21, 2008 11:53 pm Geert Uytterhoeven wrote:
    > commit 3d137310245e4cdc3e8c8ba1bea2e145a87ae8e3 ("PCI: allow quirks to be
    > compiled out") introduced CONFIG_PCI_QUIRKS, which now shows up in each
    > and every .config.
    >
    > Probably the intention was to make the PCI_QUIRKS symbol depend on PCI, not
    > on its selection enabler?
    >
    > Signed-off-by: Geert Uytterhoeven


    Yeah, that works. Thanks Geert.

    Jesse
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread