[PATCH] sound: correct bracketing in spdif test - Kernel

This is a discussion on [PATCH] sound: correct bracketing in spdif test - Kernel ; Noticed by sparse: sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y Signed-off-by: Harvey Harrison --- sound/pci/hda/patch_sigmatel.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index a2ac720..788fdc6 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -1282,7 +1282,7 @@ static ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH] sound: correct bracketing in spdif test

  1. [PATCH] sound: correct bracketing in spdif test

    Noticed by sparse:
    sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y

    Signed-off-by: Harvey Harrison
    ---
    sound/pci/hda/patch_sigmatel.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
    index a2ac720..788fdc6 100644
    --- a/sound/pci/hda/patch_sigmatel.c
    +++ b/sound/pci/hda/patch_sigmatel.c
    @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
    return err;
    spec->multiout.share_spdif = 1;
    }
    - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
    + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
    err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
    if (err < 0)
    return err;
    --
    1.6.0.2.824.geb4d2

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] sound: correct bracketing in spdif test

    Harvey Harrison wrote:
    > Noticed by sparse:
    > sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
    >
    > Signed-off-by: Harvey Harrison
    > ---
    > sound/pci/hda/patch_sigmatel.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
    > index a2ac720..788fdc6 100644
    > --- a/sound/pci/hda/patch_sigmatel.c
    > +++ b/sound/pci/hda/patch_sigmatel.c
    > @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
    > return err;
    > spec->multiout.share_spdif = 1;
    > }
    > - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
    > + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
    > err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
    > if (err < 0)
    > return err;


    Thanks for finding this.


    Acked-by: Matthew Ranostay
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] sound: correct bracketing in spdif test

    At Tue, 21 Oct 2008 23:38:31 -0400,
    Matthew Ranostay wrote:
    >
    > Harvey Harrison wrote:
    > > Noticed by sparse:
    > > sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
    > >
    > > Signed-off-by: Harvey Harrison
    > > ---
    > > sound/pci/hda/patch_sigmatel.c | 2 +-
    > > 1 files changed, 1 insertions(+), 1 deletions(-)
    > >
    > > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
    > > index a2ac720..788fdc6 100644
    > > --- a/sound/pci/hda/patch_sigmatel.c
    > > +++ b/sound/pci/hda/patch_sigmatel.c
    > > @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
    > > return err;
    > > spec->multiout.share_spdif = 1;
    > > }
    > > - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
    > > + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
    > > err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
    > > if (err < 0)
    > > return err;

    >
    > Thanks for finding this.
    >
    >
    > Acked-by: Matthew Ranostay


    Applied now. Thanks!

    Takashi
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread