linux-next: build failure - Kernel

This is a discussion on linux-next: build failure - Kernel ; Hi Greg, Today's linux-next build (powerpc allyesconfig) failed like this: In file included from drivers/staging/sxg/sxg.c:77: drivers/staging/sxg/sxghif.h:859: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Compilation' drivers/staging/sxg/sxg.c: In function 'sxg_transmit_packet': drivers/staging/sxg/sxg.c:1949: error: 'SXG_SGL_BUF_SIZE' undeclared (first use in this function) drivers/staging/sxg/sxg.c:1958: ...

+ Reply to Thread
Results 1 to 9 of 9

Thread: linux-next: build failure

  1. linux-next: build failure

    Hi Greg,

    Today's linux-next build (powerpc allyesconfig) failed like this:

    In file included from drivers/staging/sxg/sxg.c:77:
    drivers/staging/sxg/sxghif.h:859: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Compilation'
    drivers/staging/sxg/sxg.c: In function 'sxg_transmit_packet':
    drivers/staging/sxg/sxg.c:1949: error: 'SXG_SGL_BUF_SIZE' undeclared (first use in this function)
    drivers/staging/sxg/sxg.c:1958: error: implicit declaration of function 'SXG_SGL_BUFFER'
    drivers/staging/sxg/sxg.c:1958: warning: assignment makes pointer from integer without a cast
    drivers/staging/sxg/sxg.c: In function 'sxg_mcast_set_mask':
    drivers/staging/sxg/sxg.c:2846: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'u64'

    I applied the following patch.
    --
    Cheers,
    Stephen Rothwell sfr@canb.auug.org.au
    http://www.canb.auug.org.au/~sfr/

    From: Stephen Rothwell
    Date: Mon, 20 Oct 2008 22:59:18 +1100
    Subject: [PATCH] staging: sxg depends on X86

    sxghif.h has code that explicitly will not build fo other architecures.

    Signed-off-by: Stephen Rothwell
    ---
    drivers/staging/sxg/Kconfig | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/drivers/staging/sxg/Kconfig b/drivers/staging/sxg/Kconfig
    index 1ae3508..6e6cf0b 100644
    --- a/drivers/staging/sxg/Kconfig
    +++ b/drivers/staging/sxg/Kconfig
    @@ -1,6 +1,7 @@
    config SXG
    tristate "Alacritech SLIC Technology Non-Accelerated 10Gbe support"
    depends on PCI && NETDEV_10000
    + depends on X86
    default n
    help
    This driver supports the Alacritech SLIC Technology Non-Accelerated
    --
    1.5.6.5

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: linux-next: build failure

    On Mon, Oct 20, 2008 at 11:04:20PM +1100, Stephen Rothwell wrote:
    > Hi Greg,
    >
    > Today's linux-next build (powerpc allyesconfig) failed like this:
    >
    > In file included from drivers/staging/sxg/sxg.c:77:
    > drivers/staging/sxg/sxghif.h:859: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Compilation'
    > drivers/staging/sxg/sxg.c: In function 'sxg_transmit_packet':
    > drivers/staging/sxg/sxg.c:1949: error: 'SXG_SGL_BUF_SIZE' undeclared (first use in this function)
    > drivers/staging/sxg/sxg.c:1958: error: implicit declaration of function 'SXG_SGL_BUFFER'
    > drivers/staging/sxg/sxg.c:1958: warning: assignment makes pointer from integer without a cast
    > drivers/staging/sxg/sxg.c: In function 'sxg_mcast_set_mask':
    > drivers/staging/sxg/sxg.c:2846: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'u64'
    >
    > I applied the following patch.


    Ah, doh, sorry, I should have caught that. I'll go apply this to the
    tree, thanks.

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: linux-next: build failure

    On Mon, Oct 20, 2008 at 11:48 AM, Greg KH wrote:
    > On Mon, Oct 20, 2008 at 11:04:20PM +1100, Stephen Rothwell wrote:
    >> Hi Greg,
    >>
    >> Today's linux-next build (powerpc allyesconfig) failed like this:
    >>
    >> In file included from drivers/staging/sxg/sxg.c:77:
    >> drivers/staging/sxg/sxghif.h:859: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Compilation'
    >> drivers/staging/sxg/sxg.c: In function 'sxg_transmit_packet':
    >> drivers/staging/sxg/sxg.c:1949: error: 'SXG_SGL_BUF_SIZE' undeclared (first use in this function)
    >> drivers/staging/sxg/sxg.c:1958: error: implicit declaration of function 'SXG_SGL_BUFFER'
    >> drivers/staging/sxg/sxg.c:1958: warning: assignment makes pointer from integer without a cast
    >> drivers/staging/sxg/sxg.c: In function 'sxg_mcast_set_mask':
    >> drivers/staging/sxg/sxg.c:2846: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'u64'
    >>
    >> I applied the following patch.

    >
    > Ah, doh, sorry, I should have caught that. I'll go apply this to the
    > tree, thanks.


    Greg,

    The slicoss driver also from Alacritech looks like it needs a depends
    on X86 as well. Should the sxg and slicoss drivers from Alacritech be
    doing things like this (sxg/sxghif.h:851, slicoss/slicoss.c:960):

    #if defined(CONFIG_X86_64)

    ....

    #else
    Stop Compilation;
    #endif


    >
    > greg k-h
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/
    >

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: linux-next: build failure

    On Mon, Oct 20, 2008 at 12:33:29PM -0400, J.R. Mauro wrote:
    > On Mon, Oct 20, 2008 at 11:48 AM, Greg KH wrote:
    > > On Mon, Oct 20, 2008 at 11:04:20PM +1100, Stephen Rothwell wrote:
    > >> Hi Greg,
    > >>
    > >> Today's linux-next build (powerpc allyesconfig) failed like this:
    > >>
    > >> In file included from drivers/staging/sxg/sxg.c:77:
    > >> drivers/staging/sxg/sxghif.h:859: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Compilation'
    > >> drivers/staging/sxg/sxg.c: In function 'sxg_transmit_packet':
    > >> drivers/staging/sxg/sxg.c:1949: error: 'SXG_SGL_BUF_SIZE' undeclared (first use in this function)
    > >> drivers/staging/sxg/sxg.c:1958: error: implicit declaration of function 'SXG_SGL_BUFFER'
    > >> drivers/staging/sxg/sxg.c:1958: warning: assignment makes pointer from integer without a cast
    > >> drivers/staging/sxg/sxg.c: In function 'sxg_mcast_set_mask':
    > >> drivers/staging/sxg/sxg.c:2846: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'u64'
    > >>
    > >> I applied the following patch.

    > >
    > > Ah, doh, sorry, I should have caught that. I'll go apply this to the
    > > tree, thanks.

    >
    > Greg,
    >
    > The slicoss driver also from Alacritech looks like it needs a depends
    > on X86 as well. Should the sxg and slicoss drivers from Alacritech be
    > doing things like this (sxg/sxghif.h:851, slicoss/slicoss.c:960):


    Yes, it needs it too.

    thanks,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. patch staging-sxg-depends-on-x86.patch added to gregkh-2.6 tree


    This is a note to let you know that I've just added the patch titled

    Subject: Staging: sxg depends on X86
    Subject: linux-next: build failure

    to my gregkh-2.6 tree. Its filename is

    staging-sxg-depends-on-x86.patch

    This tree can be found at
    http://www.kernel.org/pub/linux/kern...h-2.6/patches/


    From sfr@canb.auug.org.au Mon Oct 20 13:45:45 2008
    From: Stephen Rothwell
    Date: Mon, 20 Oct 2008 22:59:18 +1100
    Subject: Staging: sxg depends on X86
    Subject: linux-next: build failure
    To: Greg KH
    Cc: linux-next@vger.kernel.org, Christopher Harrer , Michael Miles , LKML , Andrew Morton , linus
    Message-ID: <20081020230420.aa85f83b.sfr@canb.auug.org.au>

    From: Stephen Rothwell

    sxghif.h has code that explicitly will not build fo other architecures.

    Signed-off-by: Stephen Rothwell
    Signed-off-by: Greg Kroah-Hartman

    ---
    drivers/staging/sxg/Kconfig | 1 +
    drivers/staging/sxg/README | 1 +
    2 files changed, 2 insertions(+)

    --- a/drivers/staging/sxg/Kconfig
    +++ b/drivers/staging/sxg/Kconfig
    @@ -1,6 +1,7 @@
    config SXG
    tristate "Alacritech SLIC Technology Non-Accelerated 10Gbe support"
    depends on PCI && NETDEV_10000
    + depends on X86
    default n
    help
    This driver supports the Alacritech SLIC Technology Non-Accelerated
    --- a/drivers/staging/sxg/README
    +++ b/drivers/staging/sxg/README
    @@ -7,6 +7,7 @@ TODO:
    - remove wrappers
    - checkpatch.pl cleanups
    - new functionality that the card needs
    + - remove reliance on x86

    Please send patches to:
    Greg Kroah-Hartman


    Patches currently in gregkh-2.6 which might be from sfr@canb.auug.org.au are

    bad/battery-class-driver.patch
    staging/staging-sxg-depends-on-x86.patch
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  6. Re: linux-next: build failure

    On Mon, Oct 20, 2008 at 09:51:42AM -0700, Greg KH wrote:
    > On Mon, Oct 20, 2008 at 12:33:29PM -0400, J.R. Mauro wrote:
    > > On Mon, Oct 20, 2008 at 11:48 AM, Greg KH wrote:
    > > > On Mon, Oct 20, 2008 at 11:04:20PM +1100, Stephen Rothwell wrote:
    > > >> Hi Greg,
    > > >>
    > > >> Today's linux-next build (powerpc allyesconfig) failed like this:
    > > >>
    > > >> In file included from drivers/staging/sxg/sxg.c:77:
    > > >> drivers/staging/sxg/sxghif.h:859: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Compilation'
    > > >> drivers/staging/sxg/sxg.c: In function 'sxg_transmit_packet':
    > > >> drivers/staging/sxg/sxg.c:1949: error: 'SXG_SGL_BUF_SIZE' undeclared (first use in this function)
    > > >> drivers/staging/sxg/sxg.c:1958: error: implicit declaration of function 'SXG_SGL_BUFFER'
    > > >> drivers/staging/sxg/sxg.c:1958: warning: assignment makes pointer from integer without a cast
    > > >> drivers/staging/sxg/sxg.c: In function 'sxg_mcast_set_mask':
    > > >> drivers/staging/sxg/sxg.c:2846: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'u64'
    > > >>
    > > >> I applied the following patch.
    > > >
    > > > Ah, doh, sorry, I should have caught that. I'll go apply this to the
    > > > tree, thanks.

    > >
    > > Greg,
    > >
    > > The slicoss driver also from Alacritech looks like it needs a depends
    > > on X86 as well. Should the sxg and slicoss drivers from Alacritech be
    > > doing things like this (sxg/sxghif.h:851, slicoss/slicoss.c:960):

    >
    > Yes, it needs it too.


    Hm, it already has this dependancy. In drivers/staging/slicoss/Kconfig
    we have:
    config SLICOSS
    tristate "Alacritech Gigabit IS-NIC support"
    depends on PCI && X86 && NETDEV_1000

    So we should be fine here.

    thanks,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  7. patch staging-sxg-depends-on-x86.patch added to gregkh-2.6 tree


    This is a note to let you know that I've just added the patch titled

    Subject: Staging: sxg depends on X86
    Subject: linux-next: build failure

    to my gregkh-2.6 tree. Its filename is

    staging-sxg-depends-on-x86.patch

    This tree can be found at
    http://www.kernel.org/pub/linux/kern...h-2.6/patches/


    From sfr@canb.auug.org.au Mon Oct 20 13:45:45 2008
    From: Stephen Rothwell
    Date: Mon, 20 Oct 2008 22:59:18 +1100
    Subject: Staging: sxg depends on X86
    Subject: linux-next: build failure
    To: Greg KH
    Cc: linux-next@vger.kernel.org, Christopher Harrer , Michael Miles , LKML , Andrew Morton , linus
    Message-ID: <20081020230420.aa85f83b.sfr@canb.auug.org.au>

    From: Stephen Rothwell

    sxghif.h has code that explicitly will not build fo other architecures.

    Signed-off-by: Stephen Rothwell
    Signed-off-by: Greg Kroah-Hartman

    ---
    drivers/staging/sxg/Kconfig | 1 +
    drivers/staging/sxg/README | 1 +
    2 files changed, 2 insertions(+)

    --- a/drivers/staging/sxg/Kconfig
    +++ b/drivers/staging/sxg/Kconfig
    @@ -1,6 +1,7 @@
    config SXG
    tristate "Alacritech SLIC Technology Non-Accelerated 10Gbe support"
    depends on PCI && NETDEV_10000
    + depends on X86
    default n
    help
    This driver supports the Alacritech SLIC Technology Non-Accelerated
    --- a/drivers/staging/sxg/README
    +++ b/drivers/staging/sxg/README
    @@ -7,6 +7,7 @@ TODO:
    - remove wrappers
    - checkpatch.pl cleanups
    - new functionality that the card needs
    + - remove reliance on x86

    Please send patches to:
    Greg Kroah-Hartman


    Patches currently in gregkh-2.6 which might be from sfr@canb.auug.org.au are

    bad/battery-class-driver.patch
    staging/staging-sxg-depends-on-x86.patch
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  8. Re: linux-next: build failure

    Hi Greg,

    On Mon, 20 Oct 2008 08:48:57 -0700 Greg KH wrote:
    >
    > Ah, doh, sorry, I should have caught that. I'll go apply this to the
    > tree, thanks.


    Linus seems to have already applied it.

    --
    Cheers,
    Stephen Rothwell sfr@canb.auug.org.au
    http://www.canb.auug.org.au/~sfr/

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.9 (GNU/Linux)

    iEYEARECAAYFAkj9BsEACgkQjjKRsyhoI8y9UQCgvPZPlM9O2i veHWQ10j0dts7b
    EJwAoJipX0UTuA/Jur9klGRI246Ki4kw
    =+Qp8
    -----END PGP SIGNATURE-----


  9. Re: linux-next: build failure

    On Mon, Oct 20, 2008 at 01:47:50PM -0700, Greg KH wrote:
    > On Mon, Oct 20, 2008 at 09:51:42AM -0700, Greg KH wrote:
    > > On Mon, Oct 20, 2008 at 12:33:29PM -0400, J.R. Mauro wrote:
    > > > On Mon, Oct 20, 2008 at 11:48 AM, Greg KH wrote:
    > > > > On Mon, Oct 20, 2008 at 11:04:20PM +1100, Stephen Rothwell wrote:
    > > > >> Hi Greg,
    > > > >>
    > > > >> Today's linux-next build (powerpc allyesconfig) failed like this:
    > > > >>
    > > > >> In file included from drivers/staging/sxg/sxg.c:77:
    > > > >> drivers/staging/sxg/sxghif.h:859: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Compilation'
    > > > >> drivers/staging/sxg/sxg.c: In function 'sxg_transmit_packet':
    > > > >> drivers/staging/sxg/sxg.c:1949: error: 'SXG_SGL_BUF_SIZE' undeclared (first use in this function)
    > > > >> drivers/staging/sxg/sxg.c:1958: error: implicit declaration of function 'SXG_SGL_BUFFER'
    > > > >> drivers/staging/sxg/sxg.c:1958: warning: assignment makes pointer from integer without a cast
    > > > >> drivers/staging/sxg/sxg.c: In function 'sxg_mcast_set_mask':
    > > > >> drivers/staging/sxg/sxg.c:2846: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'u64'
    > > > >>
    > > > >> I applied the following patch.
    > > > >
    > > > > Ah, doh, sorry, I should have caught that. I'll go apply this to the
    > > > > tree, thanks.
    > > >
    > > > Greg,
    > > >
    > > > The slicoss driver also from Alacritech looks like it needs a depends
    > > > on X86 as well. Should the sxg and slicoss drivers from Alacritech be
    > > > doing things like this (sxg/sxghif.h:851, slicoss/slicoss.c:960):

    > >
    > > Yes, it needs it too.

    >
    > Hm, it already has this dependancy. In drivers/staging/slicoss/Kconfig
    > we have:
    > config SLICOSS
    > tristate "Alacritech Gigabit IS-NIC support"
    > depends on PCI && X86 && NETDEV_1000
    >
    > So we should be fine here.


    Sorry about that, had to pull from Linus's tree

    >
    > thanks,
    >
    > greg k-h

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread