[PATCH] mfd/wm8350: don't export static functions - Kernel

This is a discussion on [PATCH] mfd/wm8350: don't export static functions - Kernel ; Today's linux-next build (powerpc allyesconfig) failed like this: drivers/mfd/wm8350-core.c:1131: error: __ksymtab_wm8350_create_cache causes a section type conflict Caused by commit 89b4012befb1abca5e86d232bc0e2a797b0d9825 ("mfd: Core support for the WM8350 AudioPlus PMIC"). wm8350_create_cache is not used elsewhere, so remove the EXPORT_SYMBOL. Signed-off-by: Stephen Rothwell ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: [PATCH] mfd/wm8350: don't export static functions

  1. [PATCH] mfd/wm8350: don't export static functions

    Today's linux-next build (powerpc allyesconfig) failed like this:

    drivers/mfd/wm8350-core.c:1131: error: __ksymtab_wm8350_create_cache causes a section type conflict

    Caused by commit 89b4012befb1abca5e86d232bc0e2a797b0d9825 ("mfd: Core
    support for the WM8350 AudioPlus PMIC"). wm8350_create_cache is not used
    elsewhere, so remove the EXPORT_SYMBOL.

    Signed-off-by: Stephen Rothwell
    ---
    drivers/mfd/wm8350-core.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
    index bf87f67..fbe22fb 100644
    --- a/drivers/mfd/wm8350-core.c
    +++ b/drivers/mfd/wm8350-core.c
    @@ -1128,7 +1128,6 @@ static int wm8350_create_cache(struct wm8350 *wm8350, int mode)
    out:
    return ret;
    }
    -EXPORT_SYMBOL_GPL(wm8350_create_cache);

    /*
    * Register a client device. This is non-fatal since there is no need to
    --
    1.5.6.5

    --
    Cheers,
    Stephen Rothwell sfr@canb.auug.org.au
    http://www.canb.auug.org.au/~sfr/
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] mfd/wm8350: don't export static functions

    On Thu, Oct 16, 2008 at 08:47:54PM +1100, Stephen Rothwell wrote:
    > Today's linux-next build (powerpc allyesconfig) failed like this:


    > drivers/mfd/wm8350-core.c:1131: error: __ksymtab_wm8350_create_cache causes a section type conflict


    > Caused by commit 89b4012befb1abca5e86d232bc0e2a797b0d9825 ("mfd: Core
    > support for the WM8350 AudioPlus PMIC"). wm8350_create_cache is not used
    > elsewhere, so remove the EXPORT_SYMBOL.


    Acked-by: Mark Brown
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] mfd/wm8350: don't export static functions

    Hi Mark,

    On Thu, 16 Oct 2008 13:04:16 +0100 Mark Brown wrote:
    >
    > On Thu, Oct 16, 2008 at 08:47:54PM +1100, Stephen Rothwell wrote:
    > > Today's linux-next build (powerpc allyesconfig) failed like this:

    >
    > > drivers/mfd/wm8350-core.c:1131: error: __ksymtab_wm8350_create_cache causes a section type conflict

    >
    > > Caused by commit 89b4012befb1abca5e86d232bc0e2a797b0d9825 ("mfd: Core
    > > support for the WM8350 AudioPlus PMIC"). wm8350_create_cache is not used
    > > elsewhere, so remove the EXPORT_SYMBOL.

    >
    > Acked-by: Mark Brown


    I thought that this had been applied, but I have had to apply it to my
    tree today again.

    --
    Cheers,
    Stephen Rothwell sfr@canb.auug.org.au
    http://www.canb.auug.org.au/~sfr/

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.9 (GNU/Linux)

    iEYEARECAAYFAkj+8uAACgkQjjKRsyhoI8xNjwCdETtkt2Q6Pj aPlVDF/CxyyqLy
    mEMAn2DX14shHWmFTfYwge1Tv6Q2KbDt
    =Mztl
    -----END PGP SIGNATURE-----


  4. Re: [PATCH] mfd/wm8350: don't export static functions

    On Wed, Oct 22, 2008 at 08:31:12PM +1100, Stephen Rothwell wrote:

    > I thought that this had been applied, but I have had to apply it to my
    > tree today again.


    Samuel doesn't seem to have picked it up (though looking at the CC list
    you've not sent it to him). I'm going to push another batch of stuff to
    him later today, hopefully he will pick it up then.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [PATCH] mfd/wm8350: don't export static functions

    Hi Mark,

    On Wed, 22 Oct 2008 10:37:22 +0100 Mark Brown wrote:
    >
    > On Wed, Oct 22, 2008 at 08:31:12PM +1100, Stephen Rothwell wrote:
    >
    > > I thought that this had been applied, but I have had to apply it to my
    > > tree today again.

    >
    > Samuel doesn't seem to have picked it up (though looking at the CC list
    > you've not sent it to him). I'm going to push another batch of stuff to
    > him later today, hopefully he will pick it up then.


    OK, thanks.

    --
    Cheers,
    Stephen Rothwell sfr@canb.auug.org.au
    http://www.canb.auug.org.au/~sfr/

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.9 (GNU/Linux)

    iEYEARECAAYFAkj++FAACgkQjjKRsyhoI8zkMACeOzMeKulLpo aF0yQ+Zcq4JB8o
    wSQAniHf/kLZ8yyOnahwVeKSRClcAqJT
    =Q8bw
    -----END PGP SIGNATURE-----


+ Reply to Thread