powerpc allmodconfig - Kernel

This is a discussion on powerpc allmodconfig - Kernel ; arch/powerpc/kernel/setup_64.c:447:5: warning: "kernstart_addr" is not defined arch/powerpc/kernel/setup_64.c:447:5: warning: "kernstart_addr" is not defined kernel/resource.c: In function '__reserve_region_with_split': kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t' kernel/resource.c:554: warning: format '%llx' expects type 'long long ...

+ Reply to Thread
Page 1 of 2 1 2 LastLast
Results 1 to 20 of 31

Thread: powerpc allmodconfig

  1. powerpc allmodconfig



    arch/powerpc/kernel/setup_64.c:447:5: warning: "kernstart_addr" is not defined
    arch/powerpc/kernel/setup_64.c:447:5: warning: "kernstart_addr" is not defined


    kernel/resource.c: In function '__reserve_region_with_split':
    kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t'
    kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
    kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 6 has type 'resource_size_t'
    kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 7 has type 'resource_size_t'


    sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    lib/debugobjects.c:58: warning: 'obj_states' defined but not used
    net/dccp/options.c: In function 'dccp_parse_options':
    net/dccp/options.c:67: warning: 'value' may be used uninitialized in this function


    sound/soc/codecs/tlv320aic23.c: In function 'tlv320aic23_write':
    sound/soc/codecs/tlv320aic23.c:104: warning: passing argument 2 of 'codec->hw_write' makes pointer from integer without a cast
    sound/soc/codecs/tlv320aic23.c: In function 'tlv320aic23_set_dai_sysclk':
    sound/soc/codecs/tlv320aic23.c:424: warning: unused variable 'codec'


    drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios':
    drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax'
    drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled':
    drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has'
    drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function)
    drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once
    drivers/dma/ioat_dca.c:91: error: for each function it appears in.)
    drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag':
    drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id'

    fs/ext4/balloc.c: In function 'ext4_claim_free_blocks':
    fs/ext4/balloc.c:607: warning: format '%lld' expects type 'long long int', but argument 2 has type 's64'
    fs/ext4/inode.c: In function 'ext4_print_free_blocks':
    fs/ext4/inode.c:1822: warning: format '%lld' expects type 'long long int', but argument 2 has type 's64'
    fs/ext4/inode.c:1824: warning: format '%lld' expects type 'long long int', but argument 2 has type 's64'

    net/sched/sch_generic.c: In function 'dev_watchdog':
    net/sched/sch_generic.c:224: warning: unused variable 'drivername'


    net/mac80211/rc80211_minstrel_debugfs.c: In function 'minstrel_stats_open':
    net/mac80211/rc80211_minstrel_debugfs.c:98: warning: format '%8llu' expects type 'long long unsigned int', but argument 11 has type 'u64'
    net/mac80211/rc80211_minstrel_debugfs.c:98: warning: format '%8llu' expects type 'long long unsigned int', but argument 12 has type 'u64'
    net/mac80211/rc80211_minstrel_debugfs.c:98: warning: format '%8llu' expects type 'long long unsigned int', but argument 11 has type 'u64'
    net/mac80211/rc80211_minstrel_debugfs.c:98: warning: format '%8llu' expects type 'long long unsigned int', but argument 12 has type 'u64'
    net/mac80211/rc80211_minstrel_debugfs.c: At top level:
    net/mac80211/rc80211_minstrel_debugfs.c:145: warning: initialization from incompatible pointer type

    drivers/ide/pci/scc_pata.c: In function 'init_hwif_scc':
    drivers/ide/pci/scc_pata.c:846: warning: unused variable 'ports'
    drivers/ide/pci/hpt366.c: In function 'init_hwif_hpt366':
    drivers/ide/pci/hpt366.c:1292: warning: unused variable 'dev'

    include/linux/ucb1400.h:139: warning: 'ucb1400_adc_read' defined but not used

    drivers/mtd/devices/docprobe.c:80:2: warning: #warning Unknown architecture for DiskOnChip. No default probe locations defined

    fs/ocfs2/xattr.c: In function 'ocfs2_xattr_index_block_find':
    fs/ocfs2/xattr.c:2400: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:2400: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:2400: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c: In function 'ocfs2_iterate_xattr_buckets':
    fs/ocfs2/xattr.c:2424: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:2424: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:2424: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:2443: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:2443: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:2443: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c: In function 'ocfs2_xattr_create_index_block':
    fs/ocfs2/xattr.c:2779: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:2779: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:2779: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c: In function 'ocfs2_defrag_xattr_bucket':
    fs/ocfs2/xattr.c:2942: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:2942: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:2942: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c: In function 'ocfs2_mv_xattr_bucket_cross_cluster':
    fs/ocfs2/xattr.c:3060: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3060: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:3060: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3060: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:3060: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3060: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c: In function 'ocfs2_half_xattr_bucket':
    fs/ocfs2/xattr.c:3189: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3189: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:3189: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3189: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:3189: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3189: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c: In function 'ocfs2_cp_xattr_bucket':
    fs/ocfs2/xattr.c:3360: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3360: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:3360: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3360: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:3360: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3360: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c: In function 'ocfs2_cp_xattr_cluster':
    fs/ocfs2/xattr.c:3431: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3431: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:3431: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3431: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:3431: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3431: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c: In function 'ocfs2_adjust_xattr_cross_cluster':
    fs/ocfs2/xattr.c:3561: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3561: warning: format '%llu' expects type 'long long unsigned int', but argument 8 has type 'u64'
    fs/ocfs2/xattr.c:3561: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3561: warning: format '%llu' expects type 'long long unsigned int', but argument 8 has type 'u64'
    fs/ocfs2/xattr.c:3561: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3561: warning: format '%llu' expects type 'long long unsigned int', but argument 8 has type 'u64'
    fs/ocfs2/xattr.c: In function 'ocfs2_add_new_xattr_cluster':
    fs/ocfs2/xattr.c:3629: warning: format '%llu' expects type 'long long unsigned int', but argument 8 has type 'u64'
    fs/ocfs2/xattr.c:3629: warning: format '%llu' expects type 'long long unsigned int', but argument 8 has type 'u64'
    fs/ocfs2/xattr.c:3629: warning: format '%llu' expects type 'long long unsigned int', but argument 8 has type 'u64'
    fs/ocfs2/xattr.c:3718: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:3718: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c:3718: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    fs/ocfs2/xattr.c: In function 'ocfs2_extend_xattr_bucket':
    fs/ocfs2/xattr.c:3763: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3763: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'
    fs/ocfs2/xattr.c:3763: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'u64'

    sound/pci/hda/patch_sigmatel.c: In function 'stac92xx_parse_auto_config':
    sound/pci/hda/patch_sigmatel.c:2819: warning: 'nid' may be used uninitialized in this function

    drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
    drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl'
    drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
    drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel'
    drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
    drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap'
    drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast
    drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'
    make[2]: [drivers/rtc/rtc-ds1286.o] Error 1 (ignored)



    drivers/serial/serial_txx9.c: In function 'serial_txx9_probe':
    drivers/serial/serial_txx9.c:1041: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'long unsigned int'



    drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
    drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb'
    drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb'
    drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
    drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap'
    drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast
    drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'



    drivers/net/ibm_newemac/mal.c: In function 'mal_txeob':
    drivers/net/ibm_newemac/mal.c:284: error: implicit declaration of function 'mtdcri'
    drivers/net/ibm_newemac/mal.c:284: error: 'SDR0' undeclared (first use in this function)
    drivers/net/ibm_newemac/mal.c:284: error: (Each undeclared identifier is reported only once
    drivers/net/ibm_newemac/mal.c:284: error: for each function it appears in.)
    drivers/net/ibm_newemac/mal.c:285: error: implicit declaration of function 'mfdcri'
    drivers/net/ibm_newemac/mal.c: In function 'mal_rxeob':
    drivers/net/ibm_newemac/mal.c:302: error: 'SDR0' undeclared (first use in this function)



    drivers/media/dvb/frontends/cx24116.c: In function 'cx24116_load_firmware':
    drivers/media/dvb/frontends/cx24116.c:573: warning: passing argument 3 of 'cx24116_writeregN' discards qualifiers from pointer target type



    drivers/video/aty/aty128fb.c: In function 'aty128_decode_var':
    drivers/video/aty/aty128fb.c:1520: warning: 'pll.post_divider' may be used uninitialized in this function



    drivers/net/wireless/libertas_tf/if_usb.c: In function '__if_usb_submit_rx_urb':
    drivers/net/wireless/libertas_tf/if_usb.c:334: warning: cast to pointer from integer of different size


    drivers/media/dvb/frontends/z0194a.h:85: warning: 'sharp_z0194a_config' defined but not used
    drivers/media/video/gspca/ov519.c: In function 'mode_init_ov_sensor_regs':
    drivers/media/video/gspca/ov519.c:1670: warning: comparison is always true due to limited range of data type



    Documentation/video4linux/v4lgrab.c: In function 'main':
    Documentation/video4linux/v4lgrab.c:184: warning: 'src_depth' is used uninitialized in this function
    Documentation/video4linux/v4lgrab.c:99: warning: 'b' may be used uninitialized in this function
    Documentation/video4linux/v4lgrab.c:99: warning: 'g' may be used uninitialized in this function
    Documentation/video4linux/v4lgrab.c:99: warning: 'r' may be used uninitialized in this function
    Documentation/accounting/getdelays.c: In function 'main':
    Documentation/accounting/getdelays.c:249: warning: 'cmd_type' may be used uninitialized in this function
    Documentation/connector/cn_test.c:45: warning: 'cn_test_want_notify' defined but not used


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: powerpc allmodconfig

    From: Andrew Morton
    Date: Wed, 15 Oct 2008 21:33:37 -0700

    > kernel/resource.c: In function '__reserve_region_with_split':
    > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t'
    > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
    > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 6 has type 'resource_size_t'
    > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 7 has type 'resource_size_t'


    Known issue, Ben wants to add a new variant of %pX in order to print resources so that
    resource_size_t vs. unsigned long stuff doesn't matter like this any more.

    > net/dccp/options.c: In function 'dccp_parse_options':
    > net/dccp/options.c:67: warning: 'value' may be used uninitialized in this function


    Known issue, not trivial to fix, gcc is just being incredibly silly here as it
    can't see all of the control flow.

    > drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios':
    > drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax'
    > drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled':
    > drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has'
    > drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function)
    > drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once
    > drivers/dma/ioat_dca.c:91: error: for each function it appears in.)
    > drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag':
    > drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id'


    Known issue. I tried to ping Jeff Garzik about doing a driver bug fix run in
    order to fix this, but he hasn't shown any signs of life.

    So I'll do it myself later tonight. :-/

    > net/sched/sch_generic.c: In function 'dev_watchdog':
    > net/sched/sch_generic.c:224: warning: unused variable 'drivername'


    Sucky, if WARN_ONCE() evaluates to nothing the sprintf() string buffer
    on the stack looks unused.

    > drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
    > drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl'
    > drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
    > drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel'
    > drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
    > drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap'
    > drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast
    > drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'


    Missing asm/io.h include.

    > drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
    > drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb'
    > drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb'
    > drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
    > drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap'
    > drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast
    > drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'


    Likewise.

    > drivers/net/wireless/libertas_tf/if_usb.c: In function '__if_usb_submit_rx_urb':
    > drivers/net/wireless/libertas_tf/if_usb.c:334: warning: cast to pointer from integer of different size


    I've seen this one on sparc64 too, I think the arg is totally unused in the end
    for this callback control flow and we can just use NULL or zero instead.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: powerpc allmodconfig

    Some comments for some of these...

    On Wed, 2008-10-15 at 21:33 -0700, Andrew Morton wrote:

    > kernel/resource.c: In function '__reserve_region_with_split':
    > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t'
    > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
    > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 6 has type 'resource_size_t'
    > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 7 has type 'resource_size_t'


    This is a generic code bug, I sent a patch for it a day or two ago. (ie
    those are real bugs on 32-bit resource_size_t)

    > drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios':
    > drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax'
    > drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled':
    > drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has'
    > drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function)
    > drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once
    > drivers/dma/ioat_dca.c:91: error: for each function it appears in.)
    > drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag':
    > drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id'


    Looks like this driver should depend on X86 :-)

    > fs/ext4/balloc.c: In function 'ext4_claim_free_blocks':
    > fs/ext4/balloc.c:607: warning: format '%lld' expects type 'long long int', but argument 2 has type 's64'
    > fs/ext4/inode.c: In function 'ext4_print_free_blocks':
    > fs/ext4/inode.c:1822: warning: format '%lld' expects type 'long long int', but argument 2 has type 's64'
    > fs/ext4/inode.c:1824: warning: format '%lld' expects type 'long long int', but argument 2 has type 's64'


    The above are unfortunate but at least aren't bugs per-se, just
    annoying. Should be fixable with casts. Ted ?

    > net/mac80211/rc80211_minstrel_debugfs.c: In function 'minstrel_stats_open':
    > net/mac80211/rc80211_minstrel_debugfs.c:98: warning: format '%8llu' expects type 'long long unsigned int', but argument 11 has type 'u64'
    > net/mac80211/rc80211_minstrel_debugfs.c:98: warning: format '%8llu' expects type 'long long unsigned int', but argument 12 has type 'u64'
    > net/mac80211/rc80211_minstrel_debugfs.c:98: warning: format '%8llu' expects type 'long long unsigned int', but argument 11 has type 'u64'
    > net/mac80211/rc80211_minstrel_debugfs.c:98: warning: format '%8llu' expects type 'long long unsigned int', but argument 12 has type 'u64'
    > net/mac80211/rc80211_minstrel_debugfs.c: At top level:
    > net/mac80211/rc80211_minstrel_debugfs.c:145: warning: initialization from incompatible pointer type


    Same.

    > fs/ocfs2/xattr.c: In function 'ocfs2_xattr_index_block_find':
    > fs/ocfs2/xattr.c:2400: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'
    > fs/ocfs2/xattr.c:2400: warning: format '%llu' expects type 'long long unsigned int', but argument 7 has type 'u64'


    .../...

    same

    >
    > sound/pci/hda/patch_sigmatel.c: In function 'stac92xx_parse_auto_config':
    > sound/pci/hda/patch_sigmatel.c:2819: warning: 'nid' may be used uninitialized in this function
    >
    > drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
    > drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl'
    > drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
    > drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel'
    > drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
    > drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap'
    > drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast
    > drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'
    > make[2]: [drivers/rtc/rtc-ds1286.o] Error 1 (ignored)


    Missing #include ?

    > drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
    > drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb'
    > drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb'
    > drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
    > drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap'
    > drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast
    > drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'


    Same ?

    > drivers/net/ibm_newemac/mal.c: In function 'mal_txeob':
    > drivers/net/ibm_newemac/mal.c:284: error: implicit declaration of function 'mtdcri'
    > drivers/net/ibm_newemac/mal.c:284: error: 'SDR0' undeclared (first use in this function)
    > drivers/net/ibm_newemac/mal.c:284: error: (Each undeclared identifier is reported only once
    > drivers/net/ibm_newemac/mal.c:284: error: for each function it appears in.)
    > drivers/net/ibm_newemac/mal.c:285: error: implicit declaration of function 'mfdcri'
    > drivers/net/ibm_newemac/mal.c: In function 'mal_rxeob':
    > drivers/net/ibm_newemac/mal.c:302: error: 'SDR0' undeclared (first use in this function)


    That's annoying, I'll have a look.

    > drivers/net/wireless/libertas_tf/if_usb.c: In function '__if_usb_submit_rx_urb':
    > drivers/net/wireless/libertas_tf/if_usb.c:334: warning: cast to pointer from integer of different size


    Yuck !

    I'll look at the EMAC one and maybe some more tomorrow if nobody beats
    me to it.

    Cheers,
    Ben.


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: powerpc allmodconfig

    On Wed, 2008-10-15 at 22:02 -0700, David Miller wrote:
    > From: Andrew Morton
    > Date: Wed, 15 Oct 2008 21:33:37 -0700
    >
    > > kernel/resource.c: In function '__reserve_region_with_split':
    > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t'
    > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
    > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 6 has type 'resource_size_t'
    > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 7 has type 'resource_size_t'

    >
    > Known issue, Ben wants to add a new variant of %pX in order to print resources so that
    > resource_size_t vs. unsigned long stuff doesn't matter like this any more.


    Actually, I was told Linus had one and I've been trying to dig it out...

    Oh well, I may as well dig my own old one.

    Cheers,
    Ben.


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: powerpc allmodconfig

    At Wed, 15 Oct 2008 21:33:37 -0700,
    Andrew Morton wrote:
    >
    > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)


    These are definitions of deprecated interfaces.
    We can remove it in 2.6.29. If we don't want to be conservative, it
    can be removed in 2.6.28, too.

    > sound/soc/codecs/tlv320aic23.c: In function 'tlv320aic23_write':
    > sound/soc/codecs/tlv320aic23.c:104: warning: passing argument 2 of 'codec->hw_write' makes pointer from integer without a cast
    > sound/soc/codecs/tlv320aic23.c: In function 'tlv320aic23_set_dai_sysclk':
    > sound/soc/codecs/tlv320aic23.c:424: warning: unused variable 'codec'


    The fix was in the pending pull request.

    > sound/pci/hda/patch_sigmatel.c: In function 'stac92xx_parse_auto_config':
    > sound/pci/hda/patch_sigmatel.c:2819: warning: 'nid' may be used uninitialized in this function


    Ditto.


    thanks,

    Takashi
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  6. Re: powerpc allmodconfig


    On Wed, 2008-10-15 at 22:02 -0700, David Miller wrote:
    > > drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios':
    > > drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax'
    > > drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled':
    > > drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has'
    > > drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function)
    > > drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once
    > > drivers/dma/ioat_dca.c:91: error: for each function it appears in.)
    > > drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag':
    > > drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id'

    >
    > Known issue. I tried to ping Jeff Garzik about doing a driver bug fix run in
    > order to fix this, but he hasn't shown any signs of life.
    >
    > So I'll do it myself later tonight. :-/
    >

    The following seems to fix this up...

    ---snip--->
    ixgbe, myri10ge: INTEL_IOATDMA can only be selected when X86=y

    From: Dan Williams

    The INTEL_IOATDMA symbol depends on x86. 'select' ignores this
    dependency.

    Cc: Brice Goglin
    Cc: Jesse Brandeburg
    Signed-off-by: Dan Williams
    ---

    drivers/net/Kconfig | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)


    diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
    index 1d8af33..84983f8 100644
    --- a/drivers/net/Kconfig
    +++ b/drivers/net/Kconfig
    @@ -2410,7 +2410,7 @@ config IXGBE
    tristate "Intel(R) 10GbE PCI Express adapters support"
    depends on PCI && INET
    select INET_LRO
    - select INTEL_IOATDMA
    + select INTEL_IOATDMA if X86
    ---help---
    This driver supports Intel(R) 10GbE PCI Express family of
    adapters. For more information on how to identify your adapter, go
    @@ -2462,7 +2462,7 @@ config MYRI10GE
    select FW_LOADER
    select CRC32
    select INET_LRO
    - select INTEL_IOATDMA
    + select INTEL_IOATDMA if X86
    ---help---
    This driver supports Myricom Myri-10G Dual Protocol interface in
    Ethernet mode. If the eeprom on your board is not recent enough,


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  7. Re: powerpc allmodconfig

    Dan Williams wrote:
    > On Wed, 2008-10-15 at 22:02 -0700, David Miller wrote:
    >
    >>> drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios':
    >>> drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax'
    >>> drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled':
    >>> drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has'
    >>> drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function)
    >>> drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once
    >>> drivers/dma/ioat_dca.c:91: error: for each function it appears in.)
    >>> drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag':
    >>> drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id'
    >>>

    >> Known issue. I tried to ping Jeff Garzik about doing a driver bug fix run in
    >> order to fix this, but he hasn't shown any signs of life.
    >>
    >> So I'll do it myself later tonight. :-/
    >>
    >>

    > The following seems to fix this up...
    >
    > ---snip--->
    > ixgbe, myri10ge: INTEL_IOATDMA can only be selected when X86=y
    >


    There's already a completely different fix queued in netdev patchworks
    (for myri10ge only right now, to be duplicated for Intel drivers). The
    idea is to stop having almost-unrelated drivers select each other
    directly, let people select which drivers they really want, and have
    Kconfig handle modules/builtin-stuff correctly. See
    http://patchwork.ozlabs.org/patch/4506/

    Brice

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  8. Re: powerpc allmodconfig

    From: Brice Goglin
    Date: Thu, 16 Oct 2008 08:55:08 +0200

    > Dan Williams wrote:
    > > On Wed, 2008-10-15 at 22:02 -0700, David Miller wrote:
    > >
    > >>> drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios':
    > >>> drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax'
    > >>> drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled':
    > >>> drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has'
    > >>> drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function)
    > >>> drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once
    > >>> drivers/dma/ioat_dca.c:91: error: for each function it appears in.)
    > >>> drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag':
    > >>> drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id'
    > >>>
    > >> Known issue. I tried to ping Jeff Garzik about doing a driver bug fix run in
    > >> order to fix this, but he hasn't shown any signs of life.
    > >>
    > >> So I'll do it myself later tonight. :-/
    > >>
    > >>

    > > The following seems to fix this up...
    > >
    > > ---snip--->
    > > ixgbe, myri10ge: INTEL_IOATDMA can only be selected when X86=y
    > >

    >
    > There's already a completely different fix queued in netdev patchworks
    > (for myri10ge only right now, to be duplicated for Intel drivers). The
    > idea is to stop having almost-unrelated drivers select each other
    > directly, let people select which drivers they really want, and have
    > Kconfig handle modules/builtin-stuff correctly. See
    > http://patchwork.ozlabs.org/patch/4506/


    Right, my plan was to duplicate this for the other drivers.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  9. Re: powerpc allmodconfig

    On Wed, 15 Oct 2008, David Miller wrote:
    > > kernel/resource.c: In function '__reserve_region_with_split':
    > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t'
    > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
    > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 6 has type 'resource_size_t'
    > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 7 has type 'resource_size_t'

    >
    > Known issue, Ben wants to add a new variant of %pX in order to print resources so that
    > resource_size_t vs. unsigned long stuff doesn't matter like this any more.


    Will still give a warning, as resource_size_t is not a pointer.

    > > drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
    > > drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl'
    > > drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
    > > drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel'
    > > drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
    > > drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap'
    > > drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast
    > > drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'

    >
    > Missing asm/io.h include.


    Nah, ;-)

    > > drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
    > > drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb'
    > > drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb'
    > > drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
    > > drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap'
    > > drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast
    > > drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'

    >
    > Likewise.


    Already sent a patch for these two...

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  10. Re: powerpc allmodconfig

    On Thu, Oct 16, 2008 at 07:57:29AM +0200, Takashi Iwai wrote:
    > At Wed, 15 Oct 2008 21:33:37 -0700,
    > Andrew Morton wrote:
    > >
    > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)

    >
    > These are definitions of deprecated interfaces.
    > We can remove it in 2.6.29. If we don't want to be conservative, it
    > can be removed in 2.6.28, too.
    >...


    Since it's an in-kernel API there's no reason to keep it once there are
    no users left.

    But currently sound/soc/at32/playpaq_wm8510.c still seems to use it.

    > thanks,
    >
    > Takashi


    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  11. Re: powerpc allmodconfig

    From: Geert Uytterhoeven
    Date: Thu, 16 Oct 2008 09:31:29 +0200 (CEST)

    > On Wed, 15 Oct 2008, David Miller wrote:
    > > > kernel/resource.c: In function '__reserve_region_with_split':
    > > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t'
    > > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
    > > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 6 has type 'resource_size_t'
    > > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 7 has type 'resource_size_t'

    > >
    > > Known issue, Ben wants to add a new variant of %pX in order to print resources so that
    > > resource_size_t vs. unsigned long stuff doesn't matter like this any more.

    >
    > Will still give a warning, as resource_size_t is not a pointer.


    The idea is to pass in a pointer to the resource struct,
    and the %pX variant specified says what part to print.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  12. Re: powerpc allmodconfig

    David Miller writes:

    >> net/dccp/options.c: In function 'dccp_parse_options':
    >> net/dccp/options.c:67: warning: 'value' may be used uninitialized in this function

    >
    > Known issue, not trivial to fix, gcc is just being incredibly silly here as it
    > can't see all of the control flow.


    Seems to be fixed in gcc 4.3. It actually needs a pretty complete value
    tracking to get right.

    Andreas.

    --
    Andreas Schwab, SuSE Labs, schwab@suse.de
    SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
    PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
    "And now for something completely different."
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  13. Re: powerpc allmodconfig

    At Thu, 16 Oct 2008 10:38:36 +0300,
    Adrian Bunk wrote:
    >
    > On Thu, Oct 16, 2008 at 07:57:29AM +0200, Takashi Iwai wrote:
    > > At Wed, 15 Oct 2008 21:33:37 -0700,
    > > Andrew Morton wrote:
    > > >
    > > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    > > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)

    > >
    > > These are definitions of deprecated interfaces.
    > > We can remove it in 2.6.29. If we don't want to be conservative, it
    > > can be removed in 2.6.28, too.
    > >...

    >
    > Since it's an in-kernel API there's no reason to keep it once there are
    > no users left.


    Right. But, IMO, now is no suitable time.
    A thing like API removal should have been tested in linux-next, and we
    had plenty of time indeed for 2.6.28.

    > But currently sound/soc/at32/playpaq_wm8510.c still seems to use it.


    Yep, but don't be bothered to try to create a patch for that.
    There will be a unification patch for both at32 and at91, so clean-ups
    will be applied anyway later.


    thanks,

    Takashi
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  14. Re: powerpc allmodconfig

    On Thu, 16 Oct 2008, David Miller wrote:
    > From: Geert Uytterhoeven
    > Date: Thu, 16 Oct 2008 09:31:29 +0200 (CEST)
    >
    > > On Wed, 15 Oct 2008, David Miller wrote:
    > > > > kernel/resource.c: In function '__reserve_region_with_split':
    > > > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t'
    > > > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
    > > > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 6 has type 'resource_size_t'
    > > > > kernel/resource.c:554: warning: format '%llx' expects type 'long long unsigned int', but argument 7 has type 'resource_size_t'
    > > >
    > > > Known issue, Ben wants to add a new variant of %pX in order to print resources so that
    > > > resource_size_t vs. unsigned long stuff doesn't matter like this any more.

    > >
    > > Will still give a warning, as resource_size_t is not a pointer.

    >
    > The idea is to pass in a pointer to the resource struct,
    > and the %pX variant specified says what part to print.


    Neat! So we can also have a separate variant to print the resource
    range.

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  15. Re: powerpc allmodconfig

    On Thu, Oct 16, 2008 at 09:57:11AM +0200, Takashi Iwai wrote:
    > At Thu, 16 Oct 2008 10:38:36 +0300,
    > Adrian Bunk wrote:
    > >
    > > On Thu, Oct 16, 2008 at 07:57:29AM +0200, Takashi Iwai wrote:
    > > > At Wed, 15 Oct 2008 21:33:37 -0700,
    > > > Andrew Morton wrote:
    > > > >
    > > > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    > > > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    > > >
    > > > These are definitions of deprecated interfaces.
    > > > We can remove it in 2.6.29. If we don't want to be conservative, it
    > > > can be removed in 2.6.28, too.
    > > >...

    > >
    > > Since it's an in-kernel API there's no reason to keep it once there are
    > > no users left.

    >
    > Right. But, IMO, now is no suitable time.
    > A thing like API removal should have been tested in linux-next, and we
    > had plenty of time indeed for 2.6.28.
    >...


    A grep through the tree and one test compile that covers
    sound/soc/soc-dapm.c should be enough testing.

    And having it then in -next once should be enough to discover if someone
    wrongly added a new user.

    I have removed many functions in the kernel, and there isn't much that
    can go wrong - even adding a PCI ID to a driver has a bigger risk of
    introducing a regression.

    > thanks,
    >
    > Takashi


    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  16. Re: powerpc allmodconfig

    At Thu, 16 Oct 2008 11:21:57 +0300,
    Adrian Bunk wrote:
    >
    > On Thu, Oct 16, 2008 at 09:57:11AM +0200, Takashi Iwai wrote:
    > > At Thu, 16 Oct 2008 10:38:36 +0300,
    > > Adrian Bunk wrote:
    > > >
    > > > On Thu, Oct 16, 2008 at 07:57:29AM +0200, Takashi Iwai wrote:
    > > > > At Wed, 15 Oct 2008 21:33:37 -0700,
    > > > > Andrew Morton wrote:
    > > > > >
    > > > > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    > > > > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    > > > >
    > > > > These are definitions of deprecated interfaces.
    > > > > We can remove it in 2.6.29. If we don't want to be conservative, it
    > > > > can be removed in 2.6.28, too.
    > > > >...
    > > >
    > > > Since it's an in-kernel API there's no reason to keep it once there are
    > > > no users left.

    > >
    > > Right. But, IMO, now is no suitable time.
    > > A thing like API removal should have been tested in linux-next, and we
    > > had plenty of time indeed for 2.6.28.
    > >...

    >
    > A grep through the tree and one test compile that covers
    > sound/soc/soc-dapm.c should be enough testing.
    >
    > And having it then in -next once should be enough to discover if someone
    > wrongly added a new user.


    My point is the time for removal. The API changes should have been
    done in the merge window, and it should have been tested *before* the
    merge window.

    > I have removed many functions in the kernel, and there isn't much that
    > can go wrong - even adding a PCI ID to a driver has a bigger risk of
    > introducing a regression.


    Yeah, IMHO, adding PCI IDs blindly at the late stage should be
    avoided, too, although many people love that.


    thanks,

    Takashi
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  17. Re: powerpc allmodconfig

    On Wed, Oct 15, 2008 at 09:33:37PM -0700, Andrew Morton wrote:

    > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)


    I should submit the patch to remove this now that 2.6.27 is out - the
    warnings are generated by EXPORT_SYMBOL_GPL() - I couldn't see a way to
    mark the function as deprecated without removing the export.

    > sound/soc/codecs/tlv320aic23.c: In function 'tlv320aic23_write':
    > sound/soc/codecs/tlv320aic23.c:104: warning: passing argument 2 of 'codec->hw_write' makes pointer from integer without a cast
    > sound/soc/codecs/tlv320aic23.c: In function 'tlv320aic23_set_dai_sysclk':
    > sound/soc/codecs/tlv320aic23.c:424: warning: unused variable 'codec'


    The author already provided a patch to fix these. Takashi has sent a
    pull request to Linus including that already, IIRC.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  18. Re: powerpc allmodconfig

    On Thu, Oct 16, 2008 at 10:43:33AM +0200, Takashi Iwai wrote:
    > At Thu, 16 Oct 2008 11:21:57 +0300,
    > Adrian Bunk wrote:
    > >
    > > On Thu, Oct 16, 2008 at 09:57:11AM +0200, Takashi Iwai wrote:
    > > > At Thu, 16 Oct 2008 10:38:36 +0300,
    > > > Adrian Bunk wrote:
    > > > >
    > > > > On Thu, Oct 16, 2008 at 07:57:29AM +0200, Takashi Iwai wrote:
    > > > > > At Wed, 15 Oct 2008 21:33:37 -0700,
    > > > > > Andrew Morton wrote:
    > > > > > >
    > > > > > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    > > > > > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026)
    > > > > >
    > > > > > These are definitions of deprecated interfaces.
    > > > > > We can remove it in 2.6.29. If we don't want to be conservative, it
    > > > > > can be removed in 2.6.28, too.
    > > > > >...
    > > > >
    > > > > Since it's an in-kernel API there's no reason to keep it once there are
    > > > > no users left.
    > > >
    > > > Right. But, IMO, now is no suitable time.
    > > > A thing like API removal should have been tested in linux-next, and we
    > > > had plenty of time indeed for 2.6.28.
    > > >...

    > >
    > > A grep through the tree and one test compile that covers
    > > sound/soc/soc-dapm.c should be enough testing.
    > >
    > > And having it then in -next once should be enough to discover if someone
    > > wrongly added a new user.

    >
    > My point is the time for removal. The API changes should have been
    > done in the merge window, and it should have been tested *before* the
    > merge window.
    >...


    My point is simply that compared to many other patches that weren't
    tested before the merge window, and that still get (for various reasons)
    into the tree, the removal of unused functions is extremely low-risk
    (assuming the patch creator knows what grep is and does a test compile
    of the changed code).

    > thanks,
    >
    > Takashi


    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  19. Re: powerpc allmodconfig

    Hello.

    Andrew Morton wrote:
    > drivers/ide/pci/hpt366.c: In function 'init_hwif_hpt366':
    > drivers/ide/pci/hpt366.c:1292: warning: unused variable 'dev'
    >


    Patch (even two) for this one has been submitted

    > drivers/ide/pci/scc_pata.c: In function 'init_hwif_scc':
    > drivers/ide/pci/scc_pata.c:846: warning: unused variable 'ports'
    >


    Hm, but not for this one...

    > drivers/serial/serial_txx9.c: In function 'serial_txx9_probe':
    > drivers/serial/serial_txx9.c:1041: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'long unsigned int'
    >


    Atsushi-san, are you seeing this one?

    MBR, Sergei


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  20. [PATCH] ibm_newemac: Fix new MAL feature handling

    On Thu, Oct 16, 2008 at 03:56:50PM +1100, Benjamin Herrenschmidt wrote:
    >> drivers/net/ibm_newemac/mal.c: In function 'mal_txeob':
    >> drivers/net/ibm_newemac/mal.c:284: error: implicit declaration of function 'mtdcri'
    >> drivers/net/ibm_newemac/mal.c:284: error: 'SDR0' undeclared (first use in this function)
    >> drivers/net/ibm_newemac/mal.c:284: error: (Each undeclared identifier is reported only once
    >> drivers/net/ibm_newemac/mal.c:284: error: for each function it appears in.)
    >> drivers/net/ibm_newemac/mal.c:285: error: implicit declaration of function 'mfdcri'
    >> drivers/net/ibm_newemac/mal.c: In function 'mal_rxeob':
    >> drivers/net/ibm_newemac/mal.c:302: error: 'SDR0' undeclared (first use in this function)

    >
    >That's annoying, I'll have a look.


    Support for new features needed by the PPC 405EZ boards
    introduced some errors in the MAL and EMAC feature handling.
    This broke 'allmodconfig' builds as CONFIG_PPC_DCR_NATIVE is
    not set for those.

    This patch fixes these errors by wrapping the code in the
    appropriate #ifdefs.

    Signed-off-by: Josh Boyer

    ---

    diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
    index efcf21c..2ee2622 100644
    --- a/drivers/net/ibm_newemac/core.c
    +++ b/drivers/net/ibm_newemac/core.c
    @@ -2604,8 +2604,16 @@ static int __devinit emac_init_config(struct emac_instance *dev)
    if (of_device_is_compatible(np, "ibm,emac-440ep") ||
    of_device_is_compatible(np, "ibm,emac-440gr"))
    dev->features |= EMAC_FTR_440EP_PHY_CLK_FIX;
    - if (of_device_is_compatible(np, "ibm,emac-405ez"))
    + if (of_device_is_compatible(np, "ibm,emac-405ez")) {
    +#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
    dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
    +#else
    + printk(KERN_ERR "%s: Flow control not disabled!\n",
    + np->full_name);
    + return -ENXIO;
    +#endif
    + }
    +
    }

    /* Fixup some feature bits based on the device tree */
    diff --git a/drivers/net/ibm_newemac/mal.c b/drivers/net/ibm_newemac/mal.c
    index 1839d3f..ecf9798 100644
    --- a/drivers/net/ibm_newemac/mal.c
    +++ b/drivers/net/ibm_newemac/mal.c
    @@ -280,9 +280,11 @@ static irqreturn_t mal_txeob(int irq, void *dev_instance)
    mal_schedule_poll(mal);
    set_mal_dcrn(mal, MAL_TXEOBISR, r);

    +#ifdef CONFIG_PPC_DCR_NATIVE
    if (mal_has_feature(mal, MAL_FTR_CLEAR_ICINTSTAT))
    mtdcri(SDR0, DCRN_SDR_ICINTSTAT,
    (mfdcri(SDR0, DCRN_SDR_ICINTSTAT) | ICINTSTAT_ICTX));
    +#endif

    return IRQ_HANDLED;
    }
    @@ -298,9 +300,11 @@ static irqreturn_t mal_rxeob(int irq, void *dev_instance)
    mal_schedule_poll(mal);
    set_mal_dcrn(mal, MAL_RXEOBISR, r);

    +#ifdef CONFIG_PPC_DCR_NATIVE
    if (mal_has_feature(mal, MAL_FTR_CLEAR_ICINTSTAT))
    mtdcri(SDR0, DCRN_SDR_ICINTSTAT,
    (mfdcri(SDR0, DCRN_SDR_ICINTSTAT) | ICINTSTAT_ICRX));
    +#endif

    return IRQ_HANDLED;
    }
    @@ -572,9 +576,18 @@ static int __devinit mal_probe(struct of_device *ofdev,
    goto fail;
    }

    - if (of_device_is_compatible(ofdev->node, "ibm,mcmal-405ez"))
    + if (of_device_is_compatible(ofdev->node, "ibm,mcmal-405ez")) {
    +#if defined(CONFIG_IBM_NEW_EMAC_MAL_CLR_ICINTSTAT) && \
    + defined(CONFIG_IBM_NEW_EMAC_MAL_COMMON_ERR)
    mal->features |= (MAL_FTR_CLEAR_ICINTSTAT |
    MAL_FTR_COMMON_ERR_INT);
    +#else
    + printk(KERN_ERR "%s: Support for 405EZ not enabled!\n",
    + ofdev->node->full_name);
    + err = -ENODEV;
    + goto fail;
    +#endif
    + }

    mal->txeob_irq = irq_of_parse_and_map(ofdev->node, 0);
    mal->rxeob_irq = irq_of_parse_and_map(ofdev->node, 1);

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread
Page 1 of 2 1 2 LastLast