[PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic() - Kernel

This is a discussion on [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic() - Kernel ; Hi, 2.6.27-git2 kernel build fails with allyesconfig on powerpc with build error CC drivers/net/enic/enic_main.o drivers/net/enic/enic_main.c: In function ‘enic_queue_wq_skb_tso’: drivers/net/enic/enic_main.c:576: error: implicit declaration of function ‘csum_ipv6_magic’ make[3]: *** [drivers/net/enic/enic_main.o] Error 1 drivers/net/qlge/qlge_main.c: In function ‘ql_tso’: drivers/net/qlge/qlge_main.c:1862: error: implicit declaration of function ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

  1. [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

    Hi,
    2.6.27-git2 kernel build fails with allyesconfig on powerpc with
    build error



    CC drivers/net/enic/enic_main.o
    drivers/net/enic/enic_main.c: In function ‘enic_queue_wq_skb_tso’:
    drivers/net/enic/enic_main.c:576: error: implicit declaration of function ‘csum_ipv6_magic’
    make[3]: *** [drivers/net/enic/enic_main.o] Error 1



    drivers/net/qlge/qlge_main.c: In function ‘ql_tso’:
    drivers/net/qlge/qlge_main.c:1862: error: implicit declaration of function ‘csum_ipv6_magic’
    make[3]: *** [drivers/net/qlge/qlge_main.o] Error 1



    drivers/net/jme.c: In function ‘jme_tx_tso’:
    drivers/net/jme.c:1784: error: implicit declaration of function ‘csum_ipv6_magic’
    make[2]: *** [drivers/net/jme.o] Error 1

    The patch is build tested only.

    Signed-off-by: Kamalesh Babulal
    ---
    drivers/net/enic/enic_main.c | 1 +
    drivers/net/jme.c | 1 +
    drivers/net/qlge/qlge_main.c | 1 +
    3 files changed, 3 insertions(+), 0 deletions(-)

    diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
    index f3a47a8..180e968 100644
    --- a/drivers/net/enic/enic_main.c
    +++ b/drivers/net/enic/enic_main.c
    @@ -34,6 +34,7 @@
    #include
    #include
    #include
    +#include

    #include "cq_enet_desc.h"
    #include "vnic_dev.h"
    diff --git a/drivers/net/jme.c b/drivers/net/jme.c
    index 5f9a131..d86e809 100644
    --- a/drivers/net/jme.c
    +++ b/drivers/net/jme.c
    @@ -38,6 +38,7 @@
    #include
    #include
    #include
    +#include
    #include "jme.h"

    static int force_pseudohp = -1;
    diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
    index 3af822b..6675723 100644
    --- a/drivers/net/qlge/qlge_main.c
    +++ b/drivers/net/qlge/qlge_main.c
    @@ -40,6 +40,7 @@
    #include
    #include
    #include
    +#include

    #include "qlge.h"

    --
    Thanks & Regards,
    Kamalesh Babulal,
    Linux Technology Center,
    IBM, ISTL.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

    On Mon, 13 Oct 2008 17:44:41 +0530, Kamalesh Babulal wrote
    > Hi,
    > 2.6.27-git2 kernel build fails with allyesconfig on powerpc with
    > build error
    >
    >
    >
    > CC drivers/net/enic/enic_main.o
    > drivers/net/enic/enic_main.c: In function `nic_queue_wq_skb_tso`:
    > drivers/net/enic/enic_main.c:576: error: implicit declaration of function `sum_ipv6_magic`
    > make[3]: *** [drivers/net/enic/enic_main.o] Error 1
    >
    >
    >
    > drivers/net/qlge/qlge_main.c: In function `l_tso`:
    > drivers/net/qlge/qlge_main.c:1862: error: implicit declaration of function `sum_ipv6_magic`
    > make[3]: *** [drivers/net/qlge/qlge_main.o] Error 1
    >
    >
    >
    > drivers/net/jme.c: In function `me_tx_tso`:
    > drivers/net/jme.c:1784: error: implicit declaration of function `sum_ipv6_magic`
    > make[2]: *** [drivers/net/jme.o] Error 1
    >
    > The patch is build tested only.
    >
    > Signed-off-by: Kamalesh Babulal
    > ---

    Thank you Kamalesh.

    But since compensate the lack of
    `csum_ipv6_magic` function defined in
    of some architecture, should be
    included in as well?

    BTW, if there is a patch against jme driver which I maintain,
    and I just simply agree with it, should I silently noticed that
    and let someone like Jeff or David to review/apply it,
    or should I reply an ack of it?

    Guo-Fu Tseng

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

    Signed-off-by: Ron Mercer

    for qlge:
    Thanks Kamalesh



    On Mon, Oct 13, 2008 at 05:44:41PM +0530, Kamalesh Babulal wrote:
    > Hi,
    > 2.6.27-git2 kernel build fails with allyesconfig on powerpc with
    > build error
    >
    >
    >
    > CC drivers/net/enic/enic_main.o
    > drivers/net/enic/enic_main.c: In function ‘enic_queue_wq_skb_tso’:
    > drivers/net/enic/enic_main.c:576: error: implicit declaration of function ‘csum_ipv6_magic’
    > make[3]: *** [drivers/net/enic/enic_main.o] Error 1
    >
    >
    >
    > drivers/net/qlge/qlge_main.c: In function ‘ql_tso’:
    > drivers/net/qlge/qlge_main.c:1862: error: implicit declaration of function ‘csum_ipv6_magic’
    > make[3]: *** [drivers/net/qlge/qlge_main.o] Error 1
    >
    >
    >
    > drivers/net/jme.c: In function ‘jme_tx_tso’:
    > drivers/net/jme.c:1784: error: implicit declaration of function ‘csum_ipv6_magic’
    > make[2]: *** [drivers/net/jme.o] Error 1
    >
    > The patch is build tested only.
    >
    > Signed-off-by: Kamalesh Babulal
    > ---
    > drivers/net/enic/enic_main.c | 1 +
    > drivers/net/jme.c | 1 +
    > drivers/net/qlge/qlge_main.c | 1 +
    > 3 files changed, 3 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
    > index f3a47a8..180e968 100644
    > --- a/drivers/net/enic/enic_main.c
    > +++ b/drivers/net/enic/enic_main.c
    > @@ -34,6 +34,7 @@
    > #include
    > #include
    > #include
    > +#include
    >
    > #include "cq_enet_desc.h"
    > #include "vnic_dev.h"
    > diff --git a/drivers/net/jme.c b/drivers/net/jme.c
    > index 5f9a131..d86e809 100644
    > --- a/drivers/net/jme.c
    > +++ b/drivers/net/jme.c
    > @@ -38,6 +38,7 @@
    > #include
    > #include
    > #include
    > +#include
    > #include "jme.h"
    >
    > static int force_pseudohp = -1;
    > diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
    > index 3af822b..6675723 100644
    > --- a/drivers/net/qlge/qlge_main.c
    > +++ b/drivers/net/qlge/qlge_main.c
    > @@ -40,6 +40,7 @@
    > #include
    > #include
    > #include
    > +#include
    >
    > #include "qlge.h"
    >
    > --
    > Thanks & Regards,
    > Kamalesh Babulal,
    > Linux Technology Center,
    > IBM, ISTL.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

    From: Ron Mercer
    Date: Mon, 13 Oct 2008 16:09:57 -0700

    > Signed-off-by: Ron Mercer


    I've applied Kamalesh's patch, thanks everyone.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

    From: "Guo-Fu Tseng"
    Date: Tue, 14 Oct 2008 03:28:14 +0800

    > But since compensate the lack of
    > `csum_ipv6_magic` function defined in
    > of some architecture, should be
    > included in as well?


    No, the standard convention is that if you need to call this
    ipv6 checksumming routine you include net/ip6_checksum.h
    From: "Guo-Fu Tseng"
    Date: Tue, 14 Oct 2008 03:28:14 +0800

    > BTW, if there is a patch against jme driver which I maintain,
    > and I just simply agree with it, should I silently noticed that
    > and let someone like Jeff or David to review/apply it,
    > or should I reply an ack of it?


    You can ACK it and I usually apply patches like this directly.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread