[mmotm 10 Oct][PATCH 1/2] fix build error of git-tip - Kernel

This is a discussion on [mmotm 10 Oct][PATCH 1/2] fix build error of git-tip - Kernel ; Oops, I forgot to CCed Tony. sorry. > > Patch name: git-tip-fix.patch > Patch against: mmotm 10 Oct > Applied after: git-tip.patch > > ----------- > git-tip can't build on ia64 because __acpi_unmap_table() function tyep is wrong. > Then it ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: [mmotm 10 Oct][PATCH 1/2] fix build error of git-tip

  1. Re: [mmotm 10 Oct][PATCH 1/2] fix build error of git-tip


    Oops, I forgot to CCed Tony.
    sorry.

    >
    > Patch name: git-tip-fix.patch
    > Patch against: mmotm 10 Oct
    > Applied after: git-tip.patch
    >
    > -----------
    > git-tip can't build on ia64 because __acpi_unmap_table() function tyep is wrong.
    > Then it cause following build error.
    >
    >
    > CC arch/ia64/kernel/acpi.o
    > arch/ia64/kernel/acpi.c:180: error: conflicting types for '__acpi_unmap_table'
    > include/linux/acpi.h:82: error: previous declaration of '__acpi_unmap_table' was here
    > make[1]: *** [arch/ia64/kernel/acpi.o] Error 1
    > make: *** [arch/ia64/kernel] Error 2
    >
    >
    > Signed-off-by: KOSAKI Motohiro
    > CC: Yinghai Lu
    > CC: Ingo Molnar
    >
    > ---
    > arch/ia64/kernel/acpi.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > Index: b/arch/ia64/kernel/acpi.c
    > ================================================== =================
    > --- a/arch/ia64/kernel/acpi.c
    > +++ b/arch/ia64/kernel/acpi.c
    > @@ -176,7 +176,7 @@ char *__init __acpi_map_table(unsigned l
    > return __va(phys_addr);
    > }
    >
    > -char *__init __acpi_unmap_table(unsigned long virt_addr, unsigned long size)
    > +void __init __acpi_unmap_table(char *virt_addr, unsigned long size)
    > {
    > }
    >
    >
    >




    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. [mmotm 10 Oct][PATCH 1/2] fix build error of git-tip


    Patch name: git-tip-fix.patch
    Patch against: mmotm 10 Oct
    Applied after: git-tip.patch

    -----------
    git-tip can't build on ia64 because __acpi_unmap_table() function tyep is wrong.
    Then it cause following build error.


    CC arch/ia64/kernel/acpi.o
    arch/ia64/kernel/acpi.c:180: error: conflicting types for '__acpi_unmap_table'
    include/linux/acpi.h:82: error: previous declaration of '__acpi_unmap_table' was here
    make[1]: *** [arch/ia64/kernel/acpi.o] Error 1
    make: *** [arch/ia64/kernel] Error 2


    Signed-off-by: KOSAKI Motohiro
    CC: Yinghai Lu
    CC: Ingo Molnar

    ---
    arch/ia64/kernel/acpi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: b/arch/ia64/kernel/acpi.c
    ================================================== =================
    --- a/arch/ia64/kernel/acpi.c
    +++ b/arch/ia64/kernel/acpi.c
    @@ -176,7 +176,7 @@ char *__init __acpi_map_table(unsigned l
    return __va(phys_addr);
    }

    -char *__init __acpi_unmap_table(unsigned long virt_addr, unsigned long size)
    +void __init __acpi_unmap_table(char *virt_addr, unsigned long size)
    {
    }



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [mmotm 10 Oct][PATCH 2/2] fix build error of vmscan

    KOSAKI Motohiro wrote:

    > Signed-off-by: KOSAKI Motohiro
    > CC: Rik van Riel
    > CC: Andrew Morton


    The disadvantage of programming-by-email

    Acked-by: Rik van Riel

    --
    All rights reversed.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [mmotm 10 Oct][PATCH 2/2] fix build error of vmscan

    On Sun, 12 Oct 2008, KOSAKI Motohiro wrote:
    >
    > Patch against: mmotm 10 Oct
    > Patch name: vmscan-fix-pagecache-reclaim-referenced-bit-check-fix-fix-fix.patch
    > Applied after: vmscan-fix-pagecache-reclaim-referenced-bit-check-fix-fix.patch
    >
    >
    > --------
    > vmscan-fix-pagecache-reclaim-referenced-bit-check-fix.patch introduce following build error.
    >
    > CC mm/vmscan.o
    > mm/vmscan.c: In function 'shrink_active_list':
    > mm/vmscan.c:1248: error: too few arguments to function 'page_referenced'
    > make[1]: *** [mm/vmscan.o] Error 1
    > make: *** [mm] Error 2
    >
    >
    > Signed-off-by: KOSAKI Motohiro
    > CC: Rik van Riel
    > CC: Andrew Morton


    Excellent though it is, I'd prefer Andrew to ignore your patch:
    because it falls within an unbisectable extent of the mmotm series,
    for which I've now prepared a metapatch including this fix,
    following in a minute or two.

    Thanks,
    Hugh

    >
    > ---
    > mm/vmscan.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > Index: b/mm/vmscan.c
    > ================================================== =================
    > --- a/mm/vmscan.c
    > +++ b/mm/vmscan.c
    > @@ -1245,7 +1245,8 @@ static void shrink_active_list(unsigned
    > }
    >
    > /* page_referenced clears PageReferenced */
    > - if (page_mapping_inuse(page) && page_referenced(page))
    > + if (page_mapping_inuse(page) &&
    > + page_referenced(page, 0, sc->mem_cgroup))
    > pgmoved++;
    >
    > list_add(&page->lru, &l_inactive);

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread