[PATCH] x86/io_apic_32: fix printk format warning - Kernel

This is a discussion on [PATCH] x86/io_apic_32: fix printk format warning - Kernel ; arch/x86/kernel/io_apic_32.c: In function 'print_local_APIC': arch/x86/kernel/io_apic_32.c:1539: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64' arch/x86/kernel/io_apic_32.c:1540: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64' Signed-off-by: Alexander Beregalov --- arch/x86/kernel/io_apic_32.c | 4 ++-- ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] x86/io_apic_32: fix printk format warning

  1. [PATCH] x86/io_apic_32: fix printk format warning

    arch/x86/kernel/io_apic_32.c: In function 'print_local_APIC':
    arch/x86/kernel/io_apic_32.c:1539: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64'
    arch/x86/kernel/io_apic_32.c:1540: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64'

    Signed-off-by: Alexander Beregalov
    ---

    arch/x86/kernel/io_apic_32.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/kernel/io_apic_32.c b/arch/x86/kernel/io_apic_32.c
    index e710289..f678d12 100644
    --- a/arch/x86/kernel/io_apic_32.c
    +++ b/arch/x86/kernel/io_apic_32.c
    @@ -1536,8 +1536,8 @@ __apicdebuginit(void) print_local_APIC(void *dummy)
    }

    icr = apic_icr_read();
    - printk(KERN_DEBUG "... APIC ICR: %08x\n", icr);
    - printk(KERN_DEBUG "... APIC ICR2: %08x\n", icr >> 32);
    + printk(KERN_DEBUG "... APIC ICR: %08x\n", (unsigned int)icr);
    + printk(KERN_DEBUG "... APIC ICR2: %08x\n", (unsigned int)(icr >> 32));

    v = apic_read(APIC_LVTT);
    printk(KERN_DEBUG "... APIC LVTT: %08x\n", v);
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] x86/io_apic_32: fix printk format warning

    Alexander Beregalov wrote:
    > arch/x86/kernel/io_apic_32.c: In function 'print_local_APIC':
    > arch/x86/kernel/io_apic_32.c:1539: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64'
    > arch/x86/kernel/io_apic_32.c:1540: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64'
    >
    > Signed-off-by: Alexander Beregalov
    > ---
    >
    > arch/x86/kernel/io_apic_32.c | 4 ++--
    > 1 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/arch/x86/kernel/io_apic_32.c b/arch/x86/kernel/io_apic_32.c
    > index e710289..f678d12 100644
    > --- a/arch/x86/kernel/io_apic_32.c
    > +++ b/arch/x86/kernel/io_apic_32.c
    > @@ -1536,8 +1536,8 @@ __apicdebuginit(void) print_local_APIC(void *dummy)
    > }
    >
    > icr = apic_icr_read();
    > - printk(KERN_DEBUG "... APIC ICR: %08x\n", icr);
    > - printk(KERN_DEBUG "... APIC ICR2: %08x\n", icr >> 32);
    > + printk(KERN_DEBUG "... APIC ICR: %08x\n", (unsigned int)icr);
    > + printk(KERN_DEBUG "... APIC ICR2: %08x\n", (unsigned int)(icr >> 32));


    looks good, but I think casting to u32 is better, because u32 is used in io_apic_64.c.

    thanks,
    Hiroshi Shimamoto
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread